All of lore.kernel.org
 help / color / mirror / Atom feed
From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/5] perf jevents: add support for arch recommended events
Date: Sat, 9 Dec 2017 08:26:23 +0100	[thread overview]
Message-ID: <20171209072623.GA14297@krava> (raw)
In-Reply-To: <df2f2547-85b3-b522-4021-a2aa84333559@huawei.com>

On Fri, Dec 08, 2017 at 03:38:06PM +0000, John Garry wrote:

SNIP

> > > 
> > > Hi jirka,
> > > 
> 
> Hi jirka,
> 
> > > The linux kernel headers are not used for jevents tool. I would rather use
> > > them if possible...
> > 
> > should be as easy as adding  #include <linux/list.h> ;-)
> > 
> 
> Hi jirka,
> 
> I think the issue is that jevents is a "hostprogs", which does not use
> kernel headers.
> 
> FWIW, here is the symptom:
> pmu-events/jevents.c:51:24: fatal error: linux/list.h: No such file or
> directory
>  #include <linux/list.h>
>                         ^
> compilation terminated.
> mv: cannot stat ?pmu-events/.jevents.o.tmp?: No such file or directory
> 
> perf tool build is different.

yep, need additional in Bukld file, attached

jirka


---
diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index 999a4e878162..b7d2e0e9cbd0 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -1,5 +1,6 @@
 hostprogs := jevents
 
+CHOSTFLAGS      = -I$(srctree)/tools/include
 jevents-y	+= json.o jsmn.o jevents.o
 pmu-events-y	+= pmu-events.o
 JDIR		=  pmu-events/arch/$(SRCARCH)
diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index b578aa26e375..5b9b1fee3dfe 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -47,6 +47,7 @@
 #include "jsmn.h"
 #include "json.h"
 #include "jevents.h"
+#include <linux/list.h>
 
 int verbose;
 char *prog;
@@ -884,6 +885,7 @@ int main(int argc, char *argv[])
 	const char *output_file;
 	const char *start_dirname;
 	struct stat stbuf;
+	struct list_head krava __maybe_unused;
 
 	prog = basename(argv[0]);
 	if (argc < 4) {

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, namhyung@kernel.org,
	ak@linux.intel.com, wcohen@redhat.com, will.deacon@arm.com,
	ganapatrao.kulkarni@cavium.com, catalin.marinas@arm.com,
	mark.rutland@arm.com, xuwei5@hisilicon.com, linuxarm@huawei.com,
	zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events
Date: Sat, 9 Dec 2017 08:26:23 +0100	[thread overview]
Message-ID: <20171209072623.GA14297@krava> (raw)
In-Reply-To: <df2f2547-85b3-b522-4021-a2aa84333559@huawei.com>

On Fri, Dec 08, 2017 at 03:38:06PM +0000, John Garry wrote:

SNIP

> > > 
> > > Hi jirka,
> > > 
> 
> Hi jirka,
> 
> > > The linux kernel headers are not used for jevents tool. I would rather use
> > > them if possible...
> > 
> > should be as easy as adding  #include <linux/list.h> ;-)
> > 
> 
> Hi jirka,
> 
> I think the issue is that jevents is a "hostprogs", which does not use
> kernel headers.
> 
> FWIW, here is the symptom:
> pmu-events/jevents.c:51:24: fatal error: linux/list.h: No such file or
> directory
>  #include <linux/list.h>
>                         ^
> compilation terminated.
> mv: cannot stat ‘pmu-events/.jevents.o.tmp’: No such file or directory
> 
> perf tool build is different.

yep, need additional in Bukld file, attached

jirka


---
diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index 999a4e878162..b7d2e0e9cbd0 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -1,5 +1,6 @@
 hostprogs := jevents
 
+CHOSTFLAGS      = -I$(srctree)/tools/include
 jevents-y	+= json.o jsmn.o jevents.o
 pmu-events-y	+= pmu-events.o
 JDIR		=  pmu-events/arch/$(SRCARCH)
diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index b578aa26e375..5b9b1fee3dfe 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -47,6 +47,7 @@
 #include "jsmn.h"
 #include "json.h"
 #include "jevents.h"
+#include <linux/list.h>
 
 int verbose;
 char *prog;
@@ -884,6 +885,7 @@ int main(int argc, char *argv[])
 	const char *output_file;
 	const char *start_dirname;
 	struct stat stbuf;
+	struct list_head krava __maybe_unused;
 
 	prog = basename(argv[0]);
 	if (argc < 4) {

  reply	other threads:[~2017-12-09  7:26 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 16:13 [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry
2017-12-05 16:13 ` John Garry
2017-12-05 16:13 ` [RFC PATCH 1/5] perf jevents: add support for pmu events vendor subdirectory John Garry
2017-12-05 16:13   ` John Garry
2017-12-06 13:38   ` Jiri Olsa
2017-12-06 13:38     ` Jiri Olsa
2017-12-06 14:41     ` John Garry
2017-12-06 14:41       ` John Garry
2017-12-05 16:13 ` [RFC PATCH 2/5] perf jevents: add support for arch recommended events John Garry
2017-12-05 16:13   ` John Garry
2017-12-05 17:27   ` Andi Kleen
2017-12-05 17:27     ` Andi Kleen
2017-12-06  8:34     ` John Garry
2017-12-06  8:34       ` John Garry
2017-12-06 13:36   ` Jiri Olsa
2017-12-06 13:36     ` Jiri Olsa
2017-12-06 15:20     ` John Garry
2017-12-06 15:20       ` John Garry
2017-12-08 12:29       ` Jiri Olsa
2017-12-08 12:29         ` Jiri Olsa
2017-12-08 15:42         ` John Garry
2017-12-08 15:42           ` John Garry
2017-12-09  7:31           ` Jiri Olsa
2017-12-09  7:31             ` Jiri Olsa
2017-12-11 10:25             ` John Garry
2017-12-11 10:25               ` John Garry
2017-12-15 11:22             ` John Garry
2017-12-15 11:22               ` John Garry
2017-12-16 18:47               ` Andi Kleen
2017-12-16 18:47                 ` Andi Kleen
2018-01-02 12:07                 ` John Garry
2018-01-02 12:07                   ` John Garry
2018-01-02 17:48                   ` Andi Kleen
2018-01-02 17:48                     ` Andi Kleen
2018-01-03 12:22                     ` John Garry
2018-01-03 12:22                       ` John Garry
2017-12-21 19:39               ` Jiri Olsa
2017-12-21 19:39                 ` Jiri Olsa
2018-01-04 17:17                 ` John Garry
2018-01-04 17:17                   ` John Garry
2018-01-08 14:08                   ` Jiri Olsa
2018-01-08 14:08                     ` Jiri Olsa
2017-12-06 13:37   ` Jiri Olsa
2017-12-06 13:37     ` Jiri Olsa
2017-12-06 14:40     ` John Garry
2017-12-06 14:40       ` John Garry
2017-12-08 12:31       ` Jiri Olsa
2017-12-08 12:31         ` Jiri Olsa
2017-12-08 15:38         ` John Garry
2017-12-08 15:38           ` John Garry
2017-12-09  7:26           ` Jiri Olsa [this message]
2017-12-09  7:26             ` Jiri Olsa
2017-12-05 16:13 ` [RFC PATCH 3/5] perf vendor events arm64: add armv8 recommended events JSON John Garry
2017-12-05 16:13   ` John Garry
2017-12-05 16:13 ` [RFC PATCH 4/5] perf vendor events arm64: relocate thunderx2 JSON John Garry
2017-12-05 16:13   ` John Garry
2017-12-05 16:13 ` [RFC PATCH 5/5] perf vendor events arm64: add HiSilicon hip08 JSON John Garry
2017-12-05 16:13   ` John Garry
2017-12-06 16:42 ` [RFC PATCH 0/5] perf events patches for improved ARM64 support William Cohen
2017-12-06 16:42   ` William Cohen
2017-12-06 17:35   ` John Garry
2017-12-06 17:35     ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171209072623.GA14297@krava \
    --to=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.