From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM
Date: Mon, 11 Dec 2017 11:13:43 +0100 [thread overview]
Message-ID: <20171211101343.GG10671@ulmo> (raw)
In-Reply-To: <02bccd8c39c0e7e9d3c6733e238e291e8297c830.1512947732.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Mon, Dec 11, 2017 at 02:19:44AM +0300, Dmitry Osipenko wrote:
> Add manual HW power management to drivers probe/remove in order to
> not fail in a case of runtime power management being disabled in kernel
> config.
>
> Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/gpu/drm/tegra/dc.c | 164 +++++++++++++++++++++++++++----------------
> drivers/gpu/drm/tegra/dsi.c | 138 +++++++++++++++++++++---------------
> drivers/gpu/drm/tegra/hdmi.c | 90 ++++++++++++++++--------
> drivers/gpu/drm/tegra/sor.c | 103 +++++++++++++++++----------
> 4 files changed, 310 insertions(+), 185 deletions(-)
I think that's the wrong way around. We unconditionally select PM on
64-bit ARM already, and I think we should do the same on 32-bit ARM.
There's really no excuse not to enable runtime PM these days.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM
Date: Mon, 11 Dec 2017 11:13:43 +0100 [thread overview]
Message-ID: <20171211101343.GG10671@ulmo> (raw)
In-Reply-To: <02bccd8c39c0e7e9d3c6733e238e291e8297c830.1512947732.git.digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Mon, Dec 11, 2017 at 02:19:44AM +0300, Dmitry Osipenko wrote:
> Add manual HW power management to drivers probe/remove in order to
> not fail in a case of runtime power management being disabled in kernel
> config.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/gpu/drm/tegra/dc.c | 164 +++++++++++++++++++++++++++----------------
> drivers/gpu/drm/tegra/dsi.c | 138 +++++++++++++++++++++---------------
> drivers/gpu/drm/tegra/hdmi.c | 90 ++++++++++++++++--------
> drivers/gpu/drm/tegra/sor.c | 103 +++++++++++++++++----------
> 4 files changed, 310 insertions(+), 185 deletions(-)
I think that's the wrong way around. We unconditionally select PM on
64-bit ARM already, and I think we should do the same on 32-bit ARM.
There's really no excuse not to enable runtime PM these days.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-11 10:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 23:19 [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20 Dmitry Osipenko
2017-12-10 23:19 ` Dmitry Osipenko
[not found] ` <85902b42264b094cbf7cf30930f8c0bbccdca1b7.1512947732.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-10 23:19 ` [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM Dmitry Osipenko
2017-12-10 23:19 ` Dmitry Osipenko
[not found] ` <02bccd8c39c0e7e9d3c6733e238e291e8297c830.1512947732.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-11 10:13 ` Thierry Reding [this message]
2017-12-11 10:13 ` Thierry Reding
2017-12-11 13:53 ` Dmitry Osipenko
2017-12-11 13:53 ` Dmitry Osipenko
[not found] ` <f04f7268-bcf8-feab-bded-88a166b3b474-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-11 14:08 ` Dmitry Osipenko
2017-12-11 14:08 ` Dmitry Osipenko
2017-12-11 14:27 ` Thierry Reding
2017-12-11 14:27 ` Thierry Reding
2017-12-11 15:26 ` Dmitry Osipenko
2017-12-11 15:26 ` Dmitry Osipenko
[not found] ` <5c0435f4-88ae-282c-f096-b8dd7226ab0e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-14 21:41 ` Lucas Stach
2017-12-14 21:41 ` Lucas Stach
[not found] ` <1513287684.16053.4.camel-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2017-12-14 22:45 ` Dmitry Osipenko
2017-12-14 22:45 ` Dmitry Osipenko
[not found] ` <f20a67a1-92c6-2dff-aa60-958801e53c06-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-15 20:25 ` Lucas Stach
2017-12-15 20:25 ` Lucas Stach
[not found] ` <1513369532.16053.6.camel-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2017-12-15 20:54 ` Dmitry Osipenko
2017-12-15 20:54 ` Dmitry Osipenko
2017-12-14 23:19 ` Dmitry Osipenko
2017-12-14 23:19 ` Dmitry Osipenko
2017-12-11 10:12 ` [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20 Thierry Reding
2017-12-11 10:12 ` Thierry Reding
2017-12-11 14:59 ` Dmitry Osipenko
2017-12-11 14:59 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211101343.GG10671@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.