From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Ramon Fried <rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Loic Poulain
<loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v2] wcn36xx: Fix dynamic power saving
Date: Mon, 11 Dec 2017 07:41:40 -0800 [thread overview]
Message-ID: <20171211154140.GD4803@minitux> (raw)
In-Reply-To: <20171211153403.GA30332-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Mon 11 Dec 07:34 PST 2017, Ramon Fried wrote:
> On Mon, Dec 11, 2017 at 10:52:22AM +0200, Loic Poulain wrote:
> > Since driver does not report hardware dynamic power saving cap,
> > this is up to the mac80211 to manage power saving timeout and
> > state machine, using the ieee80211 config callback to report
> > PS changes. This patch enables/disables PS mode according to
> > the new configuration.
> >
> > Remove old behaviour enabling PS mode in a static way, this make
> > the device unusable when power save is enabled since device is
> > forced to PS regardless RX/TX traffic.
> >
>
> Hi.
> I tried to see if this patch solves the ping delay once power save is
> turned on and it appears it doesn't (log below).
> I do see some change in the delay though in comparison to testing without the patch.
> Bjorn, How did you test it ?
>
Without this patch I get ping times around a second and SSH is not
usable, with this patch I see similar ping times as you, but SSH is
usable.
I have not been able to run iperf, because I keep hitting
https://bugs.96boards.org/show_bug.cgi?id=663
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ramon Fried <rfried@codeaurora.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
kvalo@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
k.eugene.e@gmail.com
Subject: Re: [PATCH v2] wcn36xx: Fix dynamic power saving
Date: Mon, 11 Dec 2017 07:41:40 -0800 [thread overview]
Message-ID: <20171211154140.GD4803@minitux> (raw)
In-Reply-To: <20171211153403.GA30332@codeaurora.org>
On Mon 11 Dec 07:34 PST 2017, Ramon Fried wrote:
> On Mon, Dec 11, 2017 at 10:52:22AM +0200, Loic Poulain wrote:
> > Since driver does not report hardware dynamic power saving cap,
> > this is up to the mac80211 to manage power saving timeout and
> > state machine, using the ieee80211 config callback to report
> > PS changes. This patch enables/disables PS mode according to
> > the new configuration.
> >
> > Remove old behaviour enabling PS mode in a static way, this make
> > the device unusable when power save is enabled since device is
> > forced to PS regardless RX/TX traffic.
> >
>
> Hi.
> I tried to see if this patch solves the ping delay once power save is
> turned on and it appears it doesn't (log below).
> I do see some change in the delay though in comparison to testing without the patch.
> Bjorn, How did you test it ?
>
Without this patch I get ping times around a second and SSH is not
usable, with this patch I see similar ping times as you, but SSH is
usable.
I have not been able to run iperf, because I keep hitting
https://bugs.96boards.org/show_bug.cgi?id=663
Regards,
Bjorn
next prev parent reply other threads:[~2017-12-11 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 8:52 [PATCH v2] wcn36xx: Fix dynamic power saving Loic Poulain
[not found] ` <1512982342-10343-1-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-11 15:34 ` Ramon Fried
2017-12-11 15:34 ` Ramon Fried
[not found] ` <20171211153403.GA30332-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-11 15:41 ` Bjorn Andersson [this message]
2017-12-11 15:41 ` Bjorn Andersson
2017-12-11 17:43 ` Loic Poulain
2017-12-11 17:43 ` Loic Poulain
2017-12-12 12:03 ` Kalle Valo
2017-12-12 12:03 ` Kalle Valo
[not found] ` <87bmj4qhkm.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2017-12-12 12:40 ` Kalle Valo
2017-12-12 12:40 ` Kalle Valo
[not found] ` <877etsqftz.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2017-12-12 13:17 ` Loic Poulain
2017-12-12 13:17 ` Loic Poulain
2018-01-04 16:48 ` [v2] " Kalle Valo
2018-01-04 16:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211154140.GD4803@minitux \
--to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.