* [PATCH] crypto: gf128mul - remove incorrect comment
@ 2017-12-11 21:58 Eric Biggers
2017-12-22 9:07 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2017-12-11 21:58 UTC (permalink / raw)
To: linux-crypto, Herbert Xu; +Cc: Eric Biggers, Harsh Jain
From: Eric Biggers <ebiggers@google.com>
The comment in gf128mul_x8_ble() was copy-and-pasted from gf128mul.h and
makes no sense in the new context. Remove it.
Cc: Harsh Jain <harsh@chelsio.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/gf128mul.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c
index 24e601954c7a..a4b1c026aaee 100644
--- a/crypto/gf128mul.c
+++ b/crypto/gf128mul.c
@@ -160,8 +160,6 @@ void gf128mul_x8_ble(le128 *r, const le128 *x)
{
u64 a = le64_to_cpu(x->a);
u64 b = le64_to_cpu(x->b);
-
- /* equivalent to gf128mul_table_be[b >> 63] (see crypto/gf128mul.c): */
u64 _tt = gf128mul_table_be[a >> 56];
r->a = cpu_to_le64((a << 8) | (b >> 56));
--
2.15.1.424.g9478a66081-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: gf128mul - remove incorrect comment
2017-12-11 21:58 [PATCH] crypto: gf128mul - remove incorrect comment Eric Biggers
@ 2017-12-22 9:07 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-12-22 9:07 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-crypto, Eric Biggers, Harsh Jain
On Mon, Dec 11, 2017 at 01:58:26PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The comment in gf128mul_x8_ble() was copy-and-pasted from gf128mul.h and
> makes no sense in the new context. Remove it.
>
> Cc: Harsh Jain <harsh@chelsio.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-22 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 21:58 [PATCH] crypto: gf128mul - remove incorrect comment Eric Biggers
2017-12-22 9:07 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.