From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>, Yi Zhang <yi.zhang@redhat.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH 4/6] blk-mq: avoid to map CPU into stale hw queue
Date: Tue, 12 Dec 2017 15:12:43 +0100 [thread overview]
Message-ID: <20171212141243.GA7849@lst.de> (raw)
In-Reply-To: <20171212110232.12495-5-ming.lei@redhat.com>
On Tue, Dec 12, 2017 at 07:02:30PM +0800, Ming Lei wrote:
> blk_mq_pci_map_queues() may not map one CPU into any hw queue, but its
> previous map isn't cleared yet, and may point to one stale hw queue
> index.
>
> This patch fixes the following issue by clearing the mapping table before
> setting it up in blk_mq_pci_map_queues().
This needs to be done in the caller intead of the transport specific
queue map helpers.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/6] blk-mq: avoid to map CPU into stale hw queue
Date: Tue, 12 Dec 2017 15:12:43 +0100 [thread overview]
Message-ID: <20171212141243.GA7849@lst.de> (raw)
In-Reply-To: <20171212110232.12495-5-ming.lei@redhat.com>
On Tue, Dec 12, 2017@07:02:30PM +0800, Ming Lei wrote:
> blk_mq_pci_map_queues() may not map one CPU into any hw queue, but its
> previous map isn't cleared yet, and may point to one stale hw queue
> index.
>
> This patch fixes the following issue by clearing the mapping table before
> setting it up in blk_mq_pci_map_queues().
This needs to be done in the caller intead of the transport specific
queue map helpers.
next prev parent reply other threads:[~2017-12-12 14:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 11:02 [PATCH 0/6] blk-mq: fix race related with device deletion/reset/switching sched Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 11:02 ` [PATCH 1/6] blk-mq: quiesce queue before freeing queue Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 11:02 ` [PATCH 2/6] blk-mq: support concurrent blk_mq_quiesce_queue() Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 11:02 ` [PATCH 3/6] blk-mq: quiesce queue during switching io sched and updating nr_requests Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 11:02 ` [PATCH 4/6] blk-mq: avoid to map CPU into stale hw queue Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 14:12 ` Christoph Hellwig [this message]
2017-12-12 14:12 ` Christoph Hellwig
2017-12-12 15:12 ` Ming Lei
2017-12-12 15:12 ` Ming Lei
2017-12-12 11:02 ` [PATCH 5/6] blk-mq: fix race between updating nr_hw_queues and switching io sched Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 11:02 ` [PATCH 6/6] nvme: remove .init_request callback Ming Lei
2017-12-12 11:02 ` Ming Lei
2017-12-12 14:13 ` Christoph Hellwig
2017-12-12 14:13 ` Christoph Hellwig
2017-12-12 15:10 ` Ming Lei
2017-12-12 15:10 ` Ming Lei
2017-12-13 6:43 ` Ming Lei
2017-12-13 6:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212141243.GA7849@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.