From: marcelo.leitner@gmail.com (Marcelo Ricardo Leitner)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 2/4] sctp: Add ip option support
Date: Tue, 12 Dec 2017 19:56:38 -0200 [thread overview]
Message-ID: <20171212215638.GH3532@localhost.localdomain> (raw)
In-Reply-To: <CAHC9VhR+WoO3UtdXLp+9mQ=c=avpEQ5-W8vTkEWfxXH1EkUS8A@mail.gmail.com>
On Tue, Dec 12, 2017 at 04:33:03PM -0500, Paul Moore wrote:
> On Tue, Dec 12, 2017 at 11:08 AM, Marcelo Ricardo Leitner
> <marcelo.leitner@gmail.com> wrote:
> > Hi Richard,
> >
> > On Mon, Nov 27, 2017 at 07:31:21PM +0000, Richard Haines wrote:
> > ...
> >> --- a/net/sctp/socket.c
> >> +++ b/net/sctp/socket.c
> >> @@ -3123,8 +3123,10 @@ static int sctp_setsockopt_maxseg(struct sock *sk, char __user *optval, unsigned
> >>
> >> if (asoc) {
> >> if (val == 0) {
> >> + struct sctp_af *af = sp->pf->af;
> >> val = asoc->pathmtu;
> >> - val -= sp->pf->af->net_header_len;
> >> + val -= af->ip_options_len(asoc->base.sk);
> >> + val -= af->net_header_len;
> >> val -= sizeof(struct sctphdr) +
> >> sizeof(struct sctp_data_chunk);
> >> }
> >
> > Right below here there is a call to sctp_frag_point(). That function
> > also needs this tweak.
> >
> > Yes, we should simplify all these calculations. I have a patch to use
> > sctp_frag_point on where it is currently recalculating it on
> > sctp_datamsg_from_user(), but probably should include other places as
> > well.
>
> FYI: Richard let me know he is occupied with another project at the
> moment and likely won't be able to do another respin until next week
> at the earliest.
Okay, thanks. I can do a follow-up patch if it helps.
Marcelo
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/4] sctp: Add ip option support
Date: Tue, 12 Dec 2017 21:56:38 +0000 [thread overview]
Message-ID: <20171212215638.GH3532@localhost.localdomain> (raw)
In-Reply-To: <CAHC9VhR+WoO3UtdXLp+9mQ=c=avpEQ5-W8vTkEWfxXH1EkUS8A@mail.gmail.com>
On Tue, Dec 12, 2017 at 04:33:03PM -0500, Paul Moore wrote:
> On Tue, Dec 12, 2017 at 11:08 AM, Marcelo Ricardo Leitner
> <marcelo.leitner@gmail.com> wrote:
> > Hi Richard,
> >
> > On Mon, Nov 27, 2017 at 07:31:21PM +0000, Richard Haines wrote:
> > ...
> >> --- a/net/sctp/socket.c
> >> +++ b/net/sctp/socket.c
> >> @@ -3123,8 +3123,10 @@ static int sctp_setsockopt_maxseg(struct sock *sk, char __user *optval, unsigned
> >>
> >> if (asoc) {
> >> if (val = 0) {
> >> + struct sctp_af *af = sp->pf->af;
> >> val = asoc->pathmtu;
> >> - val -= sp->pf->af->net_header_len;
> >> + val -= af->ip_options_len(asoc->base.sk);
> >> + val -= af->net_header_len;
> >> val -= sizeof(struct sctphdr) +
> >> sizeof(struct sctp_data_chunk);
> >> }
> >
> > Right below here there is a call to sctp_frag_point(). That function
> > also needs this tweak.
> >
> > Yes, we should simplify all these calculations. I have a patch to use
> > sctp_frag_point on where it is currently recalculating it on
> > sctp_datamsg_from_user(), but probably should include other places as
> > well.
>
> FYI: Richard let me know he is occupied with another project at the
> moment and likely won't be able to do another respin until next week
> at the earliest.
Okay, thanks. I can do a follow-up patch if it helps.
Marcelo
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Richard Haines <richard_c_haines@btinternet.com>,
selinux@tycho.nsa.gov, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org,
linux-security-module@vger.kernel.org,
Vlad Yasevich <vyasevich@gmail.com>,
nhorman@tuxdriver.com, Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>
Subject: Re: [PATCH 2/4] sctp: Add ip option support
Date: Tue, 12 Dec 2017 19:56:38 -0200 [thread overview]
Message-ID: <20171212215638.GH3532@localhost.localdomain> (raw)
In-Reply-To: <CAHC9VhR+WoO3UtdXLp+9mQ=c=avpEQ5-W8vTkEWfxXH1EkUS8A@mail.gmail.com>
On Tue, Dec 12, 2017 at 04:33:03PM -0500, Paul Moore wrote:
> On Tue, Dec 12, 2017 at 11:08 AM, Marcelo Ricardo Leitner
> <marcelo.leitner@gmail.com> wrote:
> > Hi Richard,
> >
> > On Mon, Nov 27, 2017 at 07:31:21PM +0000, Richard Haines wrote:
> > ...
> >> --- a/net/sctp/socket.c
> >> +++ b/net/sctp/socket.c
> >> @@ -3123,8 +3123,10 @@ static int sctp_setsockopt_maxseg(struct sock *sk, char __user *optval, unsigned
> >>
> >> if (asoc) {
> >> if (val == 0) {
> >> + struct sctp_af *af = sp->pf->af;
> >> val = asoc->pathmtu;
> >> - val -= sp->pf->af->net_header_len;
> >> + val -= af->ip_options_len(asoc->base.sk);
> >> + val -= af->net_header_len;
> >> val -= sizeof(struct sctphdr) +
> >> sizeof(struct sctp_data_chunk);
> >> }
> >
> > Right below here there is a call to sctp_frag_point(). That function
> > also needs this tweak.
> >
> > Yes, we should simplify all these calculations. I have a patch to use
> > sctp_frag_point on where it is currently recalculating it on
> > sctp_datamsg_from_user(), but probably should include other places as
> > well.
>
> FYI: Richard let me know he is occupied with another project at the
> moment and likely won't be able to do another respin until next week
> at the earliest.
Okay, thanks. I can do a follow-up patch if it helps.
Marcelo
next prev parent reply other threads:[~2017-12-12 21:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 19:31 [PATCH 2/4] sctp: Add ip option support Richard Haines
2017-11-27 19:31 ` Richard Haines
2017-11-27 19:31 ` Richard Haines
2017-12-12 16:08 ` Marcelo Ricardo Leitner
2017-12-12 16:08 ` Marcelo Ricardo Leitner
2017-12-12 16:08 ` Marcelo Ricardo Leitner
2017-12-12 17:08 ` Marcelo Ricardo Leitner
2017-12-12 17:08 ` Marcelo Ricardo Leitner
2017-12-12 17:08 ` Marcelo Ricardo Leitner
2017-12-12 21:33 ` Paul Moore
2017-12-12 21:33 ` Paul Moore
2017-12-12 21:33 ` Paul Moore
2017-12-12 21:56 ` Marcelo Ricardo Leitner [this message]
2017-12-12 21:56 ` Marcelo Ricardo Leitner
2017-12-12 21:56 ` Marcelo Ricardo Leitner
2017-12-12 22:24 ` Paul Moore
2017-12-12 22:24 ` Paul Moore
2017-12-12 22:24 ` Paul Moore
2017-12-14 21:04 ` Marcelo Ricardo Leitner
2017-12-14 21:04 ` Marcelo Ricardo Leitner
2017-12-14 21:04 ` Marcelo Ricardo Leitner
2017-12-15 14:02 ` Paul Moore
2017-12-15 14:02 ` Paul Moore
2017-12-15 14:02 ` Paul Moore
2017-12-15 14:02 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212215638.GH3532@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.