All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
	jacek.anaszewski@gmail.com, pavel@ucw.cz
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding
Date: Tue, 12 Dec 2017 16:01:39 -0600	[thread overview]
Message-ID: <20171212220143.31210-3-dmurphy@ti.com> (raw)
In-Reply-To: <20171212220143.31210-1-dmurphy@ti.com>

Update the lp8860 label binding to the LED
standard as documented in

Documentation/devicetree/bindings/leds/common.txt

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v4 - No changes

v3 - Added address and size cells, updated label with color and inserted spaces
around the reg node - https://patchwork.kernel.org/patch/10093749/
v2 - Added reg to child node and made it required

 Documentation/devicetree/bindings/leds/leds-lp8860.txt | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
index b9d09acbaa73..c3d64ade1e26 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
@@ -9,20 +9,33 @@ Required properties:
 	- compatible :
 		"ti,lp8860"
 	- reg : I2C slave address
-	- label : Used for naming LEDs
+	- #address-cells : 1
+	- #size-cells : 0
 
 Optional properties:
 	- enable-gpios : gpio pin to enable (active high)/disable the device.
 	- vled-supply : LED supply
 
+Required child properties:
+	- reg : 0
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+
 Example:
 
 led-controller@2d {
 	compatible = "ti,lp8860";
+	#address-cells = <1>;
+	#size-cells = <0>;
 	reg = <0x2d>;
-	label = "display_cluster";
 	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
 	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		label = "white:display_cluster";
+	};
 }
 
 For more product information please see the link below:
-- 
2.15.0.124.g7668cbc60

WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
	<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-leds@vger.kernel.org>, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding
Date: Tue, 12 Dec 2017 16:01:39 -0600	[thread overview]
Message-ID: <20171212220143.31210-3-dmurphy@ti.com> (raw)
In-Reply-To: <20171212220143.31210-1-dmurphy@ti.com>

Update the lp8860 label binding to the LED
standard as documented in

Documentation/devicetree/bindings/leds/common.txt

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v4 - No changes

v3 - Added address and size cells, updated label with color and inserted spaces
around the reg node - https://patchwork.kernel.org/patch/10093749/
v2 - Added reg to child node and made it required

 Documentation/devicetree/bindings/leds/leds-lp8860.txt | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
index b9d09acbaa73..c3d64ade1e26 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
@@ -9,20 +9,33 @@ Required properties:
 	- compatible :
 		"ti,lp8860"
 	- reg : I2C slave address
-	- label : Used for naming LEDs
+	- #address-cells : 1
+	- #size-cells : 0
 
 Optional properties:
 	- enable-gpios : gpio pin to enable (active high)/disable the device.
 	- vled-supply : LED supply
 
+Required child properties:
+	- reg : 0
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+
 Example:
 
 led-controller@2d {
 	compatible = "ti,lp8860";
+	#address-cells = <1>;
+	#size-cells = <0>;
 	reg = <0x2d>;
-	label = "display_cluster";
 	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
 	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		label = "white:display_cluster";
+	};
 }
 
 For more product information please see the link below:
-- 
2.15.0.124.g7668cbc60

  parent reply	other threads:[~2017-12-12 22:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 22:01 [PATCH v4 0/6] Updated LP8860 driver series Dan Murphy
2017-12-12 22:01 ` Dan Murphy
2017-12-12 22:01 ` [PATCH v4 1/6] dt: bindings: lp8860: Update bindings for lp8860 Dan Murphy
2017-12-12 22:01   ` Dan Murphy
2017-12-15 22:56   ` Rob Herring
2017-12-15 22:57   ` Rob Herring
2017-12-12 22:01 ` Dan Murphy [this message]
2017-12-12 22:01   ` [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding Dan Murphy
     [not found]   ` <20171212220143.31210-3-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15 22:59     ` Rob Herring
2017-12-15 22:59       ` Rob Herring
2017-12-18 13:08       ` Dan Murphy
2017-12-18 13:08         ` Dan Murphy
2017-12-12 22:01 ` [PATCH v4 3/6] leds: lp8860: Update the dt parsing for LED labeling Dan Murphy
2017-12-12 22:01   ` Dan Murphy
     [not found] ` <20171212220143.31210-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-12 22:01   ` [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Dan Murphy
2017-12-12 22:01     ` Dan Murphy
     [not found]     ` <20171212220143.31210-5-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-15  9:09       ` Pavel Machek
2017-12-15  9:09         ` Pavel Machek
2017-12-15 17:22         ` Dan Murphy
2017-12-15 17:22           ` Dan Murphy
     [not found]           ` <76329432-f96e-93ab-ed9b-ade22c8735c9-l0cyMroinI0@public.gmane.org>
2017-12-15 21:00             ` Pavel Machek
2017-12-15 21:00               ` Pavel Machek
2017-12-12 22:01 ` [PATCH v4 5/6] leds: lp8860: Add DT parsing to retrieve the trigger node Dan Murphy
2017-12-12 22:01   ` Dan Murphy
2017-12-12 22:01 ` [PATCH v4 6/6] leds: lp8860: Various fixes to align with LED framework Dan Murphy
2017-12-12 22:01   ` Dan Murphy
2017-12-13 19:55 ` [PATCH v4 0/6] Updated LP8860 driver series Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212220143.31210-3-dmurphy@ti.com \
    --to=dmurphy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.