From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 3/3] build.sh: Allow to overwrite prefix
Date: Wed, 13 Dec 2017 17:12:00 +0100 [thread overview]
Message-ID: <20171213161159.GB22116@rei> (raw)
In-Reply-To: <20171213144101.54egpm2q4nbb5asc@dell5510>
Hi!
> Yes. It works well how it is, I just find it quite unusual not to use getopt(s). And
> mixing parameters with and without '-' as I did is bad.
> Whole point of these changes is to make the script usable also for local development
> (sometimes one may want to run two builds, thats why it's good to allow overwrite prefix).
>
> Maybe I should have used getopts short option with values, even I don't like short values:
>
> ./build.sh [ -t 32|cross|out ] [ -p PREFIX_DIR ] [ -c CC ]
This does not seem that bad to me.
I would like to avoid passing half of the parameters via argv and half
via env variables if possible.
> I decided leave out-of-tree on it's own (native only). But it would be possible to have
> e.g. out-of-tree 32-bit compilation, but I don't see much advantages for it.
I think that as well, the out/in tree build is orthogonal problem to the
compiler and it's unlikely that things would break.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-12-13 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 13:13 [LTP] [RFC PATCH 3/3] build.sh: Allow to overwrite prefix Petr Vorel
2017-12-13 13:59 ` Cyril Hrubis
2017-12-13 14:41 ` Petr Vorel
2017-12-13 16:12 ` Cyril Hrubis [this message]
2017-12-14 19:19 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213161159.GB22116@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.