All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
	davem@davemloft.net
Subject: Re: [PATCHv2 net-next 6/8] sctp: add stream interleave support in stream scheduler
Date: Thu, 14 Dec 2017 18:26:25 +0000	[thread overview]
Message-ID: <20171214182625.GN3532@localhost.localdomain> (raw)
In-Reply-To: <754ccfd8f4be04136dafa1d86deb8ee812638887.1513269224.git.lucien.xin@gmail.com>

On Fri, Dec 15, 2017 at 12:41:30AM +0800, Xin Long wrote:
> As Marcelo said in the stream scheduler patch:
> 
>   Support for I-DATA chunks, also described in RFC8260, with user message
>   interleaving is straightforward as it just requires the schedulers to
>   probe for the feature and ignore datamsg boundaries when dequeueing.
> 
> All needs to do is just to ignore datamsg boundaries when dequeueing.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>

> ---
>  net/sctp/stream_sched.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sctp/stream_sched.c b/net/sctp/stream_sched.c
> index d8c162a..f5fcd42 100644
> --- a/net/sctp/stream_sched.c
> +++ b/net/sctp/stream_sched.c
> @@ -242,7 +242,8 @@ int sctp_sched_get_value(struct sctp_association *asoc, __u16 sid,
>  
>  void sctp_sched_dequeue_done(struct sctp_outq *q, struct sctp_chunk *ch)
>  {
> -	if (!list_is_last(&ch->frag_list, &ch->msg->chunks)) {
> +	if (!list_is_last(&ch->frag_list, &ch->msg->chunks) &&
> +	    !q->asoc->intl_enable) {
>  		struct sctp_stream_out *sout;
>  		__u16 sid;
>  
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
	davem@davemloft.net
Subject: Re: [PATCHv2 net-next 6/8] sctp: add stream interleave support in stream scheduler
Date: Thu, 14 Dec 2017 16:26:25 -0200	[thread overview]
Message-ID: <20171214182625.GN3532@localhost.localdomain> (raw)
In-Reply-To: <754ccfd8f4be04136dafa1d86deb8ee812638887.1513269224.git.lucien.xin@gmail.com>

On Fri, Dec 15, 2017 at 12:41:30AM +0800, Xin Long wrote:
> As Marcelo said in the stream scheduler patch:
> 
>   Support for I-DATA chunks, also described in RFC8260, with user message
>   interleaving is straightforward as it just requires the schedulers to
>   probe for the feature and ignore datamsg boundaries when dequeueing.
> 
> All needs to do is just to ignore datamsg boundaries when dequeueing.
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>

> ---
>  net/sctp/stream_sched.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sctp/stream_sched.c b/net/sctp/stream_sched.c
> index d8c162a..f5fcd42 100644
> --- a/net/sctp/stream_sched.c
> +++ b/net/sctp/stream_sched.c
> @@ -242,7 +242,8 @@ int sctp_sched_get_value(struct sctp_association *asoc, __u16 sid,
>  
>  void sctp_sched_dequeue_done(struct sctp_outq *q, struct sctp_chunk *ch)
>  {
> -	if (!list_is_last(&ch->frag_list, &ch->msg->chunks)) {
> +	if (!list_is_last(&ch->frag_list, &ch->msg->chunks) &&
> +	    !q->asoc->intl_enable) {
>  		struct sctp_stream_out *sout;
>  		__u16 sid;
>  
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  parent reply	other threads:[~2017-12-14 18:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 16:41 [PATCHv2 net-next 0/8] sctp: Implement Stream Interleave: Interaction with Other SCTP Extensions Xin Long
2017-12-14 16:41 ` Xin Long
2017-12-14 16:41 ` [PATCHv2 net-next 1/8] sctp: add basic structures and make chunk function for ifwdtsn Xin Long
2017-12-14 16:41   ` Xin Long
2017-12-14 16:41   ` [PATCHv2 net-next 2/8] sctp: implement generate_ftsn for sctp_stream_interleave Xin Long
2017-12-14 16:41     ` Xin Long
2017-12-14 16:41     ` [PATCHv2 net-next 3/8] sctp: implement validate_ftsn " Xin Long
2017-12-14 16:41       ` Xin Long
2017-12-14 16:41       ` [PATCHv2 net-next 4/8] sctp: implement report_ftsn " Xin Long
2017-12-14 16:41         ` Xin Long
2017-12-14 16:41         ` [PATCHv2 net-next 5/8] sctp: implement handle_ftsn " Xin Long
2017-12-14 16:41           ` Xin Long
2017-12-14 16:41           ` [PATCHv2 net-next 6/8] sctp: add stream interleave support in stream scheduler Xin Long
2017-12-14 16:41             ` Xin Long
2017-12-14 16:41             ` [PATCHv2 net-next 7/8] sctp: update mid instead of ssn when doing stream and asoc reset Xin Long
2017-12-14 16:41               ` Xin Long
2017-12-14 16:41               ` [PATCHv2 net-next 8/8] sctp: support sysctl to allow users to use stream interleave Xin Long
2017-12-14 16:41                 ` Xin Long
2017-12-14 18:26                 ` Marcelo Ricardo Leitner
2017-12-14 18:26                   ` Marcelo Ricardo Leitner
2017-12-14 18:26               ` [PATCHv2 net-next 7/8] sctp: update mid instead of ssn when doing stream and asoc reset Marcelo Ricardo Leitner
2017-12-14 18:26                 ` Marcelo Ricardo Leitner
2017-12-14 18:26             ` Marcelo Ricardo Leitner [this message]
2017-12-14 18:26               ` [PATCHv2 net-next 6/8] sctp: add stream interleave support in stream scheduler Marcelo Ricardo Leitner
2017-12-14 18:26           ` [PATCHv2 net-next 5/8] sctp: implement handle_ftsn for sctp_stream_interleave Marcelo Ricardo Leitner
2017-12-14 18:26             ` Marcelo Ricardo Leitner
2017-12-14 18:26         ` [PATCHv2 net-next 4/8] sctp: implement report_ftsn " Marcelo Ricardo Leitner
2017-12-14 18:26           ` Marcelo Ricardo Leitner
2017-12-14 18:26       ` [PATCHv2 net-next 3/8] sctp: implement validate_ftsn " Marcelo Ricardo Leitner
2017-12-14 18:26         ` Marcelo Ricardo Leitner
2017-12-14 18:25     ` [PATCHv2 net-next 2/8] sctp: implement generate_ftsn " Marcelo Ricardo Leitner
2017-12-14 18:25       ` Marcelo Ricardo Leitner
2017-12-14 18:25   ` [PATCHv2 net-next 1/8] sctp: add basic structures and make chunk function for ifwdtsn Marcelo Ricardo Leitner
2017-12-14 18:25     ` Marcelo Ricardo Leitner
2017-12-14 19:58 ` [PATCHv2 net-next 0/8] sctp: Implement Stream Interleave: Interaction with Other SCTP Extensions Neil Horman
2017-12-14 19:58   ` Neil Horman
2017-12-15 18:53 ` David Miller
2017-12-15 18:53   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214182625.GN3532@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.