From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org>
Cc: Jacek Anaszewski
<jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org,
sakari.ailus-X3B1VOXEql0@public.gmane.org,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings
Date: Thu, 14 Dec 2017 23:50:41 +0100 [thread overview]
Message-ID: <20171214225041.GB10957@amd> (raw)
In-Reply-To: <799ae164-701a-87ce-fadf-8278f01c10d6-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
On Wed 2017-12-13 14:49:38, Dan Murphy wrote:
> Pavel and Laurent
>
> On 12/13/2017 02:43 PM, Jacek Anaszewski wrote:
> > Dan,
> >
> > On 12/13/2017 09:41 PM, Dan Murphy wrote:
> >> Jacek
> >>
> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
> >>> Hi Dan,
> >>>
> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
> >>>
> >>
> >> Ack
> >>
> >>> "WARNING: A patch subject line should describe the change not the tool
> >>> that found it"
> >>>
> >>> Preferably I'd see two separate patches.
> >>>
> >>
> >> So you want me to split them up? I have no issue with that.
> >
> > Yeah, it will be easier to come up with concise but meaningful
> > subjects.
> >
>
> When I split these up can I add your Acked-by to each patch or would you prefer to resend your
> Acked-by for each patch?
You can keep the ack...
...and my preference would be for trivial fixes like these to be just
applied. No need to resend 3 versions etc...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings
Date: Thu, 14 Dec 2017 23:50:41 +0100 [thread overview]
Message-ID: <20171214225041.GB10957@amd> (raw)
In-Reply-To: <799ae164-701a-87ce-fadf-8278f01c10d6@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
On Wed 2017-12-13 14:49:38, Dan Murphy wrote:
> Pavel and Laurent
>
> On 12/13/2017 02:43 PM, Jacek Anaszewski wrote:
> > Dan,
> >
> > On 12/13/2017 09:41 PM, Dan Murphy wrote:
> >> Jacek
> >>
> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
> >>> Hi Dan,
> >>>
> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
> >>>
> >>
> >> Ack
> >>
> >>> "WARNING: A patch subject line should describe the change not the tool
> >>> that found it"
> >>>
> >>> Preferably I'd see two separate patches.
> >>>
> >>
> >> So you want me to split them up? I have no issue with that.
> >
> > Yeah, it will be easier to come up with concise but meaningful
> > subjects.
> >
>
> When I split these up can I add your Acked-by to each patch or would you prefer to resend your
> Acked-by for each patch?
You can keep the ack...
...and my preference would be for trivial fixes like these to be just
applied. No need to resend 3 versions etc...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-12-14 22:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 21:50 [PATCH] leds: as3645a: Fix checkpatch warnings Dan Murphy
2017-12-12 21:50 ` Dan Murphy
[not found] ` <20171212215011.30066-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-12 23:35 ` Laurent Pinchart
2017-12-12 23:35 ` Laurent Pinchart
2017-12-13 12:56 ` Pavel Machek
2017-12-13 12:56 ` Pavel Machek
2017-12-13 20:29 ` Jacek Anaszewski
2017-12-13 20:29 ` Jacek Anaszewski
2017-12-13 20:41 ` Dan Murphy
2017-12-13 20:41 ` Dan Murphy
2017-12-13 20:43 ` Jacek Anaszewski
2017-12-13 20:49 ` Dan Murphy
2017-12-13 20:49 ` Dan Murphy
2017-12-13 21:32 ` Laurent Pinchart
[not found] ` <799ae164-701a-87ce-fadf-8278f01c10d6-l0cyMroinI0@public.gmane.org>
2017-12-14 22:50 ` Pavel Machek [this message]
2017-12-14 22:50 ` Pavel Machek
2017-12-14 22:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214225041.GB10957@amd \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmurphy-l0cyMroinI0@public.gmane.org \
--cc=jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.