From: Vinod Koul <vinod.koul@intel.com>
To: Andreas Platschek <andreas.platschek@opentech.at>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, sil2review@lists.osadl.org
Subject: [v3] dmaengine: fsl-edma: disable clks on all error paths
Date: Fri, 15 Dec 2017 09:53:20 +0530 [thread overview]
Message-ID: <20171215042319.GB18649@localhost> (raw)
On Thu, Dec 14, 2017 at 12:50:51PM +0100, Andreas Platschek wrote:
> Previously enabled clks are only disabled if clk_prepare_enable() fails.
> However, there are other error paths were the previously enabled
> clocks are not disabled.
>
> To fix the problem, fsl_disable_clocks() now takes the number of clocks
> that shall be disabled + unprepared. For existing calls were all clocks
> were already successfully prepared + enabled, DMAMUX_NR is passed to
> disable + unprepare all clocks.
>
> In error paths were only some clocks were successfully prepared +
> enabled the loop counter is passed, in order to disable + unprepare
> all successfully prepared + enabled clocks.
Applied, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Andreas Platschek <andreas.platschek@opentech.at>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, sil2review@lists.osadl.org
Subject: Re: [PATCH v3] dmaengine: fsl-edma: disable clks on all error paths
Date: Fri, 15 Dec 2017 09:53:20 +0530 [thread overview]
Message-ID: <20171215042319.GB18649@localhost> (raw)
In-Reply-To: <20171214115051.27915-1-andreas.platschek@opentech.at>
On Thu, Dec 14, 2017 at 12:50:51PM +0100, Andreas Platschek wrote:
> Previously enabled clks are only disabled if clk_prepare_enable() fails.
> However, there are other error paths were the previously enabled
> clocks are not disabled.
>
> To fix the problem, fsl_disable_clocks() now takes the number of clocks
> that shall be disabled + unprepared. For existing calls were all clocks
> were already successfully prepared + enabled, DMAMUX_NR is passed to
> disable + unprepare all clocks.
>
> In error paths were only some clocks were successfully prepared +
> enabled the loop counter is passed, in order to disable + unprepare
> all successfully prepared + enabled clocks.
Applied, thanks
--
~Vinod
next reply other threads:[~2017-12-15 4:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 4:23 Vinod Koul [this message]
2017-12-15 4:23 ` [PATCH v3] dmaengine: fsl-edma: disable clks on all error paths Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2017-12-14 11:50 [v3] " Andreas Platschek
2017-12-14 11:50 ` [PATCH v3] " Andreas Platschek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215042319.GB18649@localhost \
--to=vinod.koul@intel.com \
--cc=andreas.platschek@opentech.at \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sil2review@lists.osadl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.