From: Brian Norris <briannorris@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
bleung@chromium.org, Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
rtc-linux@googlegroups.com,
Stephen Barber <smbarber@chromium.org>
Subject: Re: [PATCH v4 2/2] rtc: cros-ec: add cros-ec-rtc driver.
Date: Fri, 15 Dec 2017 20:57:50 -0800 [thread overview]
Message-ID: <20171216045750.GB52366@google.com> (raw)
In-Reply-To: <20171110215553.20696-3-enric.balletbo@collabora.com>
On Fri, Nov 10, 2017 at 10:55:53PM +0100, Enric Balletbo i Serra wrote:
> From: Stephen Barber <smbarber@chromium.org>
>
> On platforms with a Chrome OS EC, the EC can function as a simple RTC.
> Add a basic driver with this functionality.
>
> Signed-off-by: Stephen Barber <smbarber@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Acked-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/rtc/Kconfig | 10 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-cros-ec.c | 413 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 424 insertions(+)
> create mode 100644 drivers/rtc/rtc-cros-ec.c
This isn't quite super-helpful without the CrOS-EC / MFD additions to
actually create the device, but it's a good start, and I don't see any
problems with it. Any reason this isn't merged? Are the RTC maintainers
intendending to merge this, or should Lee (for the MFD header)? I
thought normally Lee deferred to other subsystem maintainers when the
only "MFD" stuff was a simple header change (such as in patch 1).
Anyway, FWIW:
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
bleung@chromium.org, Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
rtc-linux@googlegroups.com,
Stephen Barber <smbarber@chromium.org>
Subject: [rtc-linux] Re: [PATCH v4 2/2] rtc: cros-ec: add cros-ec-rtc driver.
Date: Fri, 15 Dec 2017 20:57:50 -0800 [thread overview]
Message-ID: <20171216045750.GB52366@google.com> (raw)
In-Reply-To: <20171110215553.20696-3-enric.balletbo@collabora.com>
On Fri, Nov 10, 2017 at 10:55:53PM +0100, Enric Balletbo i Serra wrote:
> From: Stephen Barber <smbarber@chromium.org>
>
> On platforms with a Chrome OS EC, the EC can function as a simple RTC.
> Add a basic driver with this functionality.
>
> Signed-off-by: Stephen Barber <smbarber@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Acked-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/rtc/Kconfig | 10 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-cros-ec.c | 413 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 424 insertions(+)
> create mode 100644 drivers/rtc/rtc-cros-ec.c
This isn't quite super-helpful without the CrOS-EC / MFD additions to
actually create the device, but it's a good start, and I don't see any
problems with it. Any reason this isn't merged? Are the RTC maintainers
intendending to merge this, or should Lee (for the MFD header)? I
thought normally Lee deferred to other subsystem maintainers when the
only "MFD" stuff was a simple header change (such as in patch 1).
Anyway, FWIW:
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-12-16 4:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 21:55 [PATCH v4 0/2] Add support for cros-ec-rtc driver Enric Balletbo i Serra
2017-11-10 21:55 ` [rtc-linux] " Enric Balletbo i Serra
2017-11-10 21:55 ` [PATCH v4 1/2] mfd: cros_ec: Introduce RTC commands and events definitions Enric Balletbo i Serra
2017-11-10 21:55 ` [rtc-linux] " Enric Balletbo i Serra
2017-12-16 4:55 ` Brian Norris
2017-12-16 4:55 ` [rtc-linux] " Brian Norris
2017-12-16 7:36 ` Enric Balletbo Serra
2017-12-18 17:44 ` Brian Norris
2017-12-18 17:44 ` [rtc-linux] " Brian Norris
2017-11-10 21:55 ` [PATCH v4 2/2] rtc: cros-ec: add cros-ec-rtc driver Enric Balletbo i Serra
2017-11-10 21:55 ` [rtc-linux] " Enric Balletbo i Serra
2017-12-16 4:57 ` Brian Norris [this message]
2017-12-16 4:57 ` [rtc-linux] " Brian Norris
2017-12-16 5:01 ` Brian Norris
2017-12-16 5:01 ` [rtc-linux] " Brian Norris
2017-12-12 15:41 ` [PATCH v4 0/2] Add support for " Enric Balletbo Serra
2017-12-12 15:41 ` [rtc-linux] " Enric Balletbo Serra
2017-12-12 16:05 ` Alexandre Belloni
2017-12-12 16:05 ` [rtc-linux] " Alexandre Belloni
2017-12-12 17:05 ` Alexandre Belloni
2017-12-13 7:55 ` Lee Jones
2017-12-13 7:55 ` Lee Jones
2017-12-18 22:07 ` Alexandre Belloni
2017-12-18 22:07 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216045750.GB52366@google.com \
--to=briannorris@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=smbarber@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.