[v7,1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vinod Koul <vinod.koul@intel.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, michal.simek@xilinx.com,
	appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com,
	joabreu@synopsys.com, mike.looijmans@topic.nl,
	kedare06@gmail.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [v7,1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date: Mon, 18 Dec 2017 09:47:11 +0530	[thread overview]
Message-ID: <20171218041711.GN18649@localhost> (raw)

On Thu, Dec 07, 2017 at 10:51:02AM +0530, Kedareswara rao Appana wrote:

> @@ -2029,6 +2006,7 @@ static int xilinx_dma_terminate_all(struct dma_chan *dchan)
>  
>  	/* Remove and free all of the descriptors in the lists */
>  	xilinx_dma_free_descriptors(chan);
> +	chan->idle = true;
>  
>  	if (chan->cyclic) {
>  		reg = dma_ctrl_read(chan, XILINX_DMA_REG_DMACR);
> @@ -2344,6 +2322,12 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
>  	chan->has_sg = xdev->has_sg;
>  	chan->desc_pendingcount = 0x0;
>  	chan->ext_addr = xdev->ext_addr;
> +	/* This variable enusres that descripotrs are not
				      ^^^^^^^^^^

typo

WARNING: multiple messages have this Message-ID (diff)

From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date: Mon, 18 Dec 2017 09:47:11 +0530	[thread overview]
Message-ID: <20171218041711.GN18649@localhost> (raw)
In-Reply-To: <1512624067-13554-2-git-send-email-appanad@xilinx.com>

On Thu, Dec 07, 2017 at 10:51:02AM +0530, Kedareswara rao Appana wrote:

> @@ -2029,6 +2006,7 @@ static int xilinx_dma_terminate_all(struct dma_chan *dchan)
>  
>  	/* Remove and free all of the descriptors in the lists */
>  	xilinx_dma_free_descriptors(chan);
> +	chan->idle = true;
>  
>  	if (chan->cyclic) {
>  		reg = dma_ctrl_read(chan, XILINX_DMA_REG_DMACR);
> @@ -2344,6 +2322,12 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
>  	chan->has_sg = xdev->has_sg;
>  	chan->desc_pendingcount = 0x0;
>  	chan->ext_addr = xdev->ext_addr;
> +	/* This variable enusres that descripotrs are not
				      ^^^^^^^^^^

typo

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)

From: Vinod Koul <vinod.koul@intel.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, michal.simek@xilinx.com,
	appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com,
	joabreu@synopsys.com, mike.looijmans@topic.nl,
	kedare06@gmail.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date: Mon, 18 Dec 2017 09:47:11 +0530	[thread overview]
Message-ID: <20171218041711.GN18649@localhost> (raw)
In-Reply-To: <1512624067-13554-2-git-send-email-appanad@xilinx.com>

On Thu, Dec 07, 2017 at 10:51:02AM +0530, Kedareswara rao Appana wrote:

> @@ -2029,6 +2006,7 @@ static int xilinx_dma_terminate_all(struct dma_chan *dchan)
>  
>  	/* Remove and free all of the descriptors in the lists */
>  	xilinx_dma_free_descriptors(chan);
> +	chan->idle = true;
>  
>  	if (chan->cyclic) {
>  		reg = dma_ctrl_read(chan, XILINX_DMA_REG_DMACR);
> @@ -2344,6 +2322,12 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
>  	chan->has_sg = xdev->has_sg;
>  	chan->desc_pendingcount = 0x0;
>  	chan->ext_addr = xdev->ext_addr;
> +	/* This variable enusres that descripotrs are not
				      ^^^^^^^^^^

typo

-- 
~Vinod

next             reply	other threads:[~2017-12-18  4:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18  4:17 Vinod Koul [this message]
2017-12-18  4:17 ` [PATCH v7 1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor Vinod Koul
2017-12-18  4:17 ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2017-12-18  6:53 [v7,1/6] " Appana Durga Kedareswara Rao
2017-12-18  6:53 ` [PATCH v7 1/6] " Appana Durga Kedareswara Rao
2017-12-18  6:53 ` Appana Durga Kedareswara Rao
2017-12-07  5:21 [v7,6/6] dmaengine: xilinx_dma: Differentiate probe based on the ip type Kedareswara rao Appana
2017-12-07  5:21 ` [PATCH v7 6/6] " Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-07  5:21 [v7,5/6] dmaengine: xilinx_dma: fix style issues from checkpatch Kedareswara rao Appana
2017-12-07  5:21 ` [PATCH v7 5/6] " Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-07  5:21 [v7,4/6] dmaengine: xilinx_dma: Fix kernel doc warnings Kedareswara rao Appana
2017-12-07  5:21 ` [PATCH v7 4/6] " Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-07  5:21 [v7,3/6] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario Kedareswara rao Appana
2017-12-07  5:21 ` [PATCH v7 3/6] " Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-07  5:21 [v7,2/6] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma Kedareswara rao Appana
2017-12-07  5:21 ` [PATCH v7 2/6] " Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-07  5:21 [v7,1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor Kedareswara rao Appana
2017-12-07  5:21 ` [PATCH v7 1/6] " Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-07  5:21 [PATCH v7 0/6] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2017-12-07  5:21 ` Kedareswara rao Appana
2017-12-18  5:19 ` Vinod Koul
2017-12-18  5:19   ` Vinod Koul
2017-12-18  6:50   ` Appana Durga Kedareswara Rao
2017-12-18  6:50     ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171218041711.GN18649@localhost \
    --to=vinod.koul@intel.com \
    --cc=akinobu.mita@gmail.com \
    --cc=appana.durga.rao@xilinx.com \
    --cc=appanad@xilinx.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=joabreu@synopsys.com \
    --cc=kedare06@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=mike.looijmans@topic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.