* [PATCH] ovl: fix overlay: warning prefix
@ 2017-11-22 18:27 Amir Goldstein
2017-12-11 17:52 ` Amir Goldstein
2017-12-18 12:19 ` Amir Goldstein
0 siblings, 2 replies; 9+ messages in thread
From: Amir Goldstein @ 2017-11-22 18:27 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-unionfs
Conform two stray warning messages to the standard overlayfs: prefix.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
fs/overlayfs/dir.c | 3 ++-
fs/overlayfs/readdir.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index 5ec5ee8e0589..0ce535e7519e 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -887,7 +887,8 @@ static int ovl_set_redirect(struct dentry *dentry, bool samedir)
spin_unlock(&dentry->d_lock);
} else {
kfree(redirect);
- pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
+ pr_warn_ratelimited("overlayfs: failed to set redirect (%i)\n",
+ err);
/* Fall back to userspace copy-up */
err = -EXDEV;
}
diff --git a/fs/overlayfs/readdir.c b/fs/overlayfs/readdir.c
index 362561457cdb..7fc142d183e8 100644
--- a/fs/overlayfs/readdir.c
+++ b/fs/overlayfs/readdir.c
@@ -499,7 +499,7 @@ static int ovl_cache_update_ino(struct path *path, struct ovl_cache_entry *p)
return err;
fail:
- pr_warn_ratelimited("overlay: failed to look up (%s) for ino (%i)\n",
+ pr_warn_ratelimited("overlayfs: failed to look up (%s) for ino (%i)\n",
p->name, err);
goto out;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ovl: fix overlay: warning prefix
2017-11-22 18:27 [PATCH] ovl: fix overlay: warning prefix Amir Goldstein
@ 2017-12-11 17:52 ` Amir Goldstein
2017-12-14 10:19 ` Miklos Szeredi
2017-12-18 12:19 ` Amir Goldstein
1 sibling, 1 reply; 9+ messages in thread
From: Amir Goldstein @ 2017-12-11 17:52 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: overlayfs
On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> Conform two stray warning messages to the standard overlayfs: prefix.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/overlayfs/dir.c | 3 ++-
> fs/overlayfs/readdir.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
> index 5ec5ee8e0589..0ce535e7519e 100644
> --- a/fs/overlayfs/dir.c
> +++ b/fs/overlayfs/dir.c
> @@ -887,7 +887,8 @@ static int ovl_set_redirect(struct dentry *dentry, bool samedir)
> spin_unlock(&dentry->d_lock);
> } else {
> kfree(redirect);
> - pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
> + pr_warn_ratelimited("overlayfs: failed to set redirect (%i)\n",
> + err);
> /* Fall back to userspace copy-up */
> err = -EXDEV;
> }
> diff --git a/fs/overlayfs/readdir.c b/fs/overlayfs/readdir.c
> index 362561457cdb..7fc142d183e8 100644
> --- a/fs/overlayfs/readdir.c
> +++ b/fs/overlayfs/readdir.c
> @@ -499,7 +499,7 @@ static int ovl_cache_update_ino(struct path *path, struct ovl_cache_entry *p)
> return err;
>
> fail:
> - pr_warn_ratelimited("overlay: failed to look up (%s) for ino (%i)\n",
> + pr_warn_ratelimited("overlayfs: failed to look up (%s) for ino (%i)\n",
> p->name, err);
> goto out;
> }
> --
Ping
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ovl: fix overlay: warning prefix
2017-12-11 17:52 ` Amir Goldstein
@ 2017-12-14 10:19 ` Miklos Szeredi
0 siblings, 0 replies; 9+ messages in thread
From: Miklos Szeredi @ 2017-12-14 10:19 UTC (permalink / raw)
To: Amir Goldstein; +Cc: overlayfs
On Mon, Dec 11, 2017 at 6:52 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
>> Conform two stray warning messages to the standard overlayfs: prefix.
>>
>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>> ---
>> fs/overlayfs/dir.c | 3 ++-
>> fs/overlayfs/readdir.c | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
>> index 5ec5ee8e0589..0ce535e7519e 100644
>> --- a/fs/overlayfs/dir.c
>> +++ b/fs/overlayfs/dir.c
>> @@ -887,7 +887,8 @@ static int ovl_set_redirect(struct dentry *dentry, bool samedir)
>> spin_unlock(&dentry->d_lock);
>> } else {
>> kfree(redirect);
>> - pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
>> + pr_warn_ratelimited("overlayfs: failed to set redirect (%i)\n",
>> + err);
>> /* Fall back to userspace copy-up */
>> err = -EXDEV;
>> }
>> diff --git a/fs/overlayfs/readdir.c b/fs/overlayfs/readdir.c
>> index 362561457cdb..7fc142d183e8 100644
>> --- a/fs/overlayfs/readdir.c
>> +++ b/fs/overlayfs/readdir.c
>> @@ -499,7 +499,7 @@ static int ovl_cache_update_ino(struct path *path, struct ovl_cache_entry *p)
>> return err;
>>
>> fail:
>> - pr_warn_ratelimited("overlay: failed to look up (%s) for ino (%i)\n",
>> + pr_warn_ratelimited("overlayfs: failed to look up (%s) for ino (%i)\n",
>> p->name, err);
>> goto out;
>> }
>> --
>
> Ping
Applied, thanks.
Anything else I missed that need to be sent to 4.15-rc?
Thanks,
Miklos
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ovl: fix overlay: warning prefix
2017-11-22 18:27 [PATCH] ovl: fix overlay: warning prefix Amir Goldstein
2017-12-11 17:52 ` Amir Goldstein
@ 2017-12-18 12:19 ` Amir Goldstein
2017-12-18 12:35 ` Greg KH
1 sibling, 1 reply; 9+ messages in thread
From: Amir Goldstein @ 2017-12-18 12:19 UTC (permalink / raw)
To: Greg KH; +Cc: overlayfs, Miklos Szeredi, stable
On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> Conform two stray warning messages to the standard overlayfs: prefix.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
Greg,
Upstream commit ("da2e6b7eeda8 ovl: fix overlay: warning prefix")
was not marked for stable, because it is not a bug fix per-se.
Nevertheless, it may be useful to apply it to stable kernels to keep
overlayfs bug reports/analysis consistent.
The first hunk fixes (#v4.10):
a6c606551141 ovl: redirect on rename-dir
The second hunk fixes (#v4.14):
b5efccbe0a12 ovl: constant d_ino across copy up
For your consideration.
If you wish, I can send a patch for v4.10 with just the first hunk.
Thanks,
Amir.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ovl: fix overlay: warning prefix
2017-12-18 12:19 ` Amir Goldstein
@ 2017-12-18 12:35 ` Greg KH
2017-12-18 12:43 ` Amir Goldstein
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2017-12-18 12:35 UTC (permalink / raw)
To: Amir Goldstein; +Cc: overlayfs, Miklos Szeredi, stable
On Mon, Dec 18, 2017 at 02:19:52PM +0200, Amir Goldstein wrote:
> On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> > Conform two stray warning messages to the standard overlayfs: prefix.
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > ---
>
> Greg,
>
> Upstream commit ("da2e6b7eeda8 ovl: fix overlay: warning prefix")
> was not marked for stable, because it is not a bug fix per-se.
> Nevertheless, it may be useful to apply it to stable kernels to keep
> overlayfs bug reports/analysis consistent.
>
> The first hunk fixes (#v4.10):
> a6c606551141 ovl: redirect on rename-dir
>
> The second hunk fixes (#v4.14):
> b5efccbe0a12 ovl: constant d_ino across copy up
>
> For your consideration.
> If you wish, I can send a patch for v4.10 with just the first hunk.
4.10 is long end-of-life, so I don't think that matters :)
As for 4.14, this is just an error message, I don't think it's that
serious of a fix for a stable kernel, do you? It's _this_ close to just
being a spelling fix.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ovl: fix overlay: warning prefix
2017-12-18 12:35 ` Greg KH
@ 2017-12-18 12:43 ` Amir Goldstein
0 siblings, 0 replies; 9+ messages in thread
From: Amir Goldstein @ 2017-12-18 12:43 UTC (permalink / raw)
To: Greg KH; +Cc: overlayfs, Miklos Szeredi, stable
On Mon, Dec 18, 2017 at 2:35 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Dec 18, 2017 at 02:19:52PM +0200, Amir Goldstein wrote:
>> On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
>> > Conform two stray warning messages to the standard overlayfs: prefix.
>> >
>> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>> > ---
>>
>> Greg,
>>
>> Upstream commit ("da2e6b7eeda8 ovl: fix overlay: warning prefix")
>> was not marked for stable, because it is not a bug fix per-se.
>> Nevertheless, it may be useful to apply it to stable kernels to keep
>> overlayfs bug reports/analysis consistent.
>>
>> The first hunk fixes (#v4.10):
>> a6c606551141 ovl: redirect on rename-dir
>>
>> The second hunk fixes (#v4.14):
>> b5efccbe0a12 ovl: constant d_ino across copy up
>>
>> For your consideration.
>> If you wish, I can send a patch for v4.10 with just the first hunk.
>
>
> 4.10 is long end-of-life, so I don't think that matters :)
Yeh, I thought 4.13 was still around, but it's not...
>
> As for 4.14, this is just an error message, I don't think it's that
> serious of a fix for a stable kernel, do you? It's _this_ close to just
> being a spelling fix.
>
Not serious at all.
It's just that collecting overlayfs output from kmsg on bug reports
is one notch easier to request.
I can certainly live without it being in a stable.
Thanks,
Amir.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ovl: fix overlay: warning prefix
@ 2018-01-10 9:17 Chengguang Xu
2018-01-10 11:45 ` Amir Goldstein
0 siblings, 1 reply; 9+ messages in thread
From: Chengguang Xu @ 2018-01-10 9:17 UTC (permalink / raw)
To: miklos; +Cc: linux-unionfs, Chengguang Xu
Conform one stray warning message to the standard overlayfs: prefix.
Signed-off-by: Chengguang Xu <cgxu519@icloud.com>
---
fs/overlayfs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
index beb945e..d0a801b 100644
--- a/fs/overlayfs/namei.c
+++ b/fs/overlayfs/namei.c
@@ -693,7 +693,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
*/
err = -EPERM;
if (d.redirect && !ofs->config.redirect_follow) {
- pr_warn_ratelimited("overlay: refusing to follow redirect for (%pd2)\n", dentry);
+ pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n", dentry);
goto out_put;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ovl: fix overlay: warning prefix
2018-01-10 9:17 Chengguang Xu
@ 2018-01-10 11:45 ` Amir Goldstein
2018-01-10 11:59 ` Chengguang Xu
0 siblings, 1 reply; 9+ messages in thread
From: Amir Goldstein @ 2018-01-10 11:45 UTC (permalink / raw)
To: Chengguang Xu; +Cc: Miklos Szeredi, overlayfs
On Wed, Jan 10, 2018 at 11:17 AM, Chengguang Xu <cgxu519@icloud.com> wrote:
> Conform one stray warning message to the standard overlayfs: prefix.
>
> Signed-off-by: Chengguang Xu <cgxu519@icloud.com>
> ---
> fs/overlayfs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
> index beb945e..d0a801b 100644
> --- a/fs/overlayfs/namei.c
> +++ b/fs/overlayfs/namei.c
> @@ -693,7 +693,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
> */
> err = -EPERM;
> if (d.redirect && !ofs->config.redirect_follow) {
> - pr_warn_ratelimited("overlay: refusing to follow redirect for (%pd2)\n", dentry);
> + pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n", dentry);
> goto out_put;
> }
>
> --
I already posted this fix, but as long as the fix gets merged...
Thanks,
Amir.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ovl: fix overlay: warning prefix
2018-01-10 11:45 ` Amir Goldstein
@ 2018-01-10 11:59 ` Chengguang Xu
0 siblings, 0 replies; 9+ messages in thread
From: Chengguang Xu @ 2018-01-10 11:59 UTC (permalink / raw)
To: Amir Goldstein; +Cc: Miklos Szeredi, overlayfs
>
> 在 2018年1月10日，下午7:45，Amir Goldstein <amir73il@gmail.com> 写道：
>
> On Wed, Jan 10, 2018 at 11:17 AM, Chengguang Xu <cgxu519@icloud.com> wrote:
>> Conform one stray warning message to the standard overlayfs: prefix.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@icloud.com>
>> ---
>> fs/overlayfs/namei.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
>> index beb945e..d0a801b 100644
>> --- a/fs/overlayfs/namei.c
>> +++ b/fs/overlayfs/namei.c
>> @@ -693,7 +693,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
>> */
>> err = -EPERM;
>> if (d.redirect && !ofs->config.redirect_follow) {
>> - pr_warn_ratelimited("overlay: refusing to follow redirect for (%pd2)\n", dentry);
>> + pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n", dentry);
>> goto out_put;
>> }
>>
>> --
>
>
> I already posted this fix, but as long as the fix gets merged…
Sorry, I didn’t check very closely，please apply in your patch.
Thanks,
Chengguang.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-10 12:00 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-22 18:27 [PATCH] ovl: fix overlay: warning prefix Amir Goldstein
2017-12-11 17:52 ` Amir Goldstein
2017-12-14 10:19 ` Miklos Szeredi
2017-12-18 12:19 ` Amir Goldstein
2017-12-18 12:35 ` Greg KH
2017-12-18 12:43 ` Amir Goldstein
-- strict thread matches above, loose matches on Subject: below --
2018-01-10 9:17 Chengguang Xu
2018-01-10 11:45 ` Amir Goldstein
2018-01-10 11:59 ` Chengguang Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.