All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dave Young <dyoung@redhat.com>,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	ard.biesheuvel@linaro.org
Subject: Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap
Date: Mon, 18 Dec 2017 13:11:19 +0000	[thread overview]
Message-ID: <20171218131119.GA3891@codeblueprint.co.uk> (raw)
In-Reply-To: <20171216140632.462yk7pmlvpmz6if@gmail.com>

On Sat, 16 Dec, at 03:06:32PM, Ingo Molnar wrote:
> 
> * Matt Fleming <matt@codeblueprint.co.uk> wrote:
> 
> > >  	x86_init.oem.arch_setup();
> > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p)
> > >  
> > >  	parse_early_param();
> > >  
> > > +	if (efi_enabled(EFI_BOOT))
> > > +		efi_memblock_x86_reserve_range();
> > >  #ifdef CONFIG_MEMORY_HOTPLUG
> > >  	/*
> > >  	 * Memory used by the kernel cannot be hot-removed because Linux
> > > 
> > 
> > I prefer this version. Please re-send a full patch and update the
> > subject line to include the "fix" somewhere; it wasn't obvious to me
> > from the start that this is a bug fix.
> 
> Agreed.
> 
> I dropped the commit I just applied to tip:efi/core, since you are handling this, 
> so this patch should come through the regular EFI channels, right?

Yep, that's right. Me or Ard will take care of it.

  reply	other threads:[~2017-12-18 13:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  5:23 [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap Dave Young
2017-11-30  5:23 ` Dave Young
     [not found] ` <20171130052327.GA3500-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-14 10:41   ` Dave Young
2017-12-14 10:41     ` Dave Young
2017-12-15 15:18     ` Matt Fleming
     [not found]       ` <20171215151822.GB3204-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2017-12-16 14:06         ` Ingo Molnar
2017-12-16 14:06           ` Ingo Molnar
2017-12-18 13:11           ` Matt Fleming [this message]
     [not found]     ` <20171214104119.GA2437-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-16 14:03       ` Ingo Molnar
2017-12-16 14:03         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171218131119.GA3891@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dyoung@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.