All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org
Subject: Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap
Date: Sat, 16 Dec 2017 15:03:26 +0100	[thread overview]
Message-ID: <20171216140326.sbel3qfe4fbhaybl@gmail.com> (raw)
In-Reply-To: <20171214104119.GA2437-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>


* Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:

> Another way is move "efi_memblock_x86_reserve_range" to later code
> Maybe below is better?

Yeah, that's much lower risk, if the affected EFI code does not mind being called 
later. We had trouble from trying to move early param parsing wholesale.

I've applied your v2 patch tip:efi/core.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk
Subject: Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap
Date: Sat, 16 Dec 2017 15:03:26 +0100	[thread overview]
Message-ID: <20171216140326.sbel3qfe4fbhaybl@gmail.com> (raw)
In-Reply-To: <20171214104119.GA2437@dhcp-128-65.nay.redhat.com>


* Dave Young <dyoung@redhat.com> wrote:

> Another way is move "efi_memblock_x86_reserve_range" to later code
> Maybe below is better?

Yeah, that's much lower risk, if the affected EFI code does not mind being called 
later. We had trouble from trying to move early param parsing wholesale.

I've applied your v2 patch tip:efi/core.

Thanks,

	Ingo

  parent reply	other threads:[~2017-12-16 14:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  5:23 [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap Dave Young
2017-11-30  5:23 ` Dave Young
     [not found] ` <20171130052327.GA3500-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-14 10:41   ` Dave Young
2017-12-14 10:41     ` Dave Young
2017-12-15 15:18     ` Matt Fleming
     [not found]       ` <20171215151822.GB3204-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2017-12-16 14:06         ` Ingo Molnar
2017-12-16 14:06           ` Ingo Molnar
2017-12-18 13:11           ` Matt Fleming
     [not found]     ` <20171214104119.GA2437-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-16 14:03       ` Ingo Molnar [this message]
2017-12-16 14:03         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171216140326.sbel3qfe4fbhaybl@gmail.com \
    --to=mingo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.