All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-nvdimm@lists.01.org
Subject: Re: [PATCH] acpi: add NFIT and HMAT to the initrd override list
Date: Mon, 18 Dec 2017 12:54:05 -0700	[thread overview]
Message-ID: <20171218195405.GA18900@linux.intel.com> (raw)
In-Reply-To: <151275056532.8020.17160155121603376532.stgit@dwillia2-desk3.amr.corp.intel.com>

On Fri, Dec 08, 2017 at 08:29:25AM -0800, Dan Williams wrote:
> These tables, NFIT and HMAT, are essential for describing
> next-generation platform memory topologies and performance
> characteristics. Allow them to be overridden for debug and test and
> purposes.
> 
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>

Yes please!  This works in my test setup for inserting custom HMAT tables, and
I would really like to have this for testing my HMAT series:

https://lists.01.org/pipermail/linux-nvdimm/2017-December/013571.html

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/acpi/tables.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 80ce2a7d224b..67a44fd79449 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -456,7 +456,8 @@ static const char * const table_sigs[] = {
>  	ACPI_SIG_SLIC, ACPI_SIG_SPCR, ACPI_SIG_SPMI, ACPI_SIG_TCPA,
>  	ACPI_SIG_UEFI, ACPI_SIG_WAET, ACPI_SIG_WDAT, ACPI_SIG_WDDT,
>  	ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT,
> -	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, NULL };
> +	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_NFIT,
> +	ACPI_SIG_HMAT, NULL };
>  
>  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-acpi@vger.kernel.org, rafael.j.wysocki@intel.com,
	linux-nvdimm@lists.01.org
Subject: Re: [PATCH] acpi: add NFIT and HMAT to the initrd override list
Date: Mon, 18 Dec 2017 12:54:05 -0700	[thread overview]
Message-ID: <20171218195405.GA18900@linux.intel.com> (raw)
In-Reply-To: <151275056532.8020.17160155121603376532.stgit@dwillia2-desk3.amr.corp.intel.com>

On Fri, Dec 08, 2017 at 08:29:25AM -0800, Dan Williams wrote:
> These tables, NFIT and HMAT, are essential for describing
> next-generation platform memory topologies and performance
> characteristics. Allow them to be overridden for debug and test and
> purposes.
> 
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>

Yes please!  This works in my test setup for inserting custom HMAT tables, and
I would really like to have this for testing my HMAT series:

https://lists.01.org/pipermail/linux-nvdimm/2017-December/013571.html

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/acpi/tables.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 80ce2a7d224b..67a44fd79449 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -456,7 +456,8 @@ static const char * const table_sigs[] = {
>  	ACPI_SIG_SLIC, ACPI_SIG_SPCR, ACPI_SIG_SPMI, ACPI_SIG_TCPA,
>  	ACPI_SIG_UEFI, ACPI_SIG_WAET, ACPI_SIG_WDAT, ACPI_SIG_WDDT,
>  	ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT,
> -	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, NULL };
> +	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_NFIT,
> +	ACPI_SIG_HMAT, NULL };
>  
>  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>  
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2017-12-18 19:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 16:29 [PATCH] acpi: add NFIT and HMAT to the initrd override list Dan Williams
2017-12-08 16:29 ` Dan Williams
2017-12-18 19:54 ` Ross Zwisler [this message]
2017-12-18 19:54   ` Ross Zwisler
     [not found]   ` <20171218195405.GA18900-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-02-22 21:12     ` Ross Zwisler
2018-02-22 21:12       ` Ross Zwisler
     [not found]       ` <20180222211224.GA29462-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-02-22 21:47         ` Rafael J. Wysocki
2018-02-22 21:47           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171218195405.GA18900@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.