From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: kyungmin.park@samsung.com, dwmw2@infradead.org,
computersforpeace@gmail.com, marek.vasut@gmail.com,
richard@nod.at, cyrille.pitchen@wedev4u.fr,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/4 v3] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths
Date: Mon, 18 Dec 2017 20:03:32 +0000 [thread overview]
Message-ID: <20171218210332.4fd91ec3@bbrezillon> (raw)
In-Reply-To: <cover.1513230484.git.christophe.jaillet@wanadoo.fr>
On Thu, 14 Dec 2017 07:03:48 +0100
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> The first patch converts 's3c_onenand_probe()' to devm_ functions.
> This fixes a leak in one path (line 872).
> This also free_irq which was not handled at all. ( I hope I'm correct :) )
>
> The 2nd patch is about an un-handled error code which looks spurious.
> Not sure if I'm right.
>
> The 3rd patch propagates an error code instead of returning a hard-coded
> value.
>
> The last one removes a useless include spotted while compile-testing.
>
>
> v3: patch 1/4 updated to fix a bug introduced in v2
> patch 2/4 unchanged
> patch 3/4 and 4/4 added
> now the patch are cross-compile tested :)
>
> Theses patches have been cross compile-tested-only.
Applied the whole series.
Thanks,
Boris
>
> Christophe JAILLET (4):
> mtd: onenand: samsung: use devm_ function to simplify
> code and fix some leaks
> mtd: onenand: samsung: return an error if
> 'mtd_device_parse_register()' fails
> mtd: onenand: samsung: Propagate the error returned
> by 'onenand_scan()'
> mtd: onenand: samsung: Remove a useless include
>
> drivers/mtd/onenand/samsung.c | 172 +++++++++---------------------------------
> 1 file changed, 35 insertions(+), 137 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: kyungmin.park@samsung.com, dwmw2@infradead.org,
computersforpeace@gmail.com, marek.vasut@gmail.com,
richard@nod.at, cyrille.pitchen@wedev4u.fr,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/4 v3] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths
Date: Mon, 18 Dec 2017 21:03:32 +0100 [thread overview]
Message-ID: <20171218210332.4fd91ec3@bbrezillon> (raw)
In-Reply-To: <cover.1513230484.git.christophe.jaillet@wanadoo.fr>
On Thu, 14 Dec 2017 07:03:48 +0100
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> The first patch converts 's3c_onenand_probe()' to devm_ functions.
> This fixes a leak in one path (line 872).
> This also free_irq which was not handled at all. ( I hope I'm correct :) )
>
> The 2nd patch is about an un-handled error code which looks spurious.
> Not sure if I'm right.
>
> The 3rd patch propagates an error code instead of returning a hard-coded
> value.
>
> The last one removes a useless include spotted while compile-testing.
>
>
> v3: patch 1/4 updated to fix a bug introduced in v2
> patch 2/4 unchanged
> patch 3/4 and 4/4 added
> now the patch are cross-compile tested :)
>
> Theses patches have been cross compile-tested-only.
Applied the whole series.
Thanks,
Boris
>
> Christophe JAILLET (4):
> mtd: onenand: samsung: use devm_ function to simplify
> code and fix some leaks
> mtd: onenand: samsung: return an error if
> 'mtd_device_parse_register()' fails
> mtd: onenand: samsung: Propagate the error returned
> by 'onenand_scan()'
> mtd: onenand: samsung: Remove a useless include
>
> drivers/mtd/onenand/samsung.c | 172 +++++++++---------------------------------
> 1 file changed, 35 insertions(+), 137 deletions(-)
>
next prev parent reply other threads:[~2017-12-18 20:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 6:03 [PATCH 0/4 v3] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths Christophe JAILLET
2017-12-14 6:03 ` Christophe JAILLET
2017-12-14 6:03 ` [PATCH 1/4 v3] mtd: onenand: samsung: use devm_ function to simplify code and fix some leaks Christophe JAILLET
2017-12-14 6:03 ` Christophe JAILLET
2017-12-18 20:03 ` Boris Brezillon
2017-12-18 20:03 ` Boris Brezillon
2017-12-14 6:03 ` [PATCH 2/4 v3] mtd: onenand: samsung: return an error if 'mtd_device_parse_register()' fails Christophe JAILLET
2017-12-14 6:03 ` Christophe JAILLET
2017-12-14 6:03 ` Christophe JAILLET
2017-12-14 6:03 ` [PATCH 3/4 v3] mtd: onenand: samsung: Propagate the error returned by 'onenand_scan()' Christophe JAILLET
2017-12-14 6:03 ` Christophe JAILLET
2017-12-14 6:03 ` [PATCH 3/4 v3] mtd: onenand: samsung: Remove a useless include Christophe JAILLET
2017-12-14 6:03 ` Christophe JAILLET
2017-12-18 19:58 ` Boris Brezillon
2017-12-18 19:58 ` Boris Brezillon
2017-12-18 20:03 ` Boris Brezillon [this message]
2017-12-18 20:03 ` [PATCH 0/4 v3] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218210332.4fd91ec3@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.