All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kernel-hardening@lists.openwall.com,
	Tycho Andersen <tycho@tycho.ws>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Alexei Starovoitov <ast@kernel.org>,
	linux-kernel@vger.kernel.org,
	Network Development <netdev@vger.kernel.org>
Subject: [kernel-hardening] Re: [PATCH 3/3] trace: print address if symbol not found
Date: Tue, 19 Dec 2017 15:20:09 +1100	[thread overview]
Message-ID: <20171219042009.GK19604@eros> (raw)
In-Reply-To: <20171218223738.49e563c0@vmware.local.home>

On Mon, Dec 18, 2017 at 10:37:38PM -0500, Steven Rostedt wrote:
> On Tue, 19 Dec 2017 14:00:11 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
> 
> > I ran through these as outlined here for the new version (v4). This hits
> > the modified code but doesn't test symbol look up failure.
> 
> stacktrace shouldn't post non kernel values, unless there's a frame
> pointer that isn't handled by kallsyms.
> 
> As for the other two, we could probably force a failure, like:
> 
>  # echo 'hist:keys=hrtimer.sym' > \
>      events/timer/hrtimer_start/trigger
>  # cat events/timer/hrtimer_start/hist
> 
> And then just add sym-offset too.
>
> > I also configured kernel with 'Perform a startup test on ftrace' for
> > good luck.
> > 
> > Are you happy with this level of testing?
> 
> Can you try the above.

Did both and in both cases we get the addresses as hoped :)

thanks,
Tobin.

WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kernel-hardening@lists.openwall.com,
	Tycho Andersen <tycho@tycho.ws>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Alexei Starovoitov <ast@kernel.org>,
	linux-kernel@vger.kernel.org,
	Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] trace: print address if symbol not found
Date: Tue, 19 Dec 2017 15:20:09 +1100	[thread overview]
Message-ID: <20171219042009.GK19604@eros> (raw)
In-Reply-To: <20171218223738.49e563c0@vmware.local.home>

On Mon, Dec 18, 2017 at 10:37:38PM -0500, Steven Rostedt wrote:
> On Tue, 19 Dec 2017 14:00:11 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
> 
> > I ran through these as outlined here for the new version (v4). This hits
> > the modified code but doesn't test symbol look up failure.
> 
> stacktrace shouldn't post non kernel values, unless there's a frame
> pointer that isn't handled by kallsyms.
> 
> As for the other two, we could probably force a failure, like:
> 
>  # echo 'hist:keys=hrtimer.sym' > \
>      events/timer/hrtimer_start/trigger
>  # cat events/timer/hrtimer_start/hist
> 
> And then just add sym-offset too.
>
> > I also configured kernel with 'Perform a startup test on ftrace' for
> > good luck.
> > 
> > Are you happy with this level of testing?
> 
> Can you try the above.

Did both and in both cases we get the addresses as hoped :)

thanks,
Tobin.

  reply	other threads:[~2017-12-19  4:20 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-17 23:53 [kernel-hardening] [PATCH 0/3] kallsyms: don't leak address Tobin C. Harding
2017-12-17 23:53 ` Tobin C. Harding
2017-12-17 23:53 ` [kernel-hardening] [PATCH 1/3] kallsyms: don't leak address when symbol not found Tobin C. Harding
2017-12-17 23:53   ` Tobin C. Harding
2017-12-18  9:55   ` [kernel-hardening] " Felix Fietkau
2017-12-18  9:55     ` Felix Fietkau
2017-12-18 22:41     ` [kernel-hardening] " Tobin C. Harding
2017-12-18 22:41       ` Tobin C. Harding
2017-12-18 23:43       ` [kernel-hardening] " Steven Rostedt
2017-12-18 23:43         ` Steven Rostedt
2017-12-19  0:24         ` [kernel-hardening] " Tobin C. Harding
2017-12-19  0:24           ` Tobin C. Harding
2017-12-17 23:53 ` [kernel-hardening] [PATCH 2/3] vsprintf: print <no-symbol> if " Tobin C. Harding
2017-12-17 23:53   ` Tobin C. Harding
2017-12-18  0:04   ` [kernel-hardening] " Joe Perches
2017-12-18  0:04     ` Joe Perches
2017-12-18  1:04     ` [kernel-hardening] " Tobin C. Harding
2017-12-18  1:04       ` Tobin C. Harding
2017-12-17 23:53 ` [kernel-hardening] [PATCH 3/3] trace: print address " Tobin C. Harding
2017-12-17 23:53   ` Tobin C. Harding
2017-12-18 16:49   ` [kernel-hardening] " Steven Rostedt
2017-12-18 16:49     ` Steven Rostedt
2017-12-18 21:16     ` [kernel-hardening] " Tobin C. Harding
2017-12-18 21:16       ` Tobin C. Harding
2017-12-18 23:51       ` [kernel-hardening] " Steven Rostedt
2017-12-18 23:51         ` Steven Rostedt
2017-12-19  0:22         ` [kernel-hardening] " Tobin C. Harding
2017-12-19  0:22           ` Tobin C. Harding
2017-12-19  3:00         ` [kernel-hardening] " Tobin C. Harding
2017-12-19  3:00           ` Tobin C. Harding
2017-12-19  3:02           ` [kernel-hardening] " Tobin C. Harding
2017-12-19  3:02             ` Tobin C. Harding
2017-12-19  3:37           ` [kernel-hardening] " Steven Rostedt
2017-12-19  3:37             ` Steven Rostedt
2017-12-19  4:20             ` Tobin C. Harding [this message]
2017-12-19  4:20               ` Tobin C. Harding
2017-12-18 22:35     ` [kernel-hardening] " Tobin C. Harding
2017-12-18 22:35       ` Tobin C. Harding
2017-12-19 23:19   ` [kernel-hardening] " kbuild test robot
2017-12-19 23:19     ` kbuild test robot
2017-12-19 23:39   ` [kernel-hardening] " kbuild test robot
2017-12-19 23:39     ` kbuild test robot
2017-12-18  5:31 ` [kernel-hardening] [PATCH 0/3] kallsyms: don't leak address Michael Ellerman
2017-12-18  5:31   ` Michael Ellerman
2017-12-18  6:00   ` Tobin C. Harding
2017-12-18  9:17     ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219042009.GK19604@eros \
    --to=me@tobin.cc \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tycho@tycho.ws \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.