All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/15] drm/sun4i: Fix error path handling
Date: Tue, 19 Dec 2017 09:59:50 +0100	[thread overview]
Message-ID: <20171219085950.domvcod2dyqdi3v3@flea.lan> (raw)
In-Reply-To: <f83c1cebc731f0b4251f5ddd7b38c718cd79bb0b.1512662253.git-series.maxime.ripard@free-electrons.com>

On Thu, Dec 07, 2017 at 04:58:50PM +0100, Maxime Ripard wrote:
> The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap
> initialization sequence") moved a bunch of logic around, but forgot to
> update the gotos after the introduction of the err_free_dotclock label.
> 
> It means that if we fail later that the one introduced in that commit,
> we'll just to the old label which isn't free the clock we created. This
> will result in a breakage as soon as someone tries to do something with
> that clock, since its resources will have been long reclaimed.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied this one as a fix.
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171219/b463c0c3/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	jernej.skrabec@siol.net, plaes@plaes.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	thierry.reding@gmail.com, stable@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, icenowy@aosc.io
Subject: Re: [PATCH v4 05/15] drm/sun4i: Fix error path handling
Date: Tue, 19 Dec 2017 09:59:50 +0100	[thread overview]
Message-ID: <20171219085950.domvcod2dyqdi3v3@flea.lan> (raw)
In-Reply-To: <f83c1cebc731f0b4251f5ddd7b38c718cd79bb0b.1512662253.git-series.maxime.ripard@free-electrons.com>


[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]

On Thu, Dec 07, 2017 at 04:58:50PM +0100, Maxime Ripard wrote:
> The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap
> initialization sequence") moved a bunch of logic around, but forgot to
> update the gotos after the introduction of the err_free_dotclock label.
> 
> It means that if we fail later that the one introduced in that commit,
> we'll just to the old label which isn't free the clock we created. This
> will result in a breakage as soon as someone tries to do something with
> that clock, since its resources will have been long reclaimed.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied this one as a fix.
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, plaes@plaes.org,
	icenowy@aosc.io,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	jernej.skrabec@siol.net, devicetree@vger.kernel.org,
	thierry.reding@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH v4 05/15] drm/sun4i: Fix error path handling
Date: Tue, 19 Dec 2017 09:59:50 +0100	[thread overview]
Message-ID: <20171219085950.domvcod2dyqdi3v3@flea.lan> (raw)
In-Reply-To: <f83c1cebc731f0b4251f5ddd7b38c718cd79bb0b.1512662253.git-series.maxime.ripard@free-electrons.com>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

On Thu, Dec 07, 2017 at 04:58:50PM +0100, Maxime Ripard wrote:
> The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap
> initialization sequence") moved a bunch of logic around, but forgot to
> update the gotos after the introduction of the err_free_dotclock label.
> 
> It means that if we fail later that the one introduced in that commit,
> we'll just to the old label which isn't free the clock we created. This
> will result in a breakage as soon as someone tries to do something with
> that clock, since its resources will have been long reclaimed.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied this one as a fix.
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-12-19  8:59 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 15:58 [PATCH v4 00/15] drm/sun4i: Add A83t LVDS support Maxime Ripard
2017-12-07 15:58 ` Maxime Ripard
2017-12-07 15:58 ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 01/15] dt-bindings: panel: lvds: Document power-supply property Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 02/15] drm/panel: lvds: Add support for the " Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 03/15] dt-bindings: display: sun4i-drm: Add LVDS properties Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-14  3:22   ` Chen-Yu Tsai
2017-12-14  3:22     ` Chen-Yu Tsai
2017-12-14  3:22     ` Chen-Yu Tsai
2017-12-07 15:58 ` [PATCH v4 04/15] dt-bindings: display: sun4i-drm: Add A83T pipeline Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 05/15] drm/sun4i: Fix error path handling Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-19  8:59   ` Maxime Ripard [this message]
2017-12-19  8:59     ` Maxime Ripard
2017-12-19  8:59     ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 06/15] drm/sun4i: Force the mixer rate at 150MHz Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-14  3:28   ` Chen-Yu Tsai
2017-12-14  3:28     ` Chen-Yu Tsai
2017-12-14  3:28     ` Chen-Yu Tsai
2017-12-07 15:58 ` [PATCH v4 07/15] drm/sun4i: Create minimal multipliers and dividers Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 08/15] drm/sun4i: Add LVDS support Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-14  3:42   ` Chen-Yu Tsai
2017-12-14  3:42     ` Chen-Yu Tsai
2017-12-14  3:42     ` Chen-Yu Tsai
2017-12-07 15:58 ` [PATCH v4 09/15] drm/sun4i: Add A83T support Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 10/15] ARM: dts: sun8i: a83t: Add display pipeline Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 11/15] ARM: dts: sun8i: a83t: Enable the PWM Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 12/15] ARM: dts: sun8i: a83t: Add LVDS pins group Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58 ` [PATCH v4 13/15] ARM: dts: sun8i: a83t: Add the PWM pin group Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-14  3:44   ` Chen-Yu Tsai
2017-12-14  3:44     ` Chen-Yu Tsai
2017-12-14  3:44     ` Chen-Yu Tsai
2017-12-07 15:58 ` [PATCH v4 14/15] ARM: dts: sun8i: a711: Reinstate the PMIC compatible Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-07 15:58   ` Maxime Ripard
2017-12-19  8:57   ` Maxime Ripard
2017-12-19  8:57     ` Maxime Ripard
2017-12-19  8:57     ` Maxime Ripard
2017-12-07 15:59 ` [PATCH v4 15/15] ARM: dts: sun8i: a711: Enable the LCD Maxime Ripard
2017-12-07 15:59   ` Maxime Ripard
2017-12-07 15:59   ` Maxime Ripard
2017-12-14  7:01 ` [PATCH v4 00/15] drm/sun4i: Add A83t LVDS support Priit Laes
2017-12-14  7:01   ` Priit Laes
2017-12-14  8:37   ` Maxime Ripard
2017-12-14  8:37     ` Maxime Ripard
2017-12-14  8:37     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219085950.domvcod2dyqdi3v3@flea.lan \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.