From: Stephen Hemminger <stephen@networkplumber.org>
To: Cathy Avery <cavery@redhat.com>
Cc: kys@microsoft.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, sthemmin@microsoft.com,
linux-scsi@vger.kernel.org, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
Date: Tue, 19 Dec 2017 10:37:10 -0800 [thread overview]
Message-ID: <20171219103710.2251e259@xeon-e3> (raw)
In-Reply-To: <1513708368-25951-1-git-send-email-cavery@redhat.com>
On Tue, 19 Dec 2017 13:32:48 -0500
Cathy Avery <cavery@redhat.com> wrote:
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise
> the I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
>
> Signed-off-by: Cathy Avery <cavery@redhat.com>
> Signed-off-by: Long Li <longli@microsoft.com>
When working on the DVD probe issue I saw that error handling was
problematic. Thanks for fixing.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2017-12-19 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 18:32 [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error Cathy Avery
2017-12-19 18:32 ` Cathy Avery
2017-12-19 18:37 ` Stephen Hemminger [this message]
2017-12-21 2:24 ` Martin K. Petersen
2017-12-21 2:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219103710.2251e259@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cavery@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.