From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: sthemmin@microsoft.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
jejb@linux.vnet.ibm.com
Subject: Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
Date: Wed, 20 Dec 2017 21:24:10 -0500 [thread overview]
Message-ID: <yq1fu84hl85.fsf@oracle.com> (raw)
In-Reply-To: <1513708368-25951-1-git-send-email-cavery@redhat.com> (Cathy Avery's message of "Tue, 19 Dec 2017 13:32:48 -0500")
Cathy,
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise the
> I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding
> scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
Applied to 4.15/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: kys@microsoft.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, sthemmin@microsoft.com,
haiyangz@microsoft.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
longli@microsoft.com
Subject: Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
Date: Wed, 20 Dec 2017 21:24:10 -0500 [thread overview]
Message-ID: <yq1fu84hl85.fsf@oracle.com> (raw)
In-Reply-To: <1513708368-25951-1-git-send-email-cavery@redhat.com> (Cathy Avery's message of "Tue, 19 Dec 2017 13:32:48 -0500")
Cathy,
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise the
> I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding
> scsi_sd_probe_domain.
>
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
Applied to 4.15/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-12-21 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 18:32 [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error Cathy Avery
2017-12-19 18:32 ` Cathy Avery
2017-12-19 18:37 ` Stephen Hemminger
2017-12-21 2:24 ` Martin K. Petersen [this message]
2017-12-21 2:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fu84hl85.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=cavery@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.