From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Radu Pirea <radu.pirea@microchip.com>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
nicolas.ferre@microchip.com, Wenyou.Yang@microchip.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] spi: atmel: Implements transfers with bounce buffer
Date: Tue, 19 Dec 2017 11:43:33 +0100 [thread overview]
Message-ID: <20171219104333.GL15162@piout.net> (raw)
In-Reply-To: <1513093032-11570-1-git-send-email-radu.pirea@microchip.com>
On 12/12/2017 at 17:37:12 +0200, Radu Pirea wrote:
> This patch enables DMA transfers for Atmel SAM9 SoCs and implements a bounce
> buffer for transfers which have vmalloc allocated buffers. Those buffers are
> not cache coherent even if they have been transformed into sg lists. UBIFS
> is affected by this cache coherency issue.
>
> In this patch I also reverted "spi: atmel: fix corrupted data issue on SAM9
> family SoCs"(7094576ccdc3acfe1e06a1e2ab547add375baf7f).
>
>
> Signed-off-by: Radu Pirea <radu.pirea@microchip.com>
> ---
> Please ignore the previous version. I messed up with file names.
> drivers/spi/spi-atmel.c | 113 +++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 84 insertions(+), 29 deletions(-)
>
There are multiple checkpatch issues, can you fix them?
> + if(!as->use_dma)
Especially that missing space.
> + dev_info(master->dev.parent,
> + " can not allocate dma coherent memory\n");
> + }
> +
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] spi: atmel: Implements transfers with bounce buffer
Date: Tue, 19 Dec 2017 11:43:33 +0100 [thread overview]
Message-ID: <20171219104333.GL15162@piout.net> (raw)
In-Reply-To: <1513093032-11570-1-git-send-email-radu.pirea@microchip.com>
On 12/12/2017 at 17:37:12 +0200, Radu Pirea wrote:
> This patch enables DMA transfers for Atmel SAM9 SoCs and implements a bounce
> buffer for transfers which have vmalloc allocated buffers. Those buffers are
> not cache coherent even if they have been transformed into sg lists. UBIFS
> is affected by this cache coherency issue.
>
> In this patch I also reverted "spi: atmel: fix corrupted data issue on SAM9
> family SoCs"(7094576ccdc3acfe1e06a1e2ab547add375baf7f).
>
>
> Signed-off-by: Radu Pirea <radu.pirea@microchip.com>
> ---
> Please ignore the previous version. I messed up with file names.
> drivers/spi/spi-atmel.c | 113 +++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 84 insertions(+), 29 deletions(-)
>
There are multiple checkpatch issues, can you fix them?
> + if(!as->use_dma)
Especially that missing space.
> + dev_info(master->dev.parent,
> + " can not allocate dma coherent memory\n");
> + }
> +
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-19 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 15:37 [PATCH v2] spi: atmel: Implements transfers with bounce buffer Radu Pirea
2017-12-12 15:37 ` Radu Pirea
2017-12-12 15:37 ` Radu Pirea
[not found] ` <1513093032-11570-1-git-send-email-radu.pirea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-12-19 10:25 ` Nicolas Ferre
2017-12-19 10:25 ` Nicolas Ferre
2017-12-19 10:25 ` Nicolas Ferre
2017-12-19 10:43 ` Alexandre Belloni [this message]
2017-12-19 10:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219104333.GL15162@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=Wenyou.Yang@microchip.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radu.pirea@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.