Re: [Qemu-trivial] [PATCH] monitor: Remove legacy "-mon default=on" parameter

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Thomas Huth (thuth@redhat.com) wrote:
> On 19.12.2017 17:21, Daniel P. Berrange wrote:
> > On Tue, Dec 19, 2017 at 05:17:33PM +0100, Thomas Huth wrote:
> >> The "default" parameter of the "-mon" option is useless since
> >> QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That
> >> should have been long enough to let people update their scripts,
> >> so time to remove it now.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >> ---
> >>  monitor.c     | 3 ---
> >>  qemu-doc.texi | 9 ---------
> >>  vl.c          | 4 ----
> >>  3 files changed, 16 deletions(-)
> >>
> >> diff --git a/monitor.c b/monitor.c
> >> index e36fb53..e53c6e1 100644
> >> --- a/monitor.c
> >> +++ b/monitor.c
> >> @@ -4141,9 +4141,6 @@ QemuOptsList qemu_mon_opts = {
> >>              .name = "chardev",
> >>              .type = QEMU_OPT_STRING,
> >>          },{
> >> -            .name = "default",  /* deprecated */
> >> -            .type = QEMU_OPT_BOOL,
> >> -        },{
> >>              .name = "pretty",
> >>              .type = QEMU_OPT_BOOL,
> >>          },
> >> diff --git a/qemu-doc.texi b/qemu-doc.texi
> >> index d9861b3..6913b32 100644
> >> --- a/qemu-doc.texi
> >> +++ b/qemu-doc.texi
> >> @@ -2401,15 +2401,6 @@ setting ``-machine kernel_irqchip=off''.
> >>  The ``-no-kvm'' argument is now a synonym for setting
> >>  ``-machine accel=tcg''.
> >>  
> >> -@subsection -mon default=on (since 2.4.0)
> >> -
> >> -The ``default'' option to the ``-mon'' argument is
> >> -now ignored. When multiple monitors were enabled, it
> >> -indicated which monitor would receive log messages
> >> -from the various subsystems. This feature is no longer
> >> -required as messages are now only sent to the monitor
> >> -in response to explicitly monitor commands.
> >> -
> >>  @subsection -vnc tls (since 2.5.0)
> > 
> > It occurs to me that qemu.org only ever displays the very latest version
> > of the qemu-tech doc.
> > 
> > So if someone has deployed QEMU 2.11, and reads the doc online, once your
> > patches are commited, all the info about deprecated features that affect
> > their 2.11 version will have gone, despite 2.12 not yet existing.
> 
> No, as far as I know, the online qemu-doc is only updated for release
> candidates and releases, so the current information will stay there a
> little bit longer.
> 
> > So rather than deleting entries from the deprecation appendix, should
> > we move them to a separate appendix, or "Formerly deprecated, now
> > deleted" features. Or just change the annotation
> > 
> >   (since 2.4.0)
> > 
> > to
> > 
> >   (deprecated since 2.4.0, deleted in 2.12.0)
> 
> Please, no. I really don't think that we should carry around the old
> cruft forever, even if it's just in the deprecation chapter of the
> qemu-doc. At one point in time, we should really just let it go. If
> users still want to get information about this afterwards, they can use
> Google to dig out older versions of the qemu-doc or the various
> ChangeLog pages in our Wiki, where we describe the deprecation of
> parameters, too.

I agree this is a job for a separate page; either the ChangeLog or
a separate 'defunct' wikipage.

Dave

>  Thomas
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK