From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW
Date: Wed, 20 Dec 2017 10:34:03 +0200 [thread overview]
Message-ID: <20171220083403.GA27231@bitmer.com> (raw)
In-Reply-To: <cd38f14f06e1f447b3159ffe8c69c0df8241bb6e.1513706701.git.joe@perches.com>
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
...
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 7a54e3083203..79d4dc785e5c 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -854,7 +854,7 @@ static ssize_t dma_op_mode_store(struct device *dev,
> return size;
> }
>
> -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store);
> +static DEVICE_ATTR_RW(dma_op_mode);
>
While I can ack this part here if it helps generic cleanup effort I
don't understart would it improve code readability in general? Mode 644
is clear and don't need any grepping but for DEVICE_ATTR_RW() I had to go
through all of these files in order to see what does it mean:
DEVICE_ATTR_RW: include/linux/device.h
__ATTR_RW: include/linux/sysfs.h
S_IWUSR: include/uapi/linux/stat.h
S_IRUGO: include/linux/stat.h
Jarkko Nikula <jarkko.nikula@bitmer.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW
Date: Wed, 20 Dec 2017 08:34:03 +0000 [thread overview]
Message-ID: <20171220083403.GA27231@bitmer.com> (raw)
In-Reply-To: <cd38f14f06e1f447b3159ffe8c69c0df8241bb6e.1513706701.git.joe@perches.com>
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
...
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 7a54e3083203..79d4dc785e5c 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -854,7 +854,7 @@ static ssize_t dma_op_mode_store(struct device *dev,
> return size;
> }
>
> -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store);
> +static DEVICE_ATTR_RW(dma_op_mode);
>
While I can ack this part here if it helps generic cleanup effort I
don't understart would it improve code readability in general? Mode 644
is clear and don't need any grepping but for DEVICE_ATTR_RW() I had to go
through all of these files in order to see what does it mean:
DEVICE_ATTR_RW: include/linux/device.h
__ATTR_RW: include/linux/sysfs.h
S_IWUSR: include/uapi/linux/stat.h
S_IRUGO: include/linux/stat.h
Jarkko Nikula <jarkko.nikula@bitmer.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Airlie <airlied@linux.ie>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jiri Slaby <jslaby@suse.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-pm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: [-next,2/4] treewide: Use DEVICE_ATTR_RW
Date: Wed, 20 Dec 2017 10:34:03 +0200 [thread overview]
Message-ID: <20171220083403.GA27231@bitmer.com> (raw)
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
...
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 7a54e3083203..79d4dc785e5c 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -854,7 +854,7 @@ static ssize_t dma_op_mode_store(struct device *dev,
> return size;
> }
>
> -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store);
> +static DEVICE_ATTR_RW(dma_op_mode);
>
While I can ack this part here if it helps generic cleanup effort I
don't understart would it improve code readability in general? Mode 644
is clear and don't need any grepping but for DEVICE_ATTR_RW() I had to go
through all of these files in order to see what does it mean:
DEVICE_ATTR_RW: include/linux/device.h
__ATTR_RW: include/linux/sysfs.h
S_IWUSR: include/uapi/linux/stat.h
S_IRUGO: include/linux/stat.h
Jarkko Nikula <jarkko.nikula@bitmer.com>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Joe Perches <joe@perches.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Airlie <airlied@linux.ie>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jiri Slaby <jslaby@suse.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-pm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW
Date: Wed, 20 Dec 2017 10:34:03 +0200 [thread overview]
Message-ID: <20171220083403.GA27231@bitmer.com> (raw)
In-Reply-To: <cd38f14f06e1f447b3159ffe8c69c0df8241bb6e.1513706701.git.joe@perches.com>
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
...
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 7a54e3083203..79d4dc785e5c 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -854,7 +854,7 @@ static ssize_t dma_op_mode_store(struct device *dev,
> return size;
> }
>
> -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store);
> +static DEVICE_ATTR_RW(dma_op_mode);
>
While I can ack this part here if it helps generic cleanup effort I
don't understart would it improve code readability in general? Mode 644
is clear and don't need any grepping but for DEVICE_ATTR_RW() I had to go
through all of these files in order to see what does it mean:
DEVICE_ATTR_RW: include/linux/device.h
__ATTR_RW: include/linux/sysfs.h
S_IWUSR: include/uapi/linux/stat.h
S_IRUGO: include/linux/stat.h
Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2017-12-20 8:34 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 18:15 [-next PATCH 0/4] sysfs and DEVICE_ATTR_<foo> Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-19 18:15 ` [-next PATCH 1/4] sysfs.h: Use octal permissions Joe Perches
2017-12-19 18:15 ` [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-19 18:15 ` [-next,2/4] " Joe Perches
2017-12-19 18:15 ` [-next PATCH 2/4] " Joe Perches
2017-12-19 18:41 ` Andy Shevchenko
2017-12-19 18:41 ` Andy Shevchenko
2017-12-19 18:41 ` [-next,2/4] " Andy Shevchenko
2017-12-19 18:41 ` [-next PATCH 2/4] " Andy Shevchenko
2017-12-20 7:19 ` [alsa-devel] " Jidong Zhang
2017-12-20 8:34 ` Jarkko Nikula [this message]
2017-12-20 8:34 ` Jarkko Nikula
2017-12-20 8:34 ` [-next,2/4] " Jarkko Nikula
2017-12-20 8:34 ` [-next PATCH 2/4] " Jarkko Nikula
2017-12-20 9:24 ` Joe Perches
2017-12-20 9:24 ` Joe Perches
2017-12-20 9:24 ` [-next,2/4] " Joe Perches
2017-12-20 9:24 ` [-next PATCH 2/4] " Joe Perches
2017-12-20 9:32 ` Greg Kroah-Hartman
2017-12-20 9:32 ` Greg Kroah-Hartman
2017-12-20 9:32 ` [-next,2/4] " Greg Kroah-Hartman
2017-12-20 9:32 ` [-next PATCH 2/4] " Greg Kroah-Hartman
2017-12-20 9:54 ` Joe Perches
2017-12-20 9:54 ` Joe Perches
2017-12-20 9:54 ` [-next,2/4] " Joe Perches
2017-12-20 9:54 ` [-next PATCH 2/4] " Joe Perches
2017-12-20 9:59 ` Greg Kroah-Hartman
2017-12-20 9:59 ` Greg Kroah-Hartman
2017-12-20 9:59 ` [-next,2/4] " Greg Kroah-Hartman
2017-12-20 9:59 ` [-next PATCH 2/4] " Greg Kroah-Hartman
2017-12-20 10:55 ` Joe Perches
2017-12-20 10:55 ` Joe Perches
2017-12-20 10:55 ` [-next,2/4] " Joe Perches
2017-12-20 10:55 ` [-next PATCH 2/4] " Joe Perches
2017-12-20 13:26 ` Julia Lawall
2017-12-20 13:26 ` Julia Lawall
2017-12-20 13:26 ` [-next,2/4] " Julia Lawall
2017-12-20 13:26 ` [-next PATCH 2/4] " Julia Lawall
2017-12-20 10:54 ` Jarkko Nikula
2017-12-20 10:54 ` Jarkko Nikula
2017-12-20 10:54 ` [-next,2/4] " Jarkko Nikula
2017-12-20 10:54 ` [-next PATCH 2/4] " Jarkko Nikula
2018-01-10 14:43 ` Peter Ujfalusi
2018-01-10 14:43 ` Peter Ujfalusi
2018-01-10 14:43 ` [-next,2/4] " Peter Ujfalusi
2018-01-10 14:43 ` [-next PATCH 2/4] " Peter Ujfalusi
2017-12-21 0:47 ` Zhang Rui
2017-12-21 0:47 ` Zhang Rui
2017-12-21 0:47 ` [-next,2/4] " Zhang, Rui
2017-12-21 0:47 ` [-next PATCH 2/4] " Zhang Rui
2018-01-03 15:16 ` Bartlomiej Zolnierkiewicz
2018-01-03 15:16 ` Bartlomiej Zolnierkiewicz
2018-01-03 15:16 ` [-next,2/4] " Bartlomiej Zolnierkiewicz
2018-01-03 15:16 ` [-next PATCH 2/4] " Bartlomiej Zolnierkiewicz
2017-12-19 18:15 ` [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-19 18:15 ` Joe Perches
2017-12-20 19:00 ` Rafael J. Wysocki
2017-12-20 20:26 ` Sagi Grimberg
2017-12-20 21:38 ` Robert Jarzmik
2017-12-21 0:48 ` Zhang Rui
2017-12-21 0:48 ` Zhang Rui
2017-12-21 0:48 ` Zhang Rui
2017-12-21 7:55 ` Harald Freudenberger
2017-12-21 9:34 ` Sakari Ailus
2018-01-09 15:34 ` Greg Kroah-Hartman
2018-01-09 15:34 ` Greg Kroah-Hartman
2017-12-19 18:15 ` [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO Joe Perches
2017-12-19 18:44 ` Borislav Petkov
2017-12-19 18:44 ` Borislav Petkov
2017-12-19 18:51 ` Joe Perches
2017-12-19 18:51 ` Joe Perches
2017-12-19 18:54 ` Borislav Petkov
2017-12-19 18:54 ` Borislav Petkov
2017-12-21 0:50 ` Zhang Rui
2017-12-19 18:54 ` [-next PATCH 0/4] sysfs and DEVICE_ATTR_<foo> Jani Nikula
2017-12-19 18:54 ` Jani Nikula
2017-12-19 18:54 ` Jani Nikula
2017-12-19 18:54 ` Jani Nikula
2017-12-19 19:26 ` Corey Minyard
2017-12-19 19:26 ` Corey Minyard
2017-12-19 19:26 ` Corey Minyard
2017-12-19 19:26 ` Corey Minyard
2017-12-19 19:26 ` Corey Minyard
2017-12-20 9:46 ` Felipe Balbi
2017-12-20 9:46 ` Felipe Balbi
2017-12-20 9:46 ` Felipe Balbi
2017-12-20 9:46 ` Felipe Balbi
2017-12-20 9:46 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220083403.GA27231@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=andy@infradead.org \
--cc=balbi@kernel.org \
--cc=cezary.jackiewicz@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=dvhart@infradead.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.smart@broadcom.com \
--cc=jani.nikula@linux.intel.com \
--cc=joe@perches.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=mathias.nyman@intel.com \
--cc=mcgrof@kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=peter.ujfalusi@ti.com \
--cc=rodrigo.vivi@intel.com \
--cc=rui.zhang@intel.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.