All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Olivier MOYSAN <olivier.moysan@st.com>
Cc: Benjamin GAIGNARD <benjamin.gaignard@st.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@opensource.wolfsonmicro.com"
	<patches@opensource.wolfsonmicro.com>,
	Arnaud POULIQUEN <arnaud.pouliquen@st.com>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kernel@stlinux.com" <kernel@stlinux.com>
Subject: Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver
Date: Wed, 20 Dec 2017 15:50:00 +0000	[thread overview]
Message-ID: <20171220155000.GD17890@sirena.org.uk> (raw)
In-Reply-To: <c51bf5a8-27f7-6d76-f4fb-c8884387bdca@st.com>


[-- Attachment #1.1: Type: text/plain, Size: 822 bytes --]

On Wed, Dec 20, 2017 at 12:42:10PM +0000, Olivier MOYSAN wrote:

> As a generic machine, simple or audio graph cards are not able to manage 
> codec clock muxing.
> If we exclude the management of muxing through codec controls,
> the remaining solution is to handle it fully through clock framework.
> The current patch only supports a limited range of muxing capabilities 
> of the codec.
> To have a full management of the muxing, I think it is necessary to add
> a device tree node for each codec interface and to define an aif clock 
> in these nodes.
> Then parent clock assignment of these aif clocks would allow to handle 
> the muxing.

Controlling clocking through a clock API binding would be good, yes.
That'd solve a bunch of other problems with use of multi-purpose clocks
for audio as well.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Olivier MOYSAN <olivier.moysan@st.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"perex@perex.cz" <perex@perex.cz>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"kernel@stlinux.com" <kernel@stlinux.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Arnaud POULIQUEN <arnaud.pouliquen@st.com>,
	Benjamin GAIGNARD <benjamin.gaignard@st.com>,
	"patches@opensource.wolfsonmicro.com" 
	<patches@opensource.wolfsonmicro.com>
Subject: Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver
Date: Wed, 20 Dec 2017 15:50:00 +0000	[thread overview]
Message-ID: <20171220155000.GD17890@sirena.org.uk> (raw)
In-Reply-To: <c51bf5a8-27f7-6d76-f4fb-c8884387bdca@st.com>

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

On Wed, Dec 20, 2017 at 12:42:10PM +0000, Olivier MOYSAN wrote:

> As a generic machine, simple or audio graph cards are not able to manage 
> codec clock muxing.
> If we exclude the management of muxing through codec controls,
> the remaining solution is to handle it fully through clock framework.
> The current patch only supports a limited range of muxing capabilities 
> of the codec.
> To have a full management of the muxing, I think it is necessary to add
> a device tree node for each codec interface and to define an aif clock 
> in these nodes.
> Then parent clock assignment of these aif clocks would allow to handle 
> the muxing.

Controlling clocking through a clock API binding would be good, yes.
That'd solve a bunch of other problems with use of multi-purpose clocks
for audio as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2017-12-20 15:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 16:53 [RFC PATCH 0/2] select master clock in wm8994 driver based on DT clocks configuration Olivier Moysan
2017-12-14 16:53 ` Olivier Moysan
2017-12-14 16:53 ` Olivier Moysan
2017-12-14 16:53 ` [RFC PATCH 1/2] ASoC: add support of mclk clock providers in wm8894 driver Olivier Moysan
2017-12-14 16:53   ` Olivier Moysan
2017-12-14 16:53   ` Olivier Moysan
2017-12-14 17:30   ` Mark Brown
2017-12-14 17:30     ` Mark Brown
2017-12-15 11:51     ` Charles Keepax
2017-12-15 11:51       ` Charles Keepax
2017-12-15 11:51       ` Charles Keepax
2017-12-14 16:53 ` [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver Olivier Moysan
2017-12-14 16:53   ` Olivier Moysan
2017-12-14 16:53   ` Olivier Moysan
2017-12-14 17:36   ` Mark Brown
2017-12-14 17:36     ` Mark Brown
2017-12-15 11:46     ` Charles Keepax
2017-12-15 11:46       ` Charles Keepax
2017-12-15 11:46       ` Charles Keepax
2017-12-15 15:15     ` Olivier MOYSAN
2017-12-15 15:15       ` Olivier MOYSAN
2017-12-15 15:15       ` Olivier MOYSAN
2017-12-19  9:35       ` Mark Brown
2017-12-19  9:35         ` Mark Brown
2017-12-19  9:35         ` Mark Brown
2017-12-20 12:42         ` Olivier MOYSAN
2017-12-20 12:42           ` Olivier MOYSAN
2017-12-20 12:42           ` Olivier MOYSAN
2017-12-20 15:50           ` Mark Brown [this message]
2017-12-20 15:50             ` Mark Brown
2017-12-21 10:51             ` Olivier MOYSAN
2017-12-21 10:51               ` Olivier MOYSAN
2017-12-21 10:51               ` Olivier MOYSAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220155000.GD17890@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=benjamin.gaignard@st.com \
    --cc=kernel@stlinux.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=olivier.moysan@st.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.