Re: [PATCH 0/8] Misc i915_drv.h cleanups

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Dec 20, 2017 at 07:24:52PM +0000, Jani Nikula wrote:
> On Wed, 20 Dec 2017, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> > Our main header is huge. Lets try to make some cleanup.
> 
> Overall seems fine, I think I agree with Chris' review. I do want
> Rodrigo's ack wrt upcoming stuff that's bound to conflict with many of
> the patches here. I don't want to cause unnecessary burden.

With the reviews in place and addressing everything was raised there,

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(Please don't use this to by-pass reviews in this case)

My first thought was actually a "oh no! a lot of conflict on my way!"
but looking to the content itself it made sense... ;)

Thanks,
Rodrigo.

> 
> BR,
> Jani.
> 
> 
> 
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >
> > Michal Wajdeczko (8):
> >   drm/i915: Move uint_fixed_16_16_t to i915_types.h
> >   drm/i915: Move some utility functions to i915_util.h
> >   drm/i915: Move display related definitions to dedicated header
> >   drm/i915: Move opregion definitions to dedicated intel_opregion.h
> >   drm/i915: Move intel_device_info definitions to its own header
> >   drm/i915: Update intel_device_info_runtime_init() parameter
> >   drm/i915: Add pretty printer for runtime part of intel_device_info
> >   drm/i915: Dump device info at once
> >
> >  drivers/gpu/drm/i915/i915_drv.c          |  15 +-
> >  drivers/gpu/drm/i915/i915_drv.h          | 633 +------------------------------
> >  drivers/gpu/drm/i915/i915_types.h        | 168 ++++++++
> >  drivers/gpu/drm/i915/i915_utils.h        |  15 +
> >  drivers/gpu/drm/i915/intel_device_info.c |  55 ++-
> >  drivers/gpu/drm/i915/intel_device_info.h | 175 +++++++++
> >  drivers/gpu/drm/i915/intel_display.h     | 312 +++++++++++++++
> >  drivers/gpu/drm/i915/intel_opregion.c    |   2 +
> >  drivers/gpu/drm/i915/intel_opregion.h    |  99 +++++
> >  9 files changed, 817 insertions(+), 657 deletions(-)
> >  create mode 100644 drivers/gpu/drm/i915/i915_types.h
> >  create mode 100644 drivers/gpu/drm/i915/intel_device_info.h
> >  create mode 100644 drivers/gpu/drm/i915/intel_display.h
> >  create mode 100644 drivers/gpu/drm/i915/intel_opregion.h
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx