All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 0/8] Misc i915_drv.h cleanups
Date: Wed, 20 Dec 2017 21:24:52 +0200	[thread overview]
Message-ID: <87lghxnqwr.fsf@intel.com> (raw)
In-Reply-To: <20171220183610.23264-1-michal.wajdeczko@intel.com>

On Wed, 20 Dec 2017, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> Our main header is huge. Lets try to make some cleanup.

Overall seems fine, I think I agree with Chris' review. I do want
Rodrigo's ack wrt upcoming stuff that's bound to conflict with many of
the patches here. I don't want to cause unnecessary burden.

BR,
Jani.



>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Michal Wajdeczko (8):
>   drm/i915: Move uint_fixed_16_16_t to i915_types.h
>   drm/i915: Move some utility functions to i915_util.h
>   drm/i915: Move display related definitions to dedicated header
>   drm/i915: Move opregion definitions to dedicated intel_opregion.h
>   drm/i915: Move intel_device_info definitions to its own header
>   drm/i915: Update intel_device_info_runtime_init() parameter
>   drm/i915: Add pretty printer for runtime part of intel_device_info
>   drm/i915: Dump device info at once
>
>  drivers/gpu/drm/i915/i915_drv.c          |  15 +-
>  drivers/gpu/drm/i915/i915_drv.h          | 633 +------------------------------
>  drivers/gpu/drm/i915/i915_types.h        | 168 ++++++++
>  drivers/gpu/drm/i915/i915_utils.h        |  15 +
>  drivers/gpu/drm/i915/intel_device_info.c |  55 ++-
>  drivers/gpu/drm/i915/intel_device_info.h | 175 +++++++++
>  drivers/gpu/drm/i915/intel_display.h     | 312 +++++++++++++++
>  drivers/gpu/drm/i915/intel_opregion.c    |   2 +
>  drivers/gpu/drm/i915/intel_opregion.h    |  99 +++++
>  9 files changed, 817 insertions(+), 657 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/i915_types.h
>  create mode 100644 drivers/gpu/drm/i915/intel_device_info.h
>  create mode 100644 drivers/gpu/drm/i915/intel_display.h
>  create mode 100644 drivers/gpu/drm/i915/intel_opregion.h

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-12-20 19:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 18:36 [PATCH 0/8] Misc i915_drv.h cleanups Michal Wajdeczko
2017-12-20 18:36 ` [PATCH 1/8] drm/i915: Move uint_fixed_16_16_t to i915_types.h Michal Wajdeczko
2017-12-20 18:55   ` Chris Wilson
2017-12-21 11:37     ` Michal Wajdeczko
2017-12-21 11:54       ` Chris Wilson
2017-12-20 18:36 ` [PATCH 2/8] drm/i915: Move some utility functions to i915_util.h Michal Wajdeczko
2017-12-20 18:57   ` Chris Wilson
2017-12-20 18:36 ` [PATCH 3/8] drm/i915: Move display related definitions to dedicated header Michal Wajdeczko
2017-12-20 18:58   ` Chris Wilson
2017-12-20 18:36 ` [PATCH 4/8] drm/i915: Move opregion definitions to dedicated intel_opregion.h Michal Wajdeczko
2017-12-20 19:00   ` Chris Wilson
2017-12-20 18:36 ` [PATCH 5/8] drm/i915: Move intel_device_info definitions to its own header Michal Wajdeczko
2017-12-20 19:07   ` Chris Wilson
2017-12-21 11:42     ` Michal Wajdeczko
2017-12-20 18:36 ` [PATCH 6/8] drm/i915: Update intel_device_info_runtime_init() parameter Michal Wajdeczko
2017-12-20 19:11   ` Chris Wilson
2017-12-20 18:36 ` [PATCH 7/8] drm/i915: Add pretty printer for runtime part of intel_device_info Michal Wajdeczko
2017-12-20 18:49   ` Chris Wilson
2017-12-20 18:36 ` [PATCH 8/8] drm/i915: Dump device info at once Michal Wajdeczko
2017-12-20 19:15   ` Chris Wilson
2017-12-20 19:11 ` ✗ Fi.CI.BAT: failure for Misc i915_drv.h cleanups Patchwork
2017-12-20 19:24 ` Jani Nikula [this message]
2017-12-20 19:33   ` [PATCH 0/8] " Rodrigo Vivi
  -- strict thread matches above, loose matches on Subject: below --
2017-12-21 18:53 Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lghxnqwr.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.