Re: [PATCH 2/3] drm/panel: Add Ilitek ILI9322 driver

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2988 bytes --]

On Thu, Dec 21, 2017 at 03:15:56PM +0100, Thierry Reding wrote:
> On Fri, Dec 01, 2017 at 05:16:58PM +0100, Linus Walleij wrote:
> > This adds support for the Ilitek ILI9322 QVGA (320x240)
> > TFT panel driver.
> > 
> > This panel driver supports serial or parallel RGB or
> > YUV input and also ITU-T BT.656 input streams.
> > 
> > The controller is combined with a physical panel and
> > configured through the device tree.
> > 
> > Cc: David Lechner <david@lechnology.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Ben Dooks <ben.dooks@codethink.co.uk>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > ChangeLog v1->v2:
> > - Dropped all DT parsing code in favor of open-coding the
> >   display config on a per-system basis based on system-specific
> >   compatible strings, after feedback from the DT maintainers.
> > - Define a set of configs for the D-Link DIR-685 router.
> > - Tested on the D-Link DIR-685.
> > ---
> >  drivers/gpu/drm/panel/Kconfig                |   8 +
> >  drivers/gpu/drm/panel/Makefile               |   1 +
> >  drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 962 +++++++++++++++++++++++++++
> >  3 files changed, 971 insertions(+)
> >  create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> 
> checkpatch.pl gives me these:
> 
> 	-:30: WARNING: please write a paragraph that describes the config symbol fully
> 	#30: FILE: drivers/gpu/drm/panel/Kconfig:31:
> 	+config DRM_PANEL_ILITEK_IL9322
> 
> 	-:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> 	#54:
> 	new file mode 100644
> 
> 	-:130: CHECK: Prefer using the BIT macro
> 	#130: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:72:
> 	+#define ILI9322_ENTRY_PAL              (1 << 2)
> 
> 	-:134: CHECK: Prefer using the BIT macro
> 	#134: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:76:
> 	+#define ILI9322_ENTRY_SERIAL_RGB_ALIGNED (1 << 4)
> 
> 	-:196: CHECK: spaces preferred around that '|' (ctx:VxV)
> 	#196: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:138:
> 	+#define ILI9322_IF_CTRL_SYNC_DISABLED  (BIT(2)|BIT(3))
> 						       ^
> 
> 	-:551: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
> 	#551: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:493:
> 	+       msleep(10);
> 
> 	total: 0 errors, 3 warnings, 3 checks, 983 lines checked
> 
> I'd like to see at least the warnings fixed. You can probably skip the
> entry in MAINTAINERS, though. I don't mind fixing these up while
> applying, but I don't know what to put in Kconfig. If you can send out
> a short paragraph for me to include I'll add it when I apply.

Daniel just reminded me on IRC that you have commit rights to drm-misc,
so once you've fixed up the bulk of the checkpatch warnings (nevermind
those "prefer the BIT macro" checks), feel free to push this yourself
with my:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel