From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: Ted Tso <tytso-3s7WtUTddSA@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler
Date: Thu, 21 Dec 2017 10:17:01 -0700 [thread overview]
Message-ID: <20171221171701.GC2158@linux.intel.com> (raw)
In-Reply-To: <20171221163055.3943-3-jack-AlSwsSmVLrQ@public.gmane.org>
On Thu, Dec 21, 2017 at 05:30:55PM +0100, Jan Kara wrote:
> When allocation of underlying block for a page fault fails, we fail the
> fault with SIGBUS. However we may well hit ENOSPC just due to lots of
> free blocks being held by the running / committing transaction. So
> propagate the error from ext4_iomap_begin() and implement do standard
> allocation retry loop in ext4_dax_huge_fault().
>
> Signed-off-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Looks good.
Reviewed-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler
Date: Thu, 21 Dec 2017 10:17:01 -0700 [thread overview]
Message-ID: <20171221171701.GC2158@linux.intel.com> (raw)
In-Reply-To: <20171221163055.3943-3-jack@suse.cz>
On Thu, Dec 21, 2017 at 05:30:55PM +0100, Jan Kara wrote:
> When allocation of underlying block for a page fault fails, we fail the
> fault with SIGBUS. However we may well hit ENOSPC just due to lots of
> free blocks being held by the running / committing transaction. So
> propagate the error from ext4_iomap_begin() and implement do standard
> allocation retry loop in ext4_dax_huge_fault().
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks good.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, Ted Tso <tytso@mit.edu>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler
Date: Thu, 21 Dec 2017 10:17:01 -0700 [thread overview]
Message-ID: <20171221171701.GC2158@linux.intel.com> (raw)
In-Reply-To: <20171221163055.3943-3-jack@suse.cz>
On Thu, Dec 21, 2017 at 05:30:55PM +0100, Jan Kara wrote:
> When allocation of underlying block for a page fault fails, we fail the
> fault with SIGBUS. However we may well hit ENOSPC just due to lots of
> free blocks being held by the running / committing transaction. So
> propagate the error from ext4_iomap_begin() and implement do standard
> allocation retry loop in ext4_dax_huge_fault().
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks good.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
next prev parent reply other threads:[~2017-12-21 17:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 16:30 [PATCH 0/2 v2] ext4: Fix ENOSPC handling for DAX faults Jan Kara
2017-12-21 16:30 ` Jan Kara
2017-12-21 16:30 ` [PATCH 1/2] dax: Pass detailed error code from dax_iomap_fault() Jan Kara
2017-12-21 16:30 ` Jan Kara
[not found] ` <20171221163055.3943-2-jack-AlSwsSmVLrQ@public.gmane.org>
2017-12-21 17:12 ` Dan Williams
2017-12-21 17:12 ` Dan Williams
2017-12-21 17:12 ` Dan Williams
2018-01-02 18:54 ` Jan Kara
2018-01-02 18:54 ` Jan Kara
2018-01-02 18:57 ` Dan Williams
2018-01-02 18:57 ` Dan Williams
2017-12-21 17:16 ` Ross Zwisler
2017-12-21 17:16 ` Ross Zwisler
[not found] ` <20171221163055.3943-1-jack-AlSwsSmVLrQ@public.gmane.org>
2017-12-21 16:30 ` [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler Jan Kara
2017-12-21 16:30 ` Jan Kara
2017-12-21 16:30 ` Jan Kara
[not found] ` <20171221163055.3943-3-jack-AlSwsSmVLrQ@public.gmane.org>
2017-12-21 17:17 ` Ross Zwisler [this message]
2017-12-21 17:17 ` Ross Zwisler
2017-12-21 17:17 ` Ross Zwisler
-- strict thread matches above, loose matches on Subject: below --
2018-01-03 10:08 [PATCH 0/2 v3] ext4: Fix ENOSPC handling for DAX faults Jan Kara
[not found] ` <20180103100844.12787-1-jack-AlSwsSmVLrQ@public.gmane.org>
2018-01-03 10:08 ` [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler Jan Kara
2018-01-03 10:08 ` Jan Kara
2018-01-03 10:08 ` Jan Kara
2018-01-07 21:51 ` Theodore Ts'o
2018-01-07 21:51 ` Theodore Ts'o
2017-12-13 9:13 [PATCH 0/2] ext4: Fix ENOSPC handling for DAX faults Jan Kara
[not found] ` <20171213091352.23448-1-jack-AlSwsSmVLrQ@public.gmane.org>
2017-12-13 9:13 ` [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler Jan Kara
2017-12-13 9:13 ` Jan Kara
2017-12-13 9:13 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221171701.GC2158@linux.intel.com \
--to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.