All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series
Date: Fri, 22 Dec 2017 11:56:42 +0100	[thread overview]
Message-ID: <20171222105642.GD18255@piout.net> (raw)
In-Reply-To: <b41bc779-28e8-5a87-6f66-f5874dba8d1e@suse.de>

+ Philippe

On 22/12/2017 at 11:43:33 +0100, Andreas F?rber wrote:
> >> I'll change it for v3 of this patch however it will end up like this:
> >> //SPDX-License...
> > 
> > That should be /* SPDX-License */, // is for c files.
> 
> Got any reference for that? Since we're using the C preprocessor before
> feeding them to dtc, we can use the same // style for both, builds fine.
> 
> Only for my private DT overlay files that I use directly with dtc I
> couldn't adopt that style.
> 
The doc states:

If a specific tool cannot handle the standard comment style, then the
appropriate comment mechanism which the tool accepts shall be used. This
is the reason for having the "/\* \*/" style comment in C header
files.

I interpreted that as dtc doesn't handle // comments, use /**/

But I agree it also states:
.dts{i}:	  // SPDX-License-Identifier: <SPDX License Expression>

So I think we will end up with a mix of both.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Andreas Färber" <afaerber@suse.de>,
	"Philippe Ombredanne" <pombredanne@nexb.com>
Cc: "Türk, Jan" <Jan.Tuerk@emtrion.de>,
	"'Rob Herring'" <robh@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"David Airlie" <airlied@linux.ie>,
	"Russell King" <linux@armlinux.org.uk>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"SZ Lin" <sz.lin@moxa.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	LinuxArmKernelMailingListe <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series
Date: Fri, 22 Dec 2017 11:56:42 +0100	[thread overview]
Message-ID: <20171222105642.GD18255@piout.net> (raw)
In-Reply-To: <b41bc779-28e8-5a87-6f66-f5874dba8d1e@suse.de>

+ Philippe

On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote:
> >> I'll change it for v3 of this patch however it will end up like this:
> >> //SPDX-License...
> > 
> > That should be /* SPDX-License */, // is for c files.
> 
> Got any reference for that? Since we're using the C preprocessor before
> feeding them to dtc, we can use the same // style for both, builds fine.
> 
> Only for my private DT overlay files that I use directly with dtc I
> couldn't adopt that style.
> 
The doc states:

If a specific tool cannot handle the standard comment style, then the
appropriate comment mechanism which the tool accepts shall be used. This
is the reason for having the "/\* \*/" style comment in C header
files.

I interpreted that as dtc doesn't handle // comments, use /**/

But I agree it also states:
.dts{i}:	  // SPDX-License-Identifier: <SPDX License Expression>

So I think we will end up with a mix of both.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-12-22 10:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 10:34 [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series Türk, Jan
2017-12-22 10:34 ` Türk, Jan
2017-12-22 10:40 ` Alexandre Belloni
2017-12-22 10:40   ` Alexandre Belloni
2017-12-22 10:43   ` Andreas Färber
2017-12-22 10:43     ` Andreas Färber
2017-12-22 10:43     ` Andreas Färber
2017-12-22 10:56     ` Alexandre Belloni [this message]
2017-12-22 10:56       ` Alexandre Belloni
2017-12-22 11:44       ` AW: " Türk, Jan
2017-12-22 11:44         ` Türk, Jan
2017-12-22 11:44         ` Türk, Jan
2017-12-26 17:16       ` Rob Herring
2017-12-26 17:16         ` Rob Herring
2017-12-26 17:16         ` Rob Herring
2017-12-28 13:57         ` Alexandre Belloni
2017-12-28 13:57           ` Alexandre Belloni
2017-12-28 13:57           ` Alexandre Belloni
2017-12-22 10:47 ` Andreas Färber
2017-12-22 10:47   ` Andreas Färber
2017-12-22 10:47   ` Andreas Färber
  -- strict thread matches above, loose matches on Subject: below --
2017-11-23 12:55 [PATCH 0/5] Add basic support for emtrion emCON-MX6 modules Jan Tuerk
2017-12-20 13:47 ` [PATCH v2 " jan.tuerk at emtrion.com
2017-12-20 13:47   ` [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series jan.tuerk at emtrion.com
2017-12-20 13:47     ` jan.tuerk
2017-12-21 23:19     ` Rob Herring
2017-12-21 23:19       ` Rob Herring
2017-12-21 23:19       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222105642.GD18255@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.