From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Dennis Dalessandro
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Michael J. Ruhl"
<michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Mike Marciniszyn
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH for-rc] IB/hfi: Only read capability registers if the capability exists
Date: Fri, 22 Dec 2017 09:53:52 -0700 [thread overview]
Message-ID: <20171222165352.GD30884@ziepe.ca> (raw)
In-Reply-To: <20171222164717.31842.12554.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
On Fri, Dec 22, 2017 at 08:47:20AM -0800, Dennis Dalessandro wrote:
> From: Michael J. Ruhl <michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> During driver init, various registers are saved to allow restoration
> after an FLR or gen3 bump. Some of these registers are not available
> in some circumstances (i.e. Virtual machines).
>
> Delete unnecessary register read/write, and only access register if
> the capability exists.
>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # 4.14.x
> Fixes: a618b7e40af2 ("IB/hfi1: Move saving PCI values to a separate function")
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> drivers/infiniband/hw/hfi1/hfi.h | 1 -
> drivers/infiniband/hw/hfi1/pcie.c | 30 ++++++++++++------------------
> 2 files changed, 12 insertions(+), 19 deletions(-)
Since we are getting late in the RC cycle can you help me clarify the
user visible bug here? No need to resend
I'm guessing when hfi1 is used in a virtual machine with passthrough
(SRIOV?) it fails in ?? way?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH for-rc] IB/hfi: Only read capability registers if the capability exists
Date: Fri, 22 Dec 2017 09:53:52 -0700 [thread overview]
Message-ID: <20171222165352.GD30884@ziepe.ca> (raw)
In-Reply-To: <20171222164717.31842.12554.stgit@scvm10.sc.intel.com>
On Fri, Dec 22, 2017 at 08:47:20AM -0800, Dennis Dalessandro wrote:
> From: Michael J. Ruhl <michael.j.ruhl@intel.com>
>
> During driver init, various registers are saved to allow restoration
> after an FLR or gen3 bump. Some of these registers are not available
> in some circumstances (i.e. Virtual machines).
>
> Delete unnecessary register read/write, and only access register if
> the capability exists.
>
> Cc: <stable@vger.kernel.org> # 4.14.x
> Fixes: a618b7e40af2 ("IB/hfi1: Move saving PCI values to a separate function")
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> drivers/infiniband/hw/hfi1/hfi.h | 1 -
> drivers/infiniband/hw/hfi1/pcie.c | 30 ++++++++++++------------------
> 2 files changed, 12 insertions(+), 19 deletions(-)
Since we are getting late in the RC cycle can you help me clarify the
user visible bug here? No need to resend
I'm guessing when hfi1 is used in a virtual machine with passthrough
(SRIOV?) it fails in ?? way?
Jason
next prev parent reply other threads:[~2017-12-22 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 16:47 [PATCH for-rc] IB/hfi: Only read capability registers if the capability exists Dennis Dalessandro
[not found] ` <20171222164717.31842.12554.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-12-22 16:53 ` Jason Gunthorpe [this message]
2017-12-22 16:53 ` Jason Gunthorpe
2017-12-22 17:11 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222165352.GD30884@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.