From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Colin King <colin.king@canonical.com>,
Loic Poulain <loic.poulain@linaro.org>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time
Date: Tue, 26 Dec 2017 20:13:12 +0000 [thread overview]
Message-ID: <20171226201312.GA7480@builder> (raw)
In-Reply-To: <20171219170401.15154-1-colin.king@canonical.com>
On Tue 19 Dec 09:04 PST 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> msg_body.min_ch_time is being assigned twice; remove the redundant
> first assignment.
>
> Detected by CoverityScan, CID#1463042 ("Unused Value")
>
Happy to see Coverity working for us :)
This should have had a:
Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 2914618a0335..bab2eca5fcac 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
> INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);
>
> msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
> - msg_body.min_ch_time = 30;
> msg_body.min_ch_time = 100;
But I strongly suspect the second line is supposed to be max_ch_time.
@Loic, do you agree?
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Colin King <colin.king@canonical.com>,
Loic Poulain <loic.poulain@linaro.org>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time
Date: Tue, 26 Dec 2017 12:13:12 -0800 [thread overview]
Message-ID: <20171226201312.GA7480@builder> (raw)
In-Reply-To: <20171219170401.15154-1-colin.king@canonical.com>
On Tue 19 Dec 09:04 PST 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> msg_body.min_ch_time is being assigned twice; remove the redundant
> first assignment.
>
> Detected by CoverityScan, CID#1463042 ("Unused Value")
>
Happy to see Coverity working for us :)
This should have had a:
Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 2914618a0335..bab2eca5fcac 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
> INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);
>
> msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
> - msg_body.min_ch_time = 30;
> msg_body.min_ch_time = 100;
But I strongly suspect the second line is supposed to be max_ch_time.
@Loic, do you agree?
Regards,
Bjorn
next prev parent reply other threads:[~2017-12-26 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 17:04 [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time Colin King
2017-12-26 20:13 ` Bjorn Andersson [this message]
2017-12-26 20:13 ` Bjorn Andersson
2017-12-29 7:44 ` Loic Poulain
2017-12-29 7:44 ` Loic Poulain
2017-12-29 10:52 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171226201312.GA7480@builder \
--to=bjorn.andersson@linaro.org \
--cc=colin.king@canonical.com \
--cc=k.eugene.e@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.