* Re: [PATCH] drivers: Adding driver support for "One by Wacom CTL472/672" (parameters transferred from CTL471/671 since only difference is the force resolution)
2017-10-11 13:24 ` [PATCH] drivers: Adding driver support for "One by Wacom CTL472/672" (parameters transferred from CTL471/671 since only difference is the force resolution) Jiri Kosina
@ 2017-10-11 15:11 ` Jason Gerecke
2017-12-26 23:50 ` [PATCH] Add support for One by Wacom (CTL-472 / CTL-672) Jason Gerecke
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gerecke @ 2017-10-11 15:11 UTC (permalink / raw)
To: Jiri Kosina, ? ??
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Ping Cheng, Jason Gerecke
On Wed, Oct 11, 2017 at 6:24 AM, Jiri Kosina <jikos@kernel.org> wrote:
> On Sun, 8 Oct 2017, ? ?? wrote:
>
>> Signed-off-by: Mx Jing <jingmingxuan@outlook.com>
>
> Changelog is missing, please provide one.
>
> Adding Jason and Ping to CC.
>
A few inline nits:
>> ---
>> drivers/hid/wacom_wac.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
>> index aa692e28b2cd..920f3d6bbc71 100644
>> --- a/drivers/hid/wacom_wac.c
>> +++ b/drivers/hid/wacom_wac.c
>> @@ -4376,6 +4376,12 @@ static const struct wacom_features wacom_features_0x360 =
>> static const struct wacom_features wacom_features_0x361 =
>> { "Wacom Intuos Pro L", 62200, 43200, 8191, 63,
>> INTUOSP2_BT, WACOM_INTUOS3_RES, WACOM_INTUOS3_RES, 9, .touch_max = 10 };
>> +static const struct wacom_features wacom_features_0x37A =
>> + { "One by Wacom CTL472", 14720, 9225, 2047, 63,
Replace "CTL472" in name with "S". Resolution should be 15200 x 9500,
not 14720 x 9225.
>> + BAMBOO_PEN, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>> +static const struct wacom_features wacom_features_0x37B =
>> + { "One by Wacom CTL672", 21648, 13530, 2047, 63,
Replace "CTL672" in name with "M". Resolution should be 21600 x 13500,
not 21648 x 13530.
>> + BAMBOO_PEN, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>>
Nits aside, this seems reasonable:
Acked-by: Jason Gerecke <jason.gerecke@wacom.com>
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
>> static const struct wacom_features wacom_features_HID_ANY_ID =
>> { "Wacom HID", .type = HID_GENERIC, .oVid = HID_ANY_ID, .oPid = HID_ANY_ID };
>> @@ -4544,6 +4550,8 @@ const struct hid_device_id wacom_ids[] = {
>> { USB_DEVICE_WACOM(0x343) },
>> { BT_DEVICE_WACOM(0x360) },
>> { BT_DEVICE_WACOM(0x361) },
>> + { USB_DEVICE_WACOM(0x37A) },
>> + { USB_DEVICE_WACOM(0x37B) },
>> { USB_DEVICE_WACOM(0x4001) },
>> { USB_DEVICE_WACOM(0x4004) },
>> { USB_DEVICE_WACOM(0x5000) },
>> --
>> 2.11.0
>>
>
> --
> Jiri Kosina
> SUSE Labs
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Add support for One by Wacom (CTL-472 / CTL-672)
2017-10-11 13:24 ` [PATCH] drivers: Adding driver support for "One by Wacom CTL472/672" (parameters transferred from CTL471/671 since only difference is the force resolution) Jiri Kosina
2017-10-11 15:11 ` Jason Gerecke
@ 2017-12-26 23:50 ` Jason Gerecke
2018-01-23 14:44 ` Jiri Kosina
1 sibling, 1 reply; 4+ messages in thread
From: Jason Gerecke @ 2017-12-26 23:50 UTC (permalink / raw)
To: linux-input, Jiri Kosina, Mx Jing
Cc: Ping Cheng, Aaron Skomra, Jason Gerecke, Jason Gerecke
Adds support for the second-generation "One by Wacom" tablets. These
devices are similar to the last generation, but a slightly different size
and reporting a higher number of pressure levels.
Signed-off-by: Mx Jing <jingmingxuan@outlook.com>
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
drivers/hid/wacom_wac.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index aa692e28b2cd..5f932ddcdc49 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -4376,6 +4376,12 @@ static const struct wacom_features wacom_features_0x360 =
static const struct wacom_features wacom_features_0x361 =
{ "Wacom Intuos Pro L", 62200, 43200, 8191, 63,
INTUOSP2_BT, WACOM_INTUOS3_RES, WACOM_INTUOS3_RES, 9, .touch_max = 10 };
+static const struct wacom_features wacom_features_0x37A =
+ { "Wacom One by Wacom S", 15200, 9500, 2047, 63,
+ BAMBOO_PEN, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
+static const struct wacom_features wacom_features_0x37B =
+ { "Wacom One by Wacom M", 21600, 13500, 2047, 63,
+ BAMBOO_PEN, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
static const struct wacom_features wacom_features_HID_ANY_ID =
{ "Wacom HID", .type = HID_GENERIC, .oVid = HID_ANY_ID, .oPid = HID_ANY_ID };
@@ -4544,6 +4550,8 @@ const struct hid_device_id wacom_ids[] = {
{ USB_DEVICE_WACOM(0x343) },
{ BT_DEVICE_WACOM(0x360) },
{ BT_DEVICE_WACOM(0x361) },
+ { USB_DEVICE_WACOM(0x37A) },
+ { USB_DEVICE_WACOM(0x37B) },
{ USB_DEVICE_WACOM(0x4001) },
{ USB_DEVICE_WACOM(0x4004) },
{ USB_DEVICE_WACOM(0x5000) },
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread