All of lore.kernel.org
 help / color / mirror / Atom feed
From: JI-HUN KIM <jihuun.k@gmail.com>
To: samuel@sortiz.org
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
	shreeya.patel23498@gmail.com, netdev@vger.kernel.org,
	devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] staging: irda: separate multiple assignments
Date: Wed, 27 Dec 2017 05:55:16 +0000	[thread overview]
Message-ID: <20171227055512.GA32731@MacBook-Air> (raw)

Clean up checkpatch warning:
CHECK: multiple assignments should be avoided

Signed-off-by: JI-HUN KIM <jihuun.k@gmail.com>
---
 drivers/staging/irda/drivers/esi-sir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/irda/drivers/esi-sir.c b/drivers/staging/irda/drivers/esi-sir.c
index 00866a3..01097f1 100644
--- a/drivers/staging/irda/drivers/esi-sir.c
+++ b/drivers/staging/irda/drivers/esi-sir.c
@@ -104,7 +104,8 @@ static int esi_change_speed(struct sir_dev *dev, unsigned int speed)
 		rts = FALSE;
 		break;
 	case 115200:
-		dtr = rts = TRUE;
+		dtr = TRUE;
+		rts = TRUE;
 		break;
 	default:
 		ret = -EINVAL;
-- 
2.10.1 (Apple Git-78)


WARNING: multiple messages have this Message-ID (diff)
From: JI-HUN KIM <jihuun.k@gmail.com>
To: samuel@sortiz.org
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
	shreeya.patel23498@gmail.com, netdev@vger.kernel.org,
	devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] staging: irda: separate multiple assignments
Date: Tue, 26 Dec 2017 21:55:16 -0800	[thread overview]
Message-ID: <20171227055512.GA32731@MacBook-Air> (raw)

Clean up checkpatch warning:
CHECK: multiple assignments should be avoided

Signed-off-by: JI-HUN KIM <jihuun.k@gmail.com>
---
 drivers/staging/irda/drivers/esi-sir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/irda/drivers/esi-sir.c b/drivers/staging/irda/drivers/esi-sir.c
index 00866a3..01097f1 100644
--- a/drivers/staging/irda/drivers/esi-sir.c
+++ b/drivers/staging/irda/drivers/esi-sir.c
@@ -104,7 +104,8 @@ static int esi_change_speed(struct sir_dev *dev, unsigned int speed)
 		rts = FALSE;
 		break;
 	case 115200:
-		dtr = rts = TRUE;
+		dtr = TRUE;
+		rts = TRUE;
 		break;
 	default:
 		ret = -EINVAL;
-- 
2.10.1 (Apple Git-78)

             reply	other threads:[~2017-12-27  5:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-27  5:55 JI-HUN KIM [this message]
2017-12-27  5:55 ` [PATCH 3/3] staging: irda: separate multiple assignments JI-HUN KIM

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171227055512.GA32731@MacBook-Air \
    --to=jihuun.k@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=samuel@sortiz.org \
    --cc=shreeya.patel23498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.