All of lore.kernel.org
 help / color / mirror / Atom feed
From: van.freenix@gmail.com (Peng Fan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: multi_v7_defconfig: select CONFIG_RTC_DRV_SNVS
Date: Fri, 29 Dec 2017 08:39:56 +0800	[thread overview]
Message-ID: <20171229003956.GA17906@shlinux2> (raw)
In-Reply-To: <CAJKOXPcda4s-H=Ks5hby950Ecybj2yp_WQj4PNja2d_fn_eMrQ@mail.gmail.com>

On Thu, Dec 28, 2017 at 02:02:07PM +0100, Krzysztof Kozlowski wrote:
>On Thu, Dec 28, 2017 at 10:34 AM, Peng Fan <peng.fan@nxp.com> wrote:
>> Select CONFIG_RTC_DRV_SNVS for i.MX6 to use RTC to wakeup system
>> Patch generated with:
>>         make ARCH=arm multi_v7_defconfig
>>         select CONFIG_RTC_DRV_SNVS
>>         make savedefconfig
>
>No. You are doing hundreds of changes just to enable one option. There
>is no way to review this...
>
>Instead if you need to cleanup the defconfig, first do this in
>separate step without any other changes.
>
>Then send a patch adding necessary options.

ok. I'll use make ARCH=arm multi_v7_defconfig; make savedefconfig first
to cleanup the defconfig. Then use a new patch to select the option.

Thanks,
Peng.

>
>Best regards,
>Krzysztof

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <van.freenix@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Peng Fan <peng.fan@nxp.com>,
	arnd@arndb.de, linux@armlinux.org.uk, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>,
	Simon Horman <horms+renesas@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Rask Ingemann Lambertsen <rask@formelder.dk>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	Andy Gross <andy.gross@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>
Subject: Re: [PATCH 1/2] ARM: multi_v7_defconfig: select CONFIG_RTC_DRV_SNVS
Date: Fri, 29 Dec 2017 08:39:56 +0800	[thread overview]
Message-ID: <20171229003956.GA17906@shlinux2> (raw)
In-Reply-To: <CAJKOXPcda4s-H=Ks5hby950Ecybj2yp_WQj4PNja2d_fn_eMrQ@mail.gmail.com>

On Thu, Dec 28, 2017 at 02:02:07PM +0100, Krzysztof Kozlowski wrote:
>On Thu, Dec 28, 2017 at 10:34 AM, Peng Fan <peng.fan@nxp.com> wrote:
>> Select CONFIG_RTC_DRV_SNVS for i.MX6 to use RTC to wakeup system
>> Patch generated with:
>>         make ARCH=arm multi_v7_defconfig
>>         select CONFIG_RTC_DRV_SNVS
>>         make savedefconfig
>
>No. You are doing hundreds of changes just to enable one option. There
>is no way to review this...
>
>Instead if you need to cleanup the defconfig, first do this in
>separate step without any other changes.
>
>Then send a patch adding necessary options.

ok. I'll use make ARCH=arm multi_v7_defconfig; make savedefconfig first
to cleanup the defconfig. Then use a new patch to select the option.

Thanks,
Peng.

>
>Best regards,
>Krzysztof

-- 

  reply	other threads:[~2017-12-29  0:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28  9:34 [PATCH 1/2] ARM: multi_v7_defconfig: select CONFIG_RTC_DRV_SNVS Peng Fan
2017-12-28  9:34 ` Peng Fan
2017-12-28  9:34 ` [PATCH 2/2] ARM: multi_v7_defconfig: Enable OP-TEE Peng Fan
2017-12-28  9:34   ` Peng Fan
2017-12-28 13:03   ` Krzysztof Kozlowski
2017-12-28 13:03     ` Krzysztof Kozlowski
2017-12-29  0:50     ` Peng Fan
2017-12-29  0:50       ` Peng Fan
2017-12-28 13:02 ` [PATCH 1/2] ARM: multi_v7_defconfig: select CONFIG_RTC_DRV_SNVS Krzysztof Kozlowski
2017-12-28 13:02   ` Krzysztof Kozlowski
2017-12-29  0:39   ` Peng Fan [this message]
2017-12-29  0:39     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171229003956.GA17906@shlinux2 \
    --to=van.freenix@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.