From: Jonathan Cameron <jic23@kernel.org>
To: venkat.prashanth2498@gmail.com
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/4] Drivers:iio:adc: else is not generally useful after a break or return
Date: Fri, 29 Dec 2017 17:55:47 +0000 [thread overview]
Message-ID: <20171229175547.206795de@archlinux> (raw)
In-Reply-To: <1514566389-3485-1-git-send-email-venkat.prashanth2498@gmail.com>
On Fri, 29 Dec 2017 22:23:09 +0530
venkat.prashanth2498@gmail.com wrote:
> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
>
> Fixes checkpatch warnings:
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Please then run checkpatch on the result + ideally sparse / smatch.
The result of this is wrong indentation.
Jonathan
> ---
> drivers/iio/adc/at91_adc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 7b40925..da18c04 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -939,7 +939,6 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
> /* Check if touchscreen is supported. */
> if (st->caps->has_ts)
> return at91_adc_probe_dt_ts(node, st, &idev->dev);
> - else
> dev_info(&idev->dev, "not support touchscreen in the adc compatible string.\n");
>
> return 0;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-12-29 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 16:53 [PATCH 4/4] Drivers:iio:adc: else is not generally useful after a break or return venkat.prashanth2498
2017-12-29 17:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229175547.206795de@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=venkat.prashanth2498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.