* [PATCH 4/4] Drivers:iio:adc: else is not generally useful after a break or return
@ 2017-12-29 16:53 venkat.prashanth2498
2017-12-29 17:55 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: venkat.prashanth2498 @ 2017-12-29 16:53 UTC (permalink / raw)
To: lars, jic23, Michael.Hennerich
Cc: knaack.h, pmeerw, linux-iio, Venkat Prashanth B U
From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Fixes checkpatch warnings:
WARNING: else is not generally useful after a break or return
Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
---
drivers/iio/adc/at91_adc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 7b40925..da18c04 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -939,7 +939,6 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
/* Check if touchscreen is supported. */
if (st->caps->has_ts)
return at91_adc_probe_dt_ts(node, st, &idev->dev);
- else
dev_info(&idev->dev, "not support touchscreen in the adc compatible string.\n");
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] Drivers:iio:adc: else is not generally useful after a break or return
2017-12-29 16:53 [PATCH 4/4] Drivers:iio:adc: else is not generally useful after a break or return venkat.prashanth2498
@ 2017-12-29 17:55 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-12-29 17:55 UTC (permalink / raw)
To: venkat.prashanth2498; +Cc: lars, Michael.Hennerich, knaack.h, pmeerw, linux-iio
On Fri, 29 Dec 2017 22:23:09 +0530
venkat.prashanth2498@gmail.com wrote:
> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
>
> Fixes checkpatch warnings:
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Please then run checkpatch on the result + ideally sparse / smatch.
The result of this is wrong indentation.
Jonathan
> ---
> drivers/iio/adc/at91_adc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 7b40925..da18c04 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -939,7 +939,6 @@ static int at91_adc_probe_dt(struct at91_adc_state *st,
> /* Check if touchscreen is supported. */
> if (st->caps->has_ts)
> return at91_adc_probe_dt_ts(node, st, &idev->dev);
> - else
> dev_info(&idev->dev, "not support touchscreen in the adc compatible string.\n");
>
> return 0;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-29 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-29 16:53 [PATCH 4/4] Drivers:iio:adc: else is not generally useful after a break or return venkat.prashanth2498
2017-12-29 17:55 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.