From: Mario Lang <mlang@blind.guru>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/brltty: use gcc instead of ld to link shared objects
Date: Sat, 30 Dec 2017 11:48:03 +0100 [thread overview]
Message-ID: <20171230104804.16489-2-mlang@blind.guru> (raw)
In-Reply-To: <20171230104804.16489-1-mlang@blind.guru>
Fixes:
http://autobuild.buildroot.net/results/2419741c43dea0f91859c19167c8d65cb54e1470
http://autobuild.buildroot.net/results/4b83e53c718520661dc99cde2121f69ce3fd08d7
Signed-off-by: Mario Lang <mlang@blind.guru>
---
.../0003-Remove-MKOBJ-in-favour-of-MKMOD.patch | 63 ++++++++++++++++++++++
1 file changed, 63 insertions(+)
create mode 100644 package/brltty/0003-Remove-MKOBJ-in-favour-of-MKMOD.patch
diff --git a/package/brltty/0003-Remove-MKOBJ-in-favour-of-MKMOD.patch b/package/brltty/0003-Remove-MKOBJ-in-favour-of-MKMOD.patch
new file mode 100644
index 0000000000..d836652850
--- /dev/null
+++ b/package/brltty/0003-Remove-MKOBJ-in-favour-of-MKMOD.patch
@@ -0,0 +1,63 @@
+From b3b0e47015e9162f519730789976157c7cc38178 Mon Sep 17 00:00:00 2001
+From: Mario Lang <mlang@delysid.org>
+Date: Fri, 29 Dec 2017 14:52:37 +0100
+Subject: [PATCH] Remove MKOBJ in favour of MKMOD. (ml)
+
+Calling ld directly can lead to problems when cross-compiling.
+
+Signed-off-by: Mario Lang <mlang@blind.guru>
+---
+ Drivers/Braille/EuroBraille/Makefile.in | 2 +-
+ config.mk.in | 1 -
+ configure.ac | 10 ----------
+ 3 files changed, 1 insertion(+), 12 deletions(-)
+
+diff --git a/Drivers/Braille/EuroBraille/Makefile.in b/Drivers/Braille/EuroBraille/Makefile.in
+index 0500aa70e..ce8a3d1a4 100644
+--- a/Drivers/Braille/EuroBraille/Makefile.in
++++ b/Drivers/Braille/EuroBraille/Makefile.in
+@@ -28,7 +28,7 @@ SRC_FILES = eu_braille.c eu_clio.c eu_esysiris.c
+ OBJ_FILES = $(SRC_FILES:.c=.$O)
+
+ braille.$O: $(OBJ_FILES)
+- $(MKOBJ) $@ $(OBJ_FILES)
++ $(MKMOD) $@ $(OBJ_FILES)
+
+ %.$O: $(SRC_DIR)/%.c
+ $(CC) $(BRL_CFLAGS) -o $@ -c $<
+diff --git a/config.mk.in b/config.mk.in
+index 686f547e6..8d1da79b4 100644
+--- a/config.mk.in
++++ b/config.mk.in
+@@ -250,7 +250,6 @@ LD = @LD@
+ LDFLAGS = @LDFLAGS@
+ LDLIBS = $(ICU_LIBS) $(POLKIT_LIBS) $(SYSTEM_LIBS) @LIBS@
+
+-MKOBJ = @MKOBJ@
+ MKMOD = @MKMOD@
+ MKLIB = @MKLIB@
+ CONFLIBDIR = @CONFLIBDIR@
+diff --git a/configure.ac b/configure.ac
+index 07119dd9f..ad80b8d60 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -428,16 +428,6 @@ AC_SUBST([can_make_manual])
+ test "${DOXYGEN}" = "false" && can_make_BrlAPIref=no || can_make_BrlAPIref=yes
+ AC_SUBST([can_make_BrlAPIref])
+
+-AC_CACHE_CHECK([for make relocatable object command], [brltty_cv_prog_mkobj], [dnl
+-case "${host_os}"
+-in
+- *)
+- brltty_cv_prog_mkobj="\$(LD) -r -o"
+- ;;
+-esac])
+-MKOBJ="${brltty_cv_prog_mkobj}"
+-AC_SUBST([MKOBJ])
+-
+ AC_CACHE_CHECK([for loadable module creation command], [brltty_cv_prog_mkmod], [dnl
+ case "${host_os}"
+ in
+--
+2.15.0
+
--
2.15.0
next prev parent reply other threads:[~2017-12-30 10:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 10:48 [Buildroot] [PATCH 1/3] package/brltty: add missing dependency on host-pkgconf Mario Lang
2017-12-30 10:48 ` Mario Lang [this message]
2017-12-30 13:07 ` [Buildroot] [PATCH 2/3] package/brltty: use gcc instead of ld to link shared objects Yann E. MORIN
2017-12-30 14:32 ` Mario Lang
2017-12-30 14:43 ` Yann E. MORIN
2017-12-30 17:27 ` Thomas Petazzoni
2017-12-30 10:48 ` [Buildroot] [PATCH 3/3] package/brltty: depends on !BR2_STATIC_LIBS Mario Lang
2017-12-30 13:08 ` Yann E. MORIN
2017-12-30 12:22 ` [Buildroot] [PATCH 1/3] package/brltty: add missing dependency on host-pkgconf Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171230104804.16489-2-mlang@blind.guru \
--to=mlang@blind.guru \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.