All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/brltty: use gcc instead of ld to link shared objects
Date: Sat, 30 Dec 2017 15:43:15 +0100	[thread overview]
Message-ID: <20171230144315.GF2921@scaer> (raw)
In-Reply-To: <87o9mg1e37.fsf@home.blind.guru>

Mario, All,

On 2017-12-30 15:32 +0100, Mario Lang spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> writes:
> > Since this is a backport of an upstream commit, we like to have a
> > pointer to the upstream commit:
> >     https://github.com/brltty/brltty/commit/4c8aba42e246b96d10ffcbd57653682375499e46
> OK, sorry.  Was not aware of that.  Can you add this to the commit log,
> or should I resend the patch?
[--SNIP--]
> > Also, since you are patching configure.ac, you must autoreconf:
> >     BRLTTY_AUTORECONF = YES
[--SNIP--]
> We already do the equivalent of autoreconf.  BRLTTY_AUTORECONF = YES
> does not work with BRLTTY, as BRLTTY is a autoconf-only package.  Please
> see the comment added by Thomas in brltty.mk:

Ah, I did not have an up-to-date master branch. I pulled and now I can
see it, indeed.

So, since we already need to autoconf, we can keep your patch as-is.

I guess whoever applies your patch can add the URL to the patch commit
log, yes, so I would say no need to resend.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-12-30 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30 10:48 [Buildroot] [PATCH 1/3] package/brltty: add missing dependency on host-pkgconf Mario Lang
2017-12-30 10:48 ` [Buildroot] [PATCH 2/3] package/brltty: use gcc instead of ld to link shared objects Mario Lang
2017-12-30 13:07   ` Yann E. MORIN
2017-12-30 14:32     ` Mario Lang
2017-12-30 14:43       ` Yann E. MORIN [this message]
2017-12-30 17:27   ` Thomas Petazzoni
2017-12-30 10:48 ` [Buildroot] [PATCH 3/3] package/brltty: depends on !BR2_STATIC_LIBS Mario Lang
2017-12-30 13:08   ` Yann E. MORIN
2017-12-30 12:22 ` [Buildroot] [PATCH 1/3] package/brltty: add missing dependency on host-pkgconf Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171230144315.GF2921@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.