* Re: misc: bh1770glc: move sysfs interace to Documentation/ABI
@ 2018-01-02 13:06 ` Pavel Machek
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2018-01-02 13:06 UTC (permalink / raw)
To: Aishwarya Pant, pali.rohar, sre, kernel list, linux-arm-kernel,
linux-omap, tony, khilman, aaro.koskinen, ivo.g.dimitrov.75,
patrikbachan, serge, abcloriens, clayton, martijn, sakari.ailus,
Filip Matijević
Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel, Samu Onkalo,
julia.lawall, Jonathan Corbet
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
Hi!
> In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
> interface which could be moved to Documentation/ABI.
>
> Would such a change be useful?
Not at the moment.
> The ABI documentation format looks like the following:
>
> What: (the full sysfs path of the attribute)
> Date: (date of creation)
> KernelVersion: (kernel version it first showed up in)
> Contact: (primary contact)
> Description: (long description on usage)
>
> I am doing this in an exercise to move sysfs ABI interfaces (which are
> documented) to their right place i.e. in Documentation/ABI along with the rest.
The interface should probably be changed to iio one, to be consistent
with other sensors such as Apds990x.
If you have the hardware, help would be welcome.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* misc: bh1770glc: move sysfs interace to Documentation/ABI
@ 2018-01-02 13:06 ` Pavel Machek
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2018-01-02 13:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi!
> In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
> interface which could be moved to Documentation/ABI.
>
> Would such a change be useful?
Not at the moment.
> The ABI documentation format looks like the following:
>
> What: (the full sysfs path of the attribute)
> Date: (date of creation)
> KernelVersion: (kernel version it first showed up in)
> Contact: (primary contact)
> Description: (long description on usage)
>
> I am doing this in an exercise to move sysfs ABI interfaces (which are
> documented) to their right place i.e. in Documentation/ABI along with the rest.
The interface should probably be changed to iio one, to be consistent
with other sensors such as Apds990x.
If you have the hardware, help would be welcome.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180102/20ffcbb1/attachment-0001.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: misc: bh1770glc: move sysfs interace to Documentation/ABI
2018-01-02 13:06 ` Pavel Machek
@ 2018-01-02 17:25 ` Aishwarya Pant
-1 siblings, 0 replies; 6+ messages in thread
From: Aishwarya Pant @ 2018-01-02 17:25 UTC (permalink / raw)
To: Pavel Machek
Cc: pali.rohar, sre, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, ivo.g.dimitrov.75, patrikbachan, serge,
abcloriens, clayton, martijn, sakari.ailus, Filip Matijević,
Arnd Bergmann, Greg Kroah-Hartman, Samu Onkalo, julia.lawall,
Jonathan Corbet
On Tue, Jan 02, 2018 at 02:06:36PM +0100, Pavel Machek wrote:
> Hi!
>
> > In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
> > interface which could be moved to Documentation/ABI.
> >
> > Would such a change be useful?
>
> Not at the moment.
>
> > The ABI documentation format looks like the following:
> >
> > What: (the full sysfs path of the attribute)
> > Date: (date of creation)
> > KernelVersion: (kernel version it first showed up in)
> > Contact: (primary contact)
> > Description: (long description on usage)
> >
> > I am doing this in an exercise to move sysfs ABI interfaces (which are
> > documented) to their right place i.e. in Documentation/ABI along with the rest.
>
> The interface should probably be changed to iio one, to be consistent
> with other sensors such as Apds990x.
>
> If you have the hardware, help would be welcome.
Yes, makes sense for this driver to be with the iio light sensors. I don't have
the hardware for it. So, I won't move the sysfs interface to ABI.
Aishwarya
>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* misc: bh1770glc: move sysfs interace to Documentation/ABI
@ 2018-01-02 17:25 ` Aishwarya Pant
0 siblings, 0 replies; 6+ messages in thread
From: Aishwarya Pant @ 2018-01-02 17:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 02, 2018 at 02:06:36PM +0100, Pavel Machek wrote:
> Hi!
>
> > In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
> > interface which could be moved to Documentation/ABI.
> >
> > Would such a change be useful?
>
> Not at the moment.
>
> > The ABI documentation format looks like the following:
> >
> > What: (the full sysfs path of the attribute)
> > Date: (date of creation)
> > KernelVersion: (kernel version it first showed up in)
> > Contact: (primary contact)
> > Description: (long description on usage)
> >
> > I am doing this in an exercise to move sysfs ABI interfaces (which are
> > documented) to their right place i.e. in Documentation/ABI along with the rest.
>
> The interface should probably be changed to iio one, to be consistent
> with other sensors such as Apds990x.
>
> If you have the hardware, help would be welcome.
Yes, makes sense for this driver to be with the iio light sensors. I don't have
the hardware for it. So, I won't move the sysfs interface to ABI.
Aishwarya
>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 6+ messages in thread