From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Shaikh, Azhar" <azhar.shaikh@intel.com>
Cc: "jarkko.sakkinen@linux.intel.com"
<jarkko.sakkinen@linux.intel.com>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data
Date: Tue, 2 Jan 2018 07:57:35 -0700 [thread overview]
Message-ID: <20180102145735.GB29208@ziepe.ca> (raw)
In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF582898A05E@ORSMSX109.amr.corp.intel.com>
On Tue, Jan 02, 2018 at 05:31:30AM +0000, Shaikh, Azhar wrote:
> >>On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote:
> >>
> >>> - return tpm_chip_register(chip);
> >>> + rc = tpm_chip_register(chip);
> >>> + if (rc && is_bsw())
> >>> + iounmap(priv->ilb_base_addr);
> >>> +
> >>> + return rc;
> >>> out_err:
> >>> tpm_tis_remove(chip);
> >>> + if (is_bsw())
> >>> + iounmap(priv->ilb_base_addr);
> >>> +
> >>> return rc;
> >>> }
> >>
> >>I thought you were resending this to fix the above, why is is it still wonky?
> >>
> >
> >Oh! I fixed it in the second patch ("tpm: Keep CLKRUN enabled throughout
> >the duration of transmit_cmd()"). Should have fixed in this patch instead. My
> >bad, didn't see it was introduced in this patch. I thought it was part of second
> >patch. Will fix this.
> >
>
> On checking, the ops->clk_enable is not still introduced yet. It is introduced in the second patch. The cleanup is done in the next patch.
> So do you want me to still fix this here?
Try hard to not edit your own patches in your series. No reason why
iounmap cannot be put into tpm_tis_remove in the first place
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgg@ziepe.ca (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data
Date: Tue, 2 Jan 2018 07:57:35 -0700 [thread overview]
Message-ID: <20180102145735.GB29208@ziepe.ca> (raw)
In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF582898A05E@ORSMSX109.amr.corp.intel.com>
On Tue, Jan 02, 2018 at 05:31:30AM +0000, Shaikh, Azhar wrote:
> >>On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote:
> >>
> >>> - return tpm_chip_register(chip);
> >>> + rc = tpm_chip_register(chip);
> >>> + if (rc && is_bsw())
> >>> + iounmap(priv->ilb_base_addr);
> >>> +
> >>> + return rc;
> >>> out_err:
> >>> tpm_tis_remove(chip);
> >>> + if (is_bsw())
> >>> + iounmap(priv->ilb_base_addr);
> >>> +
> >>> return rc;
> >>> }
> >>
> >>I thought you were resending this to fix the above, why is is it still wonky?
> >>
> >
> >Oh! I fixed it in the second patch ("tpm: Keep CLKRUN enabled throughout
> >the duration of transmit_cmd()"). Should have fixed in this patch instead. My
> >bad, didn't see it was introduced in this patch. I thought it was part of second
> >patch. Will fix this.
> >
>
> On checking, the ops->clk_enable is not still introduced yet. It is introduced in the second patch. The cleanup is done in the next patch.
> So do you want me to still fix this here?
Try hard to not edit your own patches in your series. No reason why
iounmap cannot be put into tpm_tis_remove in the first place
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-02 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 4:05 [PATCH v8 0/2] Fix corner cases with disabling CLKRUN in tpm_tis Azhar Shaikh
2018-01-02 4:05 ` Azhar Shaikh
2018-01-02 4:05 ` [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data Azhar Shaikh
2018-01-02 4:05 ` Azhar Shaikh
2018-01-02 4:40 ` Jason Gunthorpe
2018-01-02 4:40 ` Jason Gunthorpe
2018-01-02 5:01 ` Shaikh, Azhar
2018-01-02 5:01 ` Shaikh, Azhar
2018-01-02 5:31 ` Shaikh, Azhar
2018-01-02 5:31 ` Shaikh, Azhar
2018-01-02 14:57 ` Jason Gunthorpe [this message]
2018-01-02 14:57 ` Jason Gunthorpe
2018-01-02 4:05 ` [PATCH v8 2/2] tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd() Azhar Shaikh
2018-01-02 4:05 ` Azhar Shaikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102145735.GB29208@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=azhar.shaikh@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.