From: Erick Chen <erick.chen@spreadtrum.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
Baolin Wang <baolin.wang@spreadtrum.com>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE
Date: Wed, 3 Jan 2018 14:32:52 +0800 [thread overview]
Message-ID: <20180103063251.GA16439@spreadtrum.com> (raw)
In-Reply-To: <20180101123850.21936-1-axel.lin@ingics.com>
Hi Axel,
On 一, 1月 01, 2018 at 08:38:50下午 +0800, Axel Lin wrote:
> The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes
> regmap_write() call looks strange because it takes reg parameter fist
> then val.
> Base on Erick's suggestion to define SC2731_PWR_WR_PROT and
> SC2731_WR_UNLOCK_VALUE instead.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Erick Chen <erick.chen@spreadtrum.com>
>
next prev parent reply other threads:[~2018-01-03 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 12:38 [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE Axel Lin
2018-01-03 6:32 ` Erick Chen [this message]
2018-01-03 12:13 ` Applied "regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103063251.GA16439@spreadtrum.com \
--to=erick.chen@spreadtrum.com \
--cc=axel.lin@ingics.com \
--cc=baolin.wang@spreadtrum.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.