* [PATCH -next] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()
@ 2018-01-04 6:31 Wei Yongjun
2018-01-05 14:06 ` Alban
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-01-04 6:31 UTC (permalink / raw)
To: Alban Bedel, Linus Walleij; +Cc: Wei Yongjun, linux-gpio
platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpio/gpio-ath79.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index a757171..0bebcba 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -258,6 +258,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -EINVAL;
ctrl->base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!ctrl->base)
return -ENOMEM;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()
2018-01-04 6:31 [PATCH -next] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe() Wei Yongjun
@ 2018-01-05 14:06 ` Alban
0 siblings, 0 replies; 2+ messages in thread
From: Alban @ 2018-01-05 14:06 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Aban Bedel, Linus Walleij, linux-gpio
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Thu, 4 Jan 2018 06:31:23 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> platform_get_resource() may return NULL, add proper
> check to avoid potential NULL dereferencing.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = platform_get_resource(pdev, t, n);
> + if (!res)
> + return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpio/gpio-ath79.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index a757171..0bebcba 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -258,6 +258,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res)
> + return -EINVAL;
> ctrl->base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> if (!ctrl->base)
> return -ENOMEM;
This fix is needed, however this patch is not against the current
version. The current version use res in a call to devm_ioremap_nocache()
and not devm_ioremap().
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-05 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-04 6:31 [PATCH -next] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe() Wei Yongjun
2018-01-05 14:06 ` Alban
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.