From: Miquel RAYNAL <miquel.raynal@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Han Xu <han.xu@nxp.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: nand: Check ONFI timings have been acked by the chip
Date: Fri, 5 Jan 2018 16:42:39 +0100 [thread overview]
Message-ID: <20180105164239.79d7980c@xps13> (raw)
In-Reply-To: <20180105161321.44218e4e@bbrezillon>
Hello,
> Hm, I'm not sure this is safe. The spec says that new ONFI timing mode
> is applied as soon the CS line is released after a
> SET_FEATURES(ONFI_FEATURE_ADDR_TIMING_MODE), and since we have no
> guarantee that the CS will be kept low by the controller after
> ->onfi_set_features() returns we must assume the new mode has been
> applied and call ->setup_data_interface() to instruct the controller
> to apply new timings.
>
> If you want to check if the mode has really been applied, you should
> release the CS (->select_chip(-1)), re-acquire it
> (->select_chip(X)), and call
> ->onfi_get_features(ONFI_FEATURE_ADDR_TIMING_MODE). If it appears
> that the mode has not been applied, you should restore timing mode 0
> and issue a RESET.
Boris, thanks for the comment, I will fix that.
Han, could I have your input on this series? Aside Boris' comment of
course.
Thank you very much,
Miquèl
next prev parent reply other threads:[~2018-01-05 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 17:28 [PATCH 0/2] Migrate the GPMI driver to use NAND core timings Miquel Raynal
2017-12-22 17:28 ` [PATCH 1/2] mtd: nand: Check ONFI timings have been acked by the chip Miquel Raynal
2018-01-05 15:13 ` Boris Brezillon
2018-01-05 15:42 ` Miquel RAYNAL [this message]
2018-01-08 13:04 ` Boris Brezillon
2018-01-15 13:19 ` Boris Brezillon
2018-01-15 17:57 ` Han Xu
2018-01-15 18:41 ` Boris Brezillon
2018-01-15 20:05 ` Miquel Raynal
2017-12-22 17:28 ` [PATCH 2/2] mtd: nand: gpmi: Support ->setup_data_interface() Miquel Raynal
2018-01-06 10:24 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105164239.79d7980c@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.