Re: [lkp-robot] [perf machine] 8edf8850d5: stderr./usr/src/linux-perf-x86_64-rhel-#/tools/perf/util/rb_resort.h:#:#:error:passing_argument#of'threads_sorted__new'from_incompatible_pointer_type[-Werror=incompatible-pointer-types]

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Davidlohr Bueso <dave@stgolabs.net>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [perf machine] 8edf8850d5: stderr./usr/src/linux-perf-x86_64-rhel-#/tools/perf/util/rb_resort.h:#:#:error:passing_argument#of'threads_sorted__new'from_incompatible_pointer_type[-Werror=incompatible-pointer-types]
Date: Fri, 05 Jan 2018 09:04:47 -0800	[thread overview]
Message-ID: <20180105170447.kcpuwmaspespxdv2@linux-n805> (raw)
In-Reply-To: <20180104055110.GC23834@yexl-desktop>

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

On Thu, 04 Jan 2018, kernel test robot wrote:

>[   68.830934] /usr/src/linux-perf-x86_64-rhel-7.2-8edf8850d51e911a35b5d7aad4f8604db11abc66/tools/perf/util/rb_resort.h:148:28: error: passing argument 1 of 'threads_sorted__new' from incompatible pointer type [-Werror=incompatible-pointer-types]

I didn't have libaudit so I wasn't building builtin-trace, which obviously needs fixed.

Arnaldo, dunno if you're taking this series, but please let me know if you want a v2 or
you can fold the below fix into this patch.

Thanks,
Davidlohr

diff --git a/tools/perf/util/rb_resort.h b/tools/perf/util/rb_resort.h
index a920f702a74d..aa7a63628d75 100644
--- a/tools/perf/util/rb_resort.h
+++ b/tools/perf/util/rb_resort.h
@@ -140,12 +140,12 @@ struct __name##_sorted *__name = __name##_sorted__new
 
 /* For 'struct intlist' */
 #define DECLARE_RESORT_RB_INTLIST(__name, __ilist)				\
-	DECLARE_RESORT_RB(__name)(&__ilist->rblist.entries,			\
+	DECLARE_RESORT_RB(__name)(&__ilist->rblist.entries.rb_root,		\
 				  __ilist->rblist.nr_entries)
 
 /* For 'struct machine->threads' */
 #define DECLARE_RESORT_RB_MACHINE_THREADS(__name, __machine, hash_bucket)	\
-	DECLARE_RESORT_RB(__name)(&__machine->threads[hash_bucket].entries,	\
+	DECLARE_RESORT_RB(__name)(&__machine->threads[hash_bucket].entries.rb_root,\
 				  __machine->threads[hash_bucket].nr)
 
 #endif /* _PERF_RESORT_RB_H_ */

WARNING: multiple messages have this Message-ID (diff)

From: Davidlohr Bueso <dave@stgolabs.net>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: acme@kernel.org, jolsa@redhat.com, ak@linux.intel.com,
	mingo@redhat.com, linux-kernel@vger.kernel.org,
	Davidlohr Bueso <dbueso@suse.de>,
	lkp@01.org
Subject: Re: [lkp-robot] [perf machine]  8edf8850d5: stderr./usr/src/linux-perf-x86_64-rhel-#/tools/perf/util/rb_resort.h:#:#:error:passing_argument#of'threads_sorted__new'from_incompatible_pointer_type[-Werror=incompatible-pointer-types]
Date: Fri, 5 Jan 2018 09:04:47 -0800	[thread overview]
Message-ID: <20180105170447.kcpuwmaspespxdv2@linux-n805> (raw)
In-Reply-To: <20180104055110.GC23834@yexl-desktop>

On Thu, 04 Jan 2018, kernel test robot wrote:

>[   68.830934] /usr/src/linux-perf-x86_64-rhel-7.2-8edf8850d51e911a35b5d7aad4f8604db11abc66/tools/perf/util/rb_resort.h:148:28: error: passing argument 1 of 'threads_sorted__new' from incompatible pointer type [-Werror=incompatible-pointer-types]

I didn't have libaudit so I wasn't building builtin-trace, which obviously needs fixed.

Arnaldo, dunno if you're taking this series, but please let me know if you want a v2 or
you can fold the below fix into this patch.

Thanks,
Davidlohr

diff --git a/tools/perf/util/rb_resort.h b/tools/perf/util/rb_resort.h
index a920f702a74d..aa7a63628d75 100644
--- a/tools/perf/util/rb_resort.h
+++ b/tools/perf/util/rb_resort.h
@@ -140,12 +140,12 @@ struct __name##_sorted *__name = __name##_sorted__new
 
 /* For 'struct intlist' */
 #define DECLARE_RESORT_RB_INTLIST(__name, __ilist)				\
-	DECLARE_RESORT_RB(__name)(&__ilist->rblist.entries,			\
+	DECLARE_RESORT_RB(__name)(&__ilist->rblist.entries.rb_root,		\
 				  __ilist->rblist.nr_entries)
 
 /* For 'struct machine->threads' */
 #define DECLARE_RESORT_RB_MACHINE_THREADS(__name, __machine, hash_bucket)	\
-	DECLARE_RESORT_RB(__name)(&__machine->threads[hash_bucket].entries,	\
+	DECLARE_RESORT_RB(__name)(&__machine->threads[hash_bucket].entries.rb_root,\
 				  __machine->threads[hash_bucket].nr)
 
 #endif /* _PERF_RESORT_RB_H_ */

next prev parent reply	other threads:[~2018-01-05 17:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27  2:30 [PATCH -tip 0/7] tools/perf: Update rbtree implementation and optimize users Davidlohr Bueso
2017-11-27  2:30 ` [PATCH 1/7] tools/perf: Update rbtree implementation Davidlohr Bueso
2017-11-27  2:30 ` [PATCH 2/7] perf machine: Use cached rbtrees Davidlohr Bueso
2018-01-04  5:51   ` [lkp-robot] [perf machine] 8edf8850d5: stderr./usr/src/linux-perf-x86_64-rhel-#/tools/perf/util/rb_resort.h:#:#:error:passing_argument#of'threads_sorted__new'from_incompatible_pointer_type[-Werror=incompatible-pointer-types] kernel test robot
2018-01-04  5:51     ` kernel test robot
2018-01-05 17:04     ` Davidlohr Bueso [this message]
2018-01-05 17:04       ` Davidlohr Bueso
2017-11-27  2:30 ` [PATCH 3/7] perf callchain: Use cached rbtrees Davidlohr Bueso
2017-11-27  2:30 ` [PATCH 4/7] perf util: Use cached rbtree for rblists Davidlohr Bueso
2018-01-30  2:41   ` [lkp-robot] [perf util] f7a7a64385: stderr.builtin-trace.c:#:#:note:in_expansion_of_macro'DECLARE_RESORT_RB_INTLIST' kernel test robot
2017-11-27  2:30 ` [PATCH 5/7] perf symbols: Use cached rbtrees Davidlohr Bueso
2017-11-27  2:30 ` [PATCH 6/7] perf hist: " Davidlohr Bueso
2017-11-27  2:30 ` [PATCH 7/7] perf sched: " Davidlohr Bueso
2017-11-27  6:06 ` [PATCH -tip 0/7] tools/perf: Update rbtree implementation and optimize users Andi Kleen
2017-11-27 16:14   ` Davidlohr Bueso
2017-11-27 17:14     ` Arnaldo Carvalho de Melo

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:a920f702a74 dfblob:aa7a63628d7 dfblob:a920f702a74
dfblob:aa7a63628d7 )
 OR (
bs:"Re: [lkp-robot] [perf machine]  8edf8850d5: stderr./usr/src/linux-perf-x86_64-rhel-#/tools/perf/util/rb_resort.h:#:#:error:passing_argument#of'threads_sorted__new'from_incompatible_pointer_type[-Werror=incompatible-pointer-types]" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105170447.kcpuwmaspespxdv2@linux-n805 \
    --to=dave@stgolabs.net \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.