* [PATCH] gyro:adis16136: fix debugfs_simple_attr.cocci warnings
@ 2018-01-07 9:01 venkat.prashanth2498
2018-01-07 16:37 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: venkat.prashanth2498 @ 2018-01-07 9:01 UTC (permalink / raw)
To: lars, Michael.Hennerich, jic23
Cc: knaack.h, pmeerw, linux-iio, Venkat Prashanth B U
From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
---
drivers/iio/gyro/adis16136.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c
index 90ec4be..fcd4d61 100644
--- a/drivers/iio/gyro/adis16136.c
+++ b/drivers/iio/gyro/adis16136.c
@@ -124,7 +124,7 @@ static int adis16136_show_product_id(void *arg, u64 *val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(adis16136_product_id_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(adis16136_product_id_fops,
adis16136_show_product_id, NULL, "%llu\n");
static int adis16136_show_flash_count(void *arg, u64 *val)
@@ -142,18 +142,21 @@ static int adis16136_show_flash_count(void *arg, u64 *val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(adis16136_flash_count_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(adis16136_flash_count_fops,
adis16136_show_flash_count, NULL, "%lld\n");
static int adis16136_debugfs_init(struct iio_dev *indio_dev)
{
struct adis16136 *adis16136 = iio_priv(indio_dev);
- debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry,
- adis16136, &adis16136_serial_fops);
- debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry,
+ debugfs_create_file_unsafe("serial_number", 0400,
+ indio_dev->debugfs_dentry, adis16136,
+ &adis16136_serial_fops);
+ debugfs_create_file_unsafe("product_id", 0400,
+ indio_dev->debugfs_dentry,
adis16136, &adis16136_product_id_fops);
- debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry,
+ debugfs_create_file_unsafe("flash_count", 0400,
+ indio_dev->debugfs_dentry,
adis16136, &adis16136_flash_count_fops);
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gyro:adis16136: fix debugfs_simple_attr.cocci warnings
2018-01-07 9:01 [PATCH] gyro:adis16136: fix debugfs_simple_attr.cocci warnings venkat.prashanth2498
@ 2018-01-07 16:37 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-01-07 16:37 UTC (permalink / raw)
To: venkat.prashanth2498; +Cc: lars, Michael.Hennerich, knaack.h, pmeerw, linux-iio
On Sun, 7 Jan 2018 14:31:57 +0530
venkat.prashanth2498@gmail.com wrote:
> From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
>
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/gyro/adis16136.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c
> index 90ec4be..fcd4d61 100644
> --- a/drivers/iio/gyro/adis16136.c
> +++ b/drivers/iio/gyro/adis16136.c
> @@ -124,7 +124,7 @@ static int adis16136_show_product_id(void *arg, u64 *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16136_product_id_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16136_product_id_fops,
> adis16136_show_product_id, NULL, "%llu\n");
>
> static int adis16136_show_flash_count(void *arg, u64 *val)
> @@ -142,18 +142,21 @@ static int adis16136_show_flash_count(void *arg, u64 *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16136_flash_count_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16136_flash_count_fops,
> adis16136_show_flash_count, NULL, "%lld\n");
>
> static int adis16136_debugfs_init(struct iio_dev *indio_dev)
> {
> struct adis16136 *adis16136 = iio_priv(indio_dev);
>
> - debugfs_create_file("serial_number", 0400, indio_dev->debugfs_dentry,
> - adis16136, &adis16136_serial_fops);
> - debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry,
> + debugfs_create_file_unsafe("serial_number", 0400,
> + indio_dev->debugfs_dentry, adis16136,
> + &adis16136_serial_fops);
> + debugfs_create_file_unsafe("product_id", 0400,
> + indio_dev->debugfs_dentry,
> adis16136, &adis16136_product_id_fops);
> - debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry,
> + debugfs_create_file_unsafe("flash_count", 0400,
> + indio_dev->debugfs_dentry,
> adis16136, &adis16136_flash_count_fops);
>
> return 0;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-07 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-07 9:01 [PATCH] gyro:adis16136: fix debugfs_simple_attr.cocci warnings venkat.prashanth2498
2018-01-07 16:37 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.