All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT
Date: Sun, 7 Jan 2018 19:44:55 +0100	[thread overview]
Message-ID: <20180107184455.GG5545@piout.net> (raw)
In-Reply-To: <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org>

On 07/01/2018 at 19:07:13 +0100, Daniel Lezcano wrote:
> On 05/01/2018 15:30, Alexandre Belloni wrote:
> > With the new TCB clocksource driver, atmel platforms are now able to boot
> > without the PIT driver. Allow unselecting it.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> >  drivers/clocksource/Kconfig | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 5609572e0236..55ccfa0ba63b 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -381,7 +381,14 @@ config ARMV7M_SYSTICK
> >  
> >  config ATMEL_PIT
> >  	select TIMER_OF if OF
> > -	def_bool SOC_AT91SAM9 || SOC_SAMA5
> > +	bool "Atmel Periodic Interval Timer (PIT)"
> > +	depends on SOC_AT91SAM9 || SOC_SAMA5
> > +	default SOC_AT91SAM9 || SOC_SAMA5
> > +	help
> > +	  Select this to get a clocksource based on the Atmel Periodic Interval
> > +	  Timer. It has a relatively low resolution and the TC Block clocksource
> > +	  should be preferred.
> > +	  It also provides a clock event device.
> 
> Please conform to the format:
> 
> config ATMEL_PIT
> 	bool "Atmel Periodic Interval Timer (PIT)" if COMPILE_TEST
> 	select ...
> 	help
> 	    bla bla
> 
> and select ATMEL_PIT from the platform's Kconfig.
> 

Well, the goal is actually to allow people to unselect it so we don't
want the platform to select it.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT
Date: Sun, 7 Jan 2018 19:44:55 +0100	[thread overview]
Message-ID: <20180107184455.GG5545@piout.net> (raw)
In-Reply-To: <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org>

On 07/01/2018 at 19:07:13 +0100, Daniel Lezcano wrote:
> On 05/01/2018 15:30, Alexandre Belloni wrote:
> > With the new TCB clocksource driver, atmel platforms are now able to boot
> > without the PIT driver. Allow unselecting it.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> >  drivers/clocksource/Kconfig | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 5609572e0236..55ccfa0ba63b 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -381,7 +381,14 @@ config ARMV7M_SYSTICK
> >  
> >  config ATMEL_PIT
> >  	select TIMER_OF if OF
> > -	def_bool SOC_AT91SAM9 || SOC_SAMA5
> > +	bool "Atmel Periodic Interval Timer (PIT)"
> > +	depends on SOC_AT91SAM9 || SOC_SAMA5
> > +	default SOC_AT91SAM9 || SOC_SAMA5
> > +	help
> > +	  Select this to get a clocksource based on the Atmel Periodic Interval
> > +	  Timer. It has a relatively low resolution and the TC Block clocksource
> > +	  should be preferred.
> > +	  It also provides a clock event device.
> 
> Please conform to the format:
> 
> config ATMEL_PIT
> 	bool "Atmel Periodic Interval Timer (PIT)" if COMPILE_TEST
> 	select ...
> 	help
> 	    bla bla
> 
> and select ATMEL_PIT from the platform's Kconfig.
> 

Well, the goal is actually to allow people to unselect it so we don't
want the platform to select it.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2018-01-07 18:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 14:30 [PATCH v2 0/6] clocksource: rework Atmel TCB timer driver Alexandre Belloni
2018-01-05 14:30 ` Alexandre Belloni
2018-01-05 14:30 ` [PATCH v2 1/6] ARM: at91: add TCB registers definitions Alexandre Belloni
2018-01-05 14:30   ` Alexandre Belloni
2018-01-07 11:59   ` Philippe Ombredanne
2018-01-07 11:59     ` Philippe Ombredanne
2018-01-05 14:30 ` [PATCH v2 2/6] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks Alexandre Belloni
2018-01-05 14:30   ` Alexandre Belloni
2018-01-05 14:30 ` [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT Alexandre Belloni
2018-01-05 14:30   ` Alexandre Belloni
2018-01-07 18:07   ` Daniel Lezcano
2018-01-07 18:07     ` Daniel Lezcano
2018-01-07 18:44     ` Alexandre Belloni [this message]
2018-01-07 18:44       ` Alexandre Belloni
2018-01-08  7:23       ` Daniel Lezcano
2018-01-08  7:23         ` Daniel Lezcano
2018-01-08  8:22         ` Boris Brezillon
2018-01-08  8:22           ` Boris Brezillon
2018-01-08  8:53           ` Daniel Lezcano
2018-01-08  8:53             ` Daniel Lezcano
2018-01-05 14:30 ` [PATCH v2 4/6] ARM: configs: at91: use new TCB timer driver Alexandre Belloni
2018-01-05 14:30   ` Alexandre Belloni
2018-01-05 14:30 ` [PATCH v2 5/6] ARM: configs: at91: sama5: unselect ATMEL_PIT Alexandre Belloni
2018-01-05 14:30   ` Alexandre Belloni
2018-01-05 14:30 ` [PATCH v2 6/6] ARM: configs: at91: at91_dt " Alexandre Belloni
2018-01-05 14:30   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180107184455.GG5545@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.