All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-block@vger.kernel.org,
	"Stephen Bates" <sbates@raithlin.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Keith Busch" <keith.busch@intel.com>,
	"Sagi Grimberg" <sagi@grimberg.me>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Max Gurtovoy" <maxg@mellanox.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>
Subject: Re: [PATCH 06/12] IB/core: Add optional PCI P2P flag to rdma_rw_ctx_[init|destroy]()
Date: Mon, 8 Jan 2018 11:29:45 -0700	[thread overview]
Message-ID: <20180108182945.GG11348@ziepe.ca> (raw)
In-Reply-To: <3daea7fe-f64a-36a9-ca80-0cb4d9acf171@deltatee.com>

On Mon, Jan 08, 2018 at 11:17:38AM -0700, Logan Gunthorpe wrote:
 
> >>If at all it should be in the dma_map* wrappers, but for that we'd need
> >>a good identifier.  And it still would not solve the whole fake dma
> >>ops issue.
> >
> >Very long term the IOMMUs under the ops will need to care about this,
> >so the wrapper is not an optimal place to put it - but I wouldn't
> >object if it gets it out of RDMA :)
> 
> Well, creating the extra op doesn't really change anything to the RDMA patch
> in this series.

Not fundamentally, but it lets us solve the bugs the patch introduces
with hfi/etc

> The point is, for the time being, we need to track whether we are
> doing a P2P or normal mapping using a side channel as we don't have
> a good way of tracking it in the SGL at this time.

Well, that is disappointing for now, but I'm OK with the flag in the
RW interface - as long as we all sort of agree it is not desirable and
the SG should self-identify in an ideal someday future world..

Jason

WARNING: multiple messages have this Message-ID (diff)
From: jgg@ziepe.ca (Jason Gunthorpe)
Subject: [PATCH 06/12] IB/core: Add optional PCI P2P flag to rdma_rw_ctx_[init|destroy]()
Date: Mon, 8 Jan 2018 11:29:45 -0700	[thread overview]
Message-ID: <20180108182945.GG11348@ziepe.ca> (raw)
In-Reply-To: <3daea7fe-f64a-36a9-ca80-0cb4d9acf171@deltatee.com>

On Mon, Jan 08, 2018@11:17:38AM -0700, Logan Gunthorpe wrote:
 
> >>If at all it should be in the dma_map* wrappers, but for that we'd need
> >>a good identifier.  And it still would not solve the whole fake dma
> >>ops issue.
> >
> >Very long term the IOMMUs under the ops will need to care about this,
> >so the wrapper is not an optimal place to put it - but I wouldn't
> >object if it gets it out of RDMA :)
> 
> Well, creating the extra op doesn't really change anything to the RDMA patch
> in this series.

Not fundamentally, but it lets us solve the bugs the patch introduces
with hfi/etc

> The point is, for the time being, we need to track whether we are
> doing a P2P or normal mapping using a side channel as we don't have
> a good way of tracking it in the SGL at this time.

Well, that is disappointing for now, but I'm OK with the flag in the
RW interface - as long as we all sort of agree it is not desirable and
the SG should self-identify in an ideal someday future world..

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
Cc: "Christoph Hellwig" <hch-jcswGhMUV9g@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Stephen Bates" <sbates-pv7U853sEMVWk0Htik3J/w@public.gmane.org>,
	"Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	"Keith Busch"
	<keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Sagi Grimberg" <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	"Bjorn Helgaas"
	<bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"Max Gurtovoy" <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"Dan Williams"
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Jérôme Glisse" <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Benjamin Herrenschmidt"
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 06/12] IB/core: Add optional PCI P2P flag to rdma_rw_ctx_[init|destroy]()
Date: Mon, 8 Jan 2018 11:29:45 -0700	[thread overview]
Message-ID: <20180108182945.GG11348@ziepe.ca> (raw)
In-Reply-To: <3daea7fe-f64a-36a9-ca80-0cb4d9acf171-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>

On Mon, Jan 08, 2018 at 11:17:38AM -0700, Logan Gunthorpe wrote:
 
> >>If at all it should be in the dma_map* wrappers, but for that we'd need
> >>a good identifier.  And it still would not solve the whole fake dma
> >>ops issue.
> >
> >Very long term the IOMMUs under the ops will need to care about this,
> >so the wrapper is not an optimal place to put it - but I wouldn't
> >object if it gets it out of RDMA :)
> 
> Well, creating the extra op doesn't really change anything to the RDMA patch
> in this series.

Not fundamentally, but it lets us solve the bugs the patch introduces
with hfi/etc

> The point is, for the time being, we need to track whether we are
> doing a P2P or normal mapping using a side channel as we don't have
> a good way of tracking it in the SGL at this time.

Well, that is disappointing for now, but I'm OK with the flag in the
RW interface - as long as we all sort of agree it is not desirable and
the SG should self-identify in an ideal someday future world..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-01-08 18:29 UTC|newest]

Thread overview: 198+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 19:01 [PATCH 00/11] Copy Offload in NVMe Fabrics with P2P PCI Memory Logan Gunthorpe
2018-01-04 19:01 ` Logan Gunthorpe
2018-01-04 19:01 ` Logan Gunthorpe
2018-01-04 19:01 ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 01/12] pci-p2p: Support peer to peer memory Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 21:40   ` Bjorn Helgaas
2018-01-04 21:40     ` Bjorn Helgaas
2018-01-04 21:40     ` Bjorn Helgaas
2018-01-04 23:06     ` Logan Gunthorpe
2018-01-04 23:06       ` Logan Gunthorpe
2018-01-04 23:06       ` Logan Gunthorpe
2018-01-04 23:06       ` Logan Gunthorpe
2018-01-04 21:59   ` Bjorn Helgaas
2018-01-04 21:59     ` Bjorn Helgaas
2018-01-04 21:59     ` Bjorn Helgaas
2018-01-04 21:59     ` Bjorn Helgaas
2018-01-05  0:20     ` Logan Gunthorpe
2018-01-05  0:20       ` Logan Gunthorpe
2018-01-05  0:20       ` Logan Gunthorpe
2018-01-05  0:20       ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 02/12] pci-p2p: Add sysfs group to display p2pmem stats Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 21:50   ` Bjorn Helgaas
2018-01-04 21:50     ` Bjorn Helgaas
2018-01-04 21:50     ` Bjorn Helgaas
2018-01-04 22:25     ` Jason Gunthorpe
2018-01-04 22:25       ` Jason Gunthorpe
2018-01-04 22:25       ` Jason Gunthorpe
2018-01-04 22:25       ` Jason Gunthorpe
2018-01-04 23:13     ` Logan Gunthorpe
2018-01-04 23:13       ` Logan Gunthorpe
2018-01-04 23:13       ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 03/12] pci-p2p: Add PCI p2pmem dma mappings to adjust the bus offset Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 04/12] pci-p2p: Clear ACS P2P flags for all client devices Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 21:57   ` Bjorn Helgaas
2018-01-04 21:57     ` Bjorn Helgaas
2018-01-04 21:57     ` Bjorn Helgaas
2018-01-04 21:57     ` Bjorn Helgaas
2018-01-04 22:35     ` Alex Williamson
2018-01-04 22:35       ` Alex Williamson
2018-01-04 22:35       ` Alex Williamson
2018-01-05  0:00       ` Logan Gunthorpe
2018-01-05  0:00         ` Logan Gunthorpe
2018-01-05  0:00         ` Logan Gunthorpe
2018-01-05  0:00         ` Logan Gunthorpe
2018-01-05  1:09         ` Logan Gunthorpe
2018-01-05  1:09           ` Logan Gunthorpe
2018-01-05  1:09           ` Logan Gunthorpe
2018-01-05  3:33         ` Alex Williamson
2018-01-05  3:33           ` Alex Williamson
2018-01-05  3:33           ` Alex Williamson
2018-01-05  6:47           ` Jerome Glisse
2018-01-05  6:47             ` Jerome Glisse
2018-01-05  6:47             ` Jerome Glisse
2018-01-05  6:47             ` Jerome Glisse
2018-01-05 15:41             ` Alex Williamson
2018-01-05 15:41               ` Alex Williamson
2018-01-05 15:41               ` Alex Williamson
2018-01-05 17:10           ` Logan Gunthorpe
2018-01-05 17:10             ` Logan Gunthorpe
2018-01-05 17:10             ` Logan Gunthorpe
2018-01-05 17:10             ` Logan Gunthorpe
2018-01-05 17:18             ` Alex Williamson
2018-01-05 17:18               ` Alex Williamson
2018-01-05 17:18               ` Alex Williamson
2018-01-05 17:18               ` Alex Williamson
2018-01-04 19:01 ` [PATCH 05/12] block: Introduce PCI P2P flags for request and request queue Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 06/12] IB/core: Add optional PCI P2P flag to rdma_rw_ctx_[init|destroy]() Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:22   ` Jason Gunthorpe
2018-01-04 19:22     ` Jason Gunthorpe
2018-01-04 19:52     ` Logan Gunthorpe
2018-01-04 19:52       ` Logan Gunthorpe
2018-01-04 19:52       ` Logan Gunthorpe
2018-01-04 19:52       ` Logan Gunthorpe
2018-01-04 22:13       ` Jason Gunthorpe
2018-01-04 22:13         ` Jason Gunthorpe
2018-01-04 23:44         ` Logan Gunthorpe
2018-01-04 23:44           ` Logan Gunthorpe
2018-01-04 23:44           ` Logan Gunthorpe
2018-01-05  4:50           ` Jason Gunthorpe
2018-01-05  4:50             ` Jason Gunthorpe
2018-01-08 14:59             ` Christoph Hellwig
2018-01-08 14:59               ` Christoph Hellwig
2018-01-08 14:59               ` Christoph Hellwig
2018-01-08 18:09               ` Jason Gunthorpe
2018-01-08 18:09                 ` Jason Gunthorpe
2018-01-08 18:17                 ` Logan Gunthorpe
2018-01-08 18:17                   ` Logan Gunthorpe
2018-01-08 18:17                   ` Logan Gunthorpe
2018-01-08 18:17                   ` Logan Gunthorpe
2018-01-08 18:29                   ` Jason Gunthorpe [this message]
2018-01-08 18:29                     ` Jason Gunthorpe
2018-01-08 18:29                     ` Jason Gunthorpe
2018-01-08 18:34                 ` Christoph Hellwig
2018-01-08 18:34                   ` Christoph Hellwig
2018-01-08 18:34                   ` Christoph Hellwig
2018-01-08 18:34                   ` Christoph Hellwig
2018-01-08 18:44                   ` Logan Gunthorpe
2018-01-08 18:44                     ` Logan Gunthorpe
2018-01-08 18:44                     ` Logan Gunthorpe
2018-01-08 18:44                     ` Logan Gunthorpe
2018-01-08 18:57                     ` Christoph Hellwig
2018-01-08 18:57                       ` Christoph Hellwig
2018-01-08 18:57                       ` Christoph Hellwig
2018-01-08 18:57                       ` Christoph Hellwig
2018-01-08 19:05                       ` Logan Gunthorpe
2018-01-08 19:05                         ` Logan Gunthorpe
2018-01-08 19:05                         ` Logan Gunthorpe
2018-01-08 19:05                         ` Logan Gunthorpe
2018-01-09 16:47                         ` Christoph Hellwig
2018-01-09 16:47                           ` Christoph Hellwig
2018-01-09 16:47                           ` Christoph Hellwig
2018-01-09 16:47                           ` Christoph Hellwig
2018-01-08 19:49                       ` Jason Gunthorpe
2018-01-08 19:49                         ` Jason Gunthorpe
2018-01-09 16:46                         ` Christoph Hellwig
2018-01-09 16:46                           ` Christoph Hellwig
2018-01-09 16:46                           ` Christoph Hellwig
2018-01-09 17:10                           ` Jason Gunthorpe
2018-01-09 17:10                             ` Jason Gunthorpe
2018-01-08 19:01                   ` Jason Gunthorpe
2018-01-08 19:01                     ` Jason Gunthorpe
2018-01-08 19:01                     ` Jason Gunthorpe
2018-01-09 16:55                     ` Christoph Hellwig
2018-01-09 16:55                       ` Christoph Hellwig
2018-01-09 16:55                       ` Christoph Hellwig
2018-01-09 16:55                       ` Christoph Hellwig
2018-01-04 19:01 ` [PATCH 07/12] nvme-pci: clean up CMB initialization Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:08   ` Logan Gunthorpe
2018-01-04 19:08     ` Logan Gunthorpe
2018-01-04 19:08     ` Logan Gunthorpe
2018-01-04 19:08     ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 08/12] nvme-pci: clean up SMBSZ bit definitions Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:08   ` Logan Gunthorpe
2018-01-04 19:08     ` Logan Gunthorpe
2018-01-04 19:08     ` Logan Gunthorpe
2018-01-04 19:08     ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 09/12] nvme-pci: Use PCI p2pmem subsystem to manage the CMB Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-05 15:30   ` Marta Rybczynska
2018-01-05 15:30     ` Marta Rybczynska
2018-01-05 15:30     ` Marta Rybczynska
2018-01-05 15:30     ` Marta Rybczynska
2018-01-05 18:14     ` Logan Gunthorpe
2018-01-05 18:14       ` Logan Gunthorpe
2018-01-05 18:14       ` Logan Gunthorpe
2018-01-05 18:14       ` Logan Gunthorpe
2018-01-05 18:11   ` Keith Busch
2018-01-05 18:11     ` Keith Busch
2018-01-05 18:11     ` Keith Busch
2018-01-05 18:11     ` Keith Busch
2018-01-05 18:19     ` Logan Gunthorpe
2018-01-05 18:19       ` Logan Gunthorpe
2018-01-05 18:19       ` Logan Gunthorpe
2018-01-05 19:01       ` Keith Busch
2018-01-05 19:01         ` Keith Busch
2018-01-05 19:01         ` Keith Busch
2018-01-05 19:01         ` Keith Busch
2018-01-05 19:04         ` Logan Gunthorpe
2018-01-05 19:04           ` Logan Gunthorpe
2018-01-05 19:04           ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 10/12] nvme-pci: Add support for P2P memory in requests Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 11/12] nvme-pci: Add a quirk for a pseudo CMB Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01 ` [PATCH 12/12] nvmet: Optionally use PCI P2P memory Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe
2018-01-04 19:01   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108182945.GG11348@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=axboe@kernel.dk \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=jglisse@redhat.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.