* [PATCH] ASoC: rockchip: i2s: Support mono capture @ 2018-01-05 22:12 ` Matthias Kaehlcke 0 siblings, 0 replies; 11+ messages in thread From: Matthias Kaehlcke @ 2018-01-05 22:12 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Heiko Stuebner Cc: alsa-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Brian Norris, Dylan Reid, Matthias Kaehlcke The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- sound/soc/rockchip/rockchip_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 908211e1d6fc..cc22ab3d10dd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, val |= I2S_CHN_4; break; case 2: + case 1: val |= I2S_CHN_2; break; default: @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { }, .capture = { .stream_name = "Capture", - .channels_min = 2, + .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_192000, .formats = (SNDRV_PCM_FMTBIT_S8 | @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) } if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { - if (val >= 2 && val <= 8) + if (val >= 1 && val <= 8) soc_dai->capture.channels_max = val; } -- 2.16.0.rc0.223.g4a4ac83678-goog ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] ASoC: rockchip: i2s: Support mono capture @ 2018-01-05 22:12 ` Matthias Kaehlcke 0 siblings, 0 replies; 11+ messages in thread From: Matthias Kaehlcke @ 2018-01-05 22:12 UTC (permalink / raw) To: linux-arm-kernel The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- sound/soc/rockchip/rockchip_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 908211e1d6fc..cc22ab3d10dd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, val |= I2S_CHN_4; break; case 2: + case 1: val |= I2S_CHN_2; break; default: @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { }, .capture = { .stream_name = "Capture", - .channels_min = 2, + .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_192000, .formats = (SNDRV_PCM_FMTBIT_S8 | @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) } if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { - if (val >= 2 && val <= 8) + if (val >= 1 && val <= 8) soc_dai->capture.channels_max = val; } -- 2.16.0.rc0.223.g4a4ac83678-goog ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Applied "ASoC: rockchip: i2s: Support mono capture" to the asoc tree 2018-01-05 22:12 ` Matthias Kaehlcke (?) (?) @ 2018-01-08 12:35 ` Mark Brown -1 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-08 12:35 UTC (permalink / raw) To: Matthias Kaehlcke; +Cc: Mark Brown, Liam Girdwood The patch ASoC: rockchip: i2s: Support mono capture has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From db51707b9c9aeedd310ebce60f15d5bb006567e0 Mon Sep 17 00:00:00 2001 From: Matthias Kaehlcke <mka@chromium.org> Date: Fri, 5 Jan 2018 14:12:42 -0800 Subject: [PATCH] ASoC: rockchip: i2s: Support mono capture The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/rockchip/rockchip_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 908211e1d6fc..cc22ab3d10dd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, val |= I2S_CHN_4; break; case 2: + case 1: val |= I2S_CHN_2; break; default: @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { }, .capture = { .stream_name = "Capture", - .channels_min = 2, + .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_192000, .formats = (SNDRV_PCM_FMTBIT_S8 | @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) } if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { - if (val >= 2 && val <= 8) + if (val >= 1 && val <= 8) soc_dai->capture.channels_max = val; } -- 2.15.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Applied "ASoC: rockchip: i2s: Support mono capture" to the asoc tree @ 2018-01-08 12:35 ` Mark Brown 0 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-08 12:35 UTC (permalink / raw) To: Matthias Kaehlcke Cc: Mark Brown, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Heiko Stuebner, alsa-devel, Brian Norris, linux-kernel, linux-rockchip, Dylan Reid, linux-arm-kernel, alsa-devel The patch ASoC: rockchip: i2s: Support mono capture has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From db51707b9c9aeedd310ebce60f15d5bb006567e0 Mon Sep 17 00:00:00 2001 From: Matthias Kaehlcke <mka@chromium.org> Date: Fri, 5 Jan 2018 14:12:42 -0800 Subject: [PATCH] ASoC: rockchip: i2s: Support mono capture The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/rockchip/rockchip_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 908211e1d6fc..cc22ab3d10dd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, val |= I2S_CHN_4; break; case 2: + case 1: val |= I2S_CHN_2; break; default: @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { }, .capture = { .stream_name = "Capture", - .channels_min = 2, + .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_192000, .formats = (SNDRV_PCM_FMTBIT_S8 | @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) } if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { - if (val >= 2 && val <= 8) + if (val >= 1 && val <= 8) soc_dai->capture.channels_max = val; } -- 2.15.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Applied "ASoC: rockchip: i2s: Support mono capture" to the asoc tree @ 2018-01-08 12:35 ` Mark Brown 0 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-08 12:35 UTC (permalink / raw) To: linux-arm-kernel The patch ASoC: rockchip: i2s: Support mono capture has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From db51707b9c9aeedd310ebce60f15d5bb006567e0 Mon Sep 17 00:00:00 2001 From: Matthias Kaehlcke <mka@chromium.org> Date: Fri, 5 Jan 2018 14:12:42 -0800 Subject: [PATCH] ASoC: rockchip: i2s: Support mono capture The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/rockchip/rockchip_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 908211e1d6fc..cc22ab3d10dd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, val |= I2S_CHN_4; break; case 2: + case 1: val |= I2S_CHN_2; break; default: @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { }, .capture = { .stream_name = "Capture", - .channels_min = 2, + .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_192000, .formats = (SNDRV_PCM_FMTBIT_S8 | @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) } if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { - if (val >= 2 && val <= 8) + if (val >= 1 && val <= 8) soc_dai->capture.channels_max = val; } -- 2.15.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Applied "ASoC: rockchip: i2s: Support mono capture" to the asoc tree @ 2018-01-08 12:35 ` Mark Brown 0 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-08 12:35 UTC (permalink / raw) To: Matthias Kaehlcke; +Cc: Mark Brown, Liam Girdwood The patch ASoC: rockchip: i2s: Support mono capture has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From db51707b9c9aeedd310ebce60f15d5bb006567e0 Mon Sep 17 00:00:00 2001 From: Matthias Kaehlcke <mka@chromium.org> Date: Fri, 5 Jan 2018 14:12:42 -0800 Subject: [PATCH] ASoC: rockchip: i2s: Support mono capture The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/rockchip/rockchip_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 908211e1d6fc..cc22ab3d10dd 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, val |= I2S_CHN_4; break; case 2: + case 1: val |= I2S_CHN_2; break; default: @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { }, .capture = { .stream_name = "Capture", - .channels_min = 2, + .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_192000, .formats = (SNDRV_PCM_FMTBIT_S8 | @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) } if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { - if (val >= 2 && val <= 8) + if (val >= 1 && val <= 8) soc_dai->capture.channels_max = val; } -- 2.15.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoC: rockchip: i2s: Support mono capture 2018-01-05 22:12 ` Matthias Kaehlcke @ 2018-01-09 0:01 ` Matthias Kaehlcke -1 siblings, 0 replies; 11+ messages in thread From: Matthias Kaehlcke @ 2018-01-09 0:01 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Heiko Stuebner Cc: alsa-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Brian Norris, Dylan Reid El Fri, Jan 05, 2018 at 02:12:42PM -0800 Matthias Kaehlcke ha dit: > The Rockchip I2S controller only allows to configure even numbers of > capture channels. It is still possible to capture monophonic audio by > using dual-channel mode and ignoring the 'data' from the second > channel. Due to different issues in our audio recording path I couldn't test this properly, and only looked at the .wav data in audacity, which appeared to look ok. After putting some of the missing pieces together and I noticed that mono capture doesn't work as intended, the recorded audio is slowed down. I think this is because the I2S controller keeps generating a two-channel stream, however the sound system interprets it as a monophonic stream because of the channel configuration. Not sure if there is a clean solution for this if we can't tell the hardware to generate a single-channel stream. Any suggestions or do we have to revert the patch? Sorry about the mess :( > --- > sound/soc/rockchip/rockchip_i2s.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c > index 908211e1d6fc..cc22ab3d10dd 100644 > --- a/sound/soc/rockchip/rockchip_i2s.c > +++ b/sound/soc/rockchip/rockchip_i2s.c > @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, > val |= I2S_CHN_4; > break; > case 2: > + case 1: > val |= I2S_CHN_2; > break; > default: > @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { > }, > .capture = { > .stream_name = "Capture", > - .channels_min = 2, > + .channels_min = 1, > .channels_max = 2, > .rates = SNDRV_PCM_RATE_8000_192000, > .formats = (SNDRV_PCM_FMTBIT_S8 | > @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) > } > > if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { > - if (val >= 2 && val <= 8) > + if (val >= 1 && val <= 8) > soc_dai->capture.channels_max = val; > } > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ASoC: rockchip: i2s: Support mono capture @ 2018-01-09 0:01 ` Matthias Kaehlcke 0 siblings, 0 replies; 11+ messages in thread From: Matthias Kaehlcke @ 2018-01-09 0:01 UTC (permalink / raw) To: linux-arm-kernel El Fri, Jan 05, 2018 at 02:12:42PM -0800 Matthias Kaehlcke ha dit: > The Rockchip I2S controller only allows to configure even numbers of > capture channels. It is still possible to capture monophonic audio by > using dual-channel mode and ignoring the 'data' from the second > channel. Due to different issues in our audio recording path I couldn't test this properly, and only looked at the .wav data in audacity, which appeared to look ok. After putting some of the missing pieces together and I noticed that mono capture doesn't work as intended, the recorded audio is slowed down. I think this is because the I2S controller keeps generating a two-channel stream, however the sound system interprets it as a monophonic stream because of the channel configuration. Not sure if there is a clean solution for this if we can't tell the hardware to generate a single-channel stream. Any suggestions or do we have to revert the patch? Sorry about the mess :( > --- > sound/soc/rockchip/rockchip_i2s.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c > index 908211e1d6fc..cc22ab3d10dd 100644 > --- a/sound/soc/rockchip/rockchip_i2s.c > +++ b/sound/soc/rockchip/rockchip_i2s.c > @@ -328,6 +328,7 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream, > val |= I2S_CHN_4; > break; > case 2: > + case 1: > val |= I2S_CHN_2; > break; > default: > @@ -460,7 +461,7 @@ static struct snd_soc_dai_driver rockchip_i2s_dai = { > }, > .capture = { > .stream_name = "Capture", > - .channels_min = 2, > + .channels_min = 1, > .channels_max = 2, > .rates = SNDRV_PCM_RATE_8000_192000, > .formats = (SNDRV_PCM_FMTBIT_S8 | > @@ -654,7 +655,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) > } > > if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) { > - if (val >= 2 && val <= 8) > + if (val >= 1 && val <= 8) > soc_dai->capture.channels_max = val; > } > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoC: rockchip: i2s: Support mono capture 2018-01-09 0:01 ` Matthias Kaehlcke (?) @ 2018-01-09 16:39 ` Mark Brown -1 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-09 16:39 UTC (permalink / raw) To: Matthias Kaehlcke Cc: alsa-devel, Heiko Stuebner, linux-kernel, Brian Norris, Takashi Iwai, Liam Girdwood, linux-rockchip, Dylan Reid, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 975 bytes --] On Mon, Jan 08, 2018 at 04:01:15PM -0800, Matthias Kaehlcke wrote: > Due to different issues in our audio recording path I couldn't test > this properly, and only looked at the .wav data in audacity, which > appeared to look ok. After putting some of the missing pieces > together and I noticed that mono capture doesn't work as intended, > the recorded audio is slowed down. I think this is because the I2S > controller keeps generating a two-channel stream, however the sound > system interprets it as a monophonic stream because of the channel > configuration. That seems odd - I'd expect underruns somewhere? > Not sure if there is a clean solution for this if we can't tell the > hardware to generate a single-channel stream. Any suggestions or do > we have to revert the patch? It sounds like a very standard problem with I2S devices, it's a fundamentally stereo format after all. If you can't get it to discard the second channel there's probably not much doing. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoC: rockchip: i2s: Support mono capture @ 2018-01-09 16:39 ` Mark Brown 0 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-09 16:39 UTC (permalink / raw) To: Matthias Kaehlcke Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Heiko Stuebner, alsa-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Brian Norris, Dylan Reid [-- Attachment #1: Type: text/plain, Size: 975 bytes --] On Mon, Jan 08, 2018 at 04:01:15PM -0800, Matthias Kaehlcke wrote: > Due to different issues in our audio recording path I couldn't test > this properly, and only looked at the .wav data in audacity, which > appeared to look ok. After putting some of the missing pieces > together and I noticed that mono capture doesn't work as intended, > the recorded audio is slowed down. I think this is because the I2S > controller keeps generating a two-channel stream, however the sound > system interprets it as a monophonic stream because of the channel > configuration. That seems odd - I'd expect underruns somewhere? > Not sure if there is a clean solution for this if we can't tell the > hardware to generate a single-channel stream. Any suggestions or do > we have to revert the patch? It sounds like a very standard problem with I2S devices, it's a fundamentally stereo format after all. If you can't get it to discard the second channel there's probably not much doing. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ASoC: rockchip: i2s: Support mono capture @ 2018-01-09 16:39 ` Mark Brown 0 siblings, 0 replies; 11+ messages in thread From: Mark Brown @ 2018-01-09 16:39 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 08, 2018 at 04:01:15PM -0800, Matthias Kaehlcke wrote: > Due to different issues in our audio recording path I couldn't test > this properly, and only looked at the .wav data in audacity, which > appeared to look ok. After putting some of the missing pieces > together and I noticed that mono capture doesn't work as intended, > the recorded audio is slowed down. I think this is because the I2S > controller keeps generating a two-channel stream, however the sound > system interprets it as a monophonic stream because of the channel > configuration. That seems odd - I'd expect underruns somewhere? > Not sure if there is a clean solution for this if we can't tell the > hardware to generate a single-channel stream. Any suggestions or do > we have to revert the patch? It sounds like a very standard problem with I2S devices, it's a fundamentally stereo format after all. If you can't get it to discard the second channel there's probably not much doing. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180109/a50d896d/attachment.sig> ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-01-09 16:40 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-01-05 22:12 [PATCH] ASoC: rockchip: i2s: Support mono capture Matthias Kaehlcke 2018-01-05 22:12 ` Matthias Kaehlcke 2018-01-08 12:35 ` Applied "ASoC: rockchip: i2s: Support mono capture" to the asoc tree Mark Brown 2018-01-08 12:35 ` Mark Brown 2018-01-08 12:35 ` Mark Brown 2018-01-08 12:35 ` Mark Brown 2018-01-09 0:01 ` [PATCH] ASoC: rockchip: i2s: Support mono capture Matthias Kaehlcke 2018-01-09 0:01 ` Matthias Kaehlcke 2018-01-09 16:39 ` Mark Brown 2018-01-09 16:39 ` Mark Brown 2018-01-09 16:39 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.